We noticed in tests/production that there is a low probability failure
where /etc/hosts could have some garbage characters before the entry for
local host name. The consequence is that all sudo command would be very
slow. In extreme cases it would prevent some services from starting
properly.
I suspect that the /etc/hosts file might be opened by some process causing
the issue. Editing contents with new file level and replace the whole file
should be safer.
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
- What I did
This fix removes the possibility of 'localhost' entry getting removed from /etc/hosts file by hostname-config service.
Without this change, whenever we change the hostname from 'localhost' to any other name on the config_db.json and reload the config, /etc/hosts file will only have the new hostname on it. But there are multiple sonic utilities (eg: swssconfig) which relies on the hard coded 'localhost' name and they tend to stop working.
- How I did it
Added a new check on hostname-config.sh script to avid blindly deleting the line containing the old hostname from /etc/hosts file. Now it will delete the old hostname only if its not localhost or when the hostname is not changing.
- How to verify it
Bring up SONiC on a device with hostname as localhost
Edit /etc/sonic/config_db.json to update the 'hostname' filed under DEVICE_METADATA from "hostname" : "localhost" --> "hostname" : "sonic"
run config reload -y to reflect the hostname change done on config_db.json file.
cat /etc/hosts and check whether both 127.0.0.1 localhost and 127.0.0.1 sonic entry are present on the file.
ping localhost should work fine.
- Description for the changelog
Make hostname-config service more robust in handling SONiC hostname change from localhost to anything else.
Submodule src/sonic-utilities fb5902f..d315dd7:
> show pfcwd status to be 'N/A' when pfcwd is stopped (#682)
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
* Feature is downported
* Add monitors to the test minigraphs
* Test
* No pfx filer
* Fix bgp sample
* Quagga requires to activate peer-group before configuration
- after reloading minigraph, write latest version string in the DB.
- if old config_db.json file exists, use it and migrate to latest version.
- only reload minigraph when config_db.json doesn't exist and minigraph
exists.
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Submodule src/sonic-utilities 54946e9..5b1fa3c:
> [neighbor_advertiser] Verify that DIPs returned from ferret are not in device VLAN (#670)
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Submodule src/sonic-swss 0e5c1ff..fcd091c:
> [mirrororch]: Remove mirror session state after it is remvoed (#1066)
Submodule src/sonic-utilities a89b9d4..54946e9:
> [acl_loader]: Add monitor port column in show mirror_session output (#662)
> [warm/fast reboot] some service docker might have been stopped already (#668)
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
* Remove the divide by 4 operation to the under the hood SAI
This is to avoid the need and thus the confusion for application program to know
the mmu internal architecture
This change must have support from SAI change to reach the correct
config
Signed-off-by: Wenda <wenni@microsoft.com>
* Relegate the divide by 4 operation to the under the hood SAI for egress
lossless pool
Extend to 7060 and 6100
Signed-off-by: Wenda <wenni@microsoft.com>
* Add more TH/TH2 hwskus
Signed-off-by: Wenda Ni <wenni@microsoft.com>
* Update config test
Signed-off-by: Wenda Ni <wenni@microsoft.com>
* Add TH2 ingress lossy profile
Signed-off-by: Wenda Ni <wenni@microsoft.com>
* Move the divide by 4 operation to SAI internal
Signed-off-by: Wenda Ni <wenni@microsoft.com>
* [bcm SAI] Upgrade Broadcom SAI to version 3.5.3.1-15
- Broadcom SAI 3.5 GA release 20190924.
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
* add config.bcm for hlx
* modify config.bcm path for hlx
* Delete hx4-cel-hbtn-48x1G+4x10G.config.bcm
* add config.bcm and path
* update led for cxp
* Add new device data for dx010
* Add debug docker for SNMP.
* Removed a redundant install of debug packages.
Propagate the debug flag to template file to mount /dbg & /src to debug containers.
* Revert the last change to retain the original
Submodule src/sonic-sairedis 1cf2eea..55ec4d2:
> [syncd]: support query port with 8 lanes (400G)
Submodule src/sonic-swss 2974844..24fcbb6:
> support 8 lanes for a physical port (#778)
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Submodule src/sonic-utilities f76fc2c..fe2c656:
> [warm-reboot]: Do not clean up mirror session state database (#639)
> [config] Reset failed status of all SONiC services, whether or not they are currently failed (#619)
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
