matthew/sonic-buildimage
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Nokia ixs7215] sfp get_name test case fix (#8507)

Browse Source 
Account for sfputil_helper indexing being 0 based

Co-authored-by: Carl Keene <keene@nokia.com>
This commit is contained in:
carl-nokia 2021-08-20 01:31:18 -04:00 committed by Qi Luo
parent b82abd8dff
commit 32a58e5754
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
platform/marvell-armhf/sonic-platform-nokia/7215/sonic_platform/sfp.py
View File

@ -799,6 +799,9 @@ class Sfp(SfpBase):
Returns: Returns:
A boolean, True if tx_disable is set successfully, False if not A boolean, True if tx_disable is set successfully, False if not
""" """
if self.sfp_type == COPPER_TYPE:
return False
if smbus_present == 0: # if called from sfputil outside of pmon if smbus_present == 0: # if called from sfputil outside of pmon
cmdstatus, register = cmd.getstatusoutput('sudo i2cget -y 0 0x41 0x5') cmdstatus, register = cmd.getstatusoutput('sudo i2cget -y 0 0x41 0x5')
if cmdstatus: if cmdstatus:
@ -888,7 +891,7 @@ class Sfp(SfpBase):
sfputil_helper = SfpUtilHelper() sfputil_helper = SfpUtilHelper()
sfputil_helper.read_porttab_mappings( sfputil_helper.read_porttab_mappings(
self.__get_path_to_port_config_file()) self.__get_path_to_port_config_file())
name = sfputil_helper.logical[self.index] or "Unknown" name = sfputil_helper.logical[self.index-1] or "Unknown"
return name return name
def get_presence(self): def get_presence(self):