From 32a58e575474e5f71e01ca33c1376ff92b5a07f9 Mon Sep 17 00:00:00 2001 From: carl-nokia <63672637+carl-nokia@users.noreply.github.com> Date: Fri, 20 Aug 2021 01:31:18 -0400 Subject: [PATCH] [Nokia ixs7215] sfp get_name test case fix (#8507) Account for sfputil_helper indexing being 0 based Co-authored-by: Carl Keene --- .../sonic-platform-nokia/7215/sonic_platform/sfp.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/platform/marvell-armhf/sonic-platform-nokia/7215/sonic_platform/sfp.py b/platform/marvell-armhf/sonic-platform-nokia/7215/sonic_platform/sfp.py index ead408b41b..308e8b29a6 100644 --- a/platform/marvell-armhf/sonic-platform-nokia/7215/sonic_platform/sfp.py +++ b/platform/marvell-armhf/sonic-platform-nokia/7215/sonic_platform/sfp.py @@ -799,6 +799,9 @@ class Sfp(SfpBase): Returns: A boolean, True if tx_disable is set successfully, False if not """ + if self.sfp_type == COPPER_TYPE: + return False + if smbus_present == 0: # if called from sfputil outside of pmon cmdstatus, register = cmd.getstatusoutput('sudo i2cget -y 0 0x41 0x5') if cmdstatus: @@ -888,7 +891,7 @@ class Sfp(SfpBase): sfputil_helper = SfpUtilHelper() sfputil_helper.read_porttab_mappings( self.__get_path_to_port_config_file()) - name = sfputil_helper.logical[self.index] or "Unknown" + name = sfputil_helper.logical[self.index-1] or "Unknown" return name def get_presence(self):