matthew/sonic-buildimage
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[minigraph-parser] Update the definition of acl table type BMCDATA and BMCDATAV6 (#16249)

Browse Source 
Why I did it
According to ACL-Table-Type-HLD, the value type of MATCHES, ACTIONS and BIND_POINTS should be list instead of string. Opening this PR to update the definition of BMCDATA and BMCDATAV6.

How I did it
Update the definition of BMCDATA and BMCDATAV6 in minigraph-parser.

How to verify it
Verified by UT and build SONiC image.
This commit is contained in:
Zhijian Li 2023-08-28 23:40:55 +08:00 committed by mssonicbld
parent 82fa2d6a26
commit 2941df3289
2 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/sonic-config-engine/minigraph.py
View File

@ -54,14 +54,14 @@ vni_default = 8000
# Defination of custom acl table types # Defination of custom acl table types
acl_table_type_defination = { acl_table_type_defination = {
'BMCDATA': { 'BMCDATA': {
"ACTIONS": "PACKET_ACTION,COUNTER", "ACTIONS": ["PACKET_ACTION", "COUNTER"],
"BIND_POINTS": "PORT", "BIND_POINTS": ["PORT"],
"MATCHES": "SRC_IP,DST_IP,ETHER_TYPE,IP_TYPE,IP_PROTOCOL,IN_PORTS,L4_SRC_PORT,L4_DST_PORT,L4_SRC_PORT_RANGE,L4_DST_PORT_RANGE", "MATCHES": ["SRC_IP", "DST_IP", "ETHER_TYPE", "IP_TYPE", "IP_PROTOCOL", "IN_PORTS", "L4_SRC_PORT", "L4_DST_PORT", "L4_SRC_PORT_RANGE", "L4_DST_PORT_RANGE"]
}, },
'BMCDATAV6': { 'BMCDATAV6': {
"ACTIONS": "PACKET_ACTION,COUNTER", "ACTIONS": ["PACKET_ACTION", "COUNTER"],
"BIND_POINTS": "PORT", "BIND_POINTS": ["PORT"],
"MATCHES": "SRC_IPV6,DST_IPV6,ETHER_TYPE,IP_TYPE,IP_PROTOCOL,IN_PORTS,L4_SRC_PORT,L4_DST_PORT,L4_SRC_PORT_RANGE,L4_DST_PORT_RANGE", "MATCHES": ["SRC_IPV6", "DST_IPV6", "ETHER_TYPE", "IP_TYPE", "IP_PROTOCOL", "IN_PORTS", "L4_SRC_PORT", "L4_DST_PORT", "L4_SRC_PORT_RANGE", "L4_DST_PORT_RANGE"]
} }
} }

12
src/sonic-config-engine/tests/test_minigraph_case.py
View File

@ -497,14 +497,14 @@ class TestCfgGenCaseInsensitive(TestCase):
def test_minigraph_acl_type_bmcdata(self): def test_minigraph_acl_type_bmcdata(self):
expected_acl_type_bmcdata = { expected_acl_type_bmcdata = {
"ACTIONS": "PACKET_ACTION,COUNTER", "ACTIONS": ["PACKET_ACTION", "COUNTER"],
"BIND_POINTS": "PORT", "BIND_POINTS": ["PORT"],
"MATCHES": "SRC_IP,DST_IP,ETHER_TYPE,IP_TYPE,IP_PROTOCOL,IN_PORTS,L4_SRC_PORT,L4_DST_PORT,L4_SRC_PORT_RANGE,L4_DST_PORT_RANGE", "MATCHES": ["SRC_IP", "DST_IP", "ETHER_TYPE", "IP_TYPE", "IP_PROTOCOL", "IN_PORTS", "L4_SRC_PORT", "L4_DST_PORT", "L4_SRC_PORT_RANGE", "L4_DST_PORT_RANGE"],
} }
expected_acl_type_bmcdatav6 = { expected_acl_type_bmcdatav6 = {
"ACTIONS": "PACKET_ACTION,COUNTER", "ACTIONS": ["PACKET_ACTION", "COUNTER"],
"BIND_POINTS": "PORT", "BIND_POINTS": ["PORT"],
"MATCHES": "SRC_IPV6,DST_IPV6,ETHER_TYPE,IP_TYPE,IP_PROTOCOL,IN_PORTS,L4_SRC_PORT,L4_DST_PORT,L4_SRC_PORT_RANGE,L4_DST_PORT_RANGE", "MATCHES": ["SRC_IPV6", "DST_IPV6", "ETHER_TYPE", "IP_TYPE", "IP_PROTOCOL", "IN_PORTS", "L4_SRC_PORT", "L4_DST_PORT", "L4_SRC_PORT_RANGE", "L4_DST_PORT_RANGE"],
} }
expected_acl_table_bmc_acl_northbound = { expected_acl_table_bmc_acl_northbound = {
'policy_desc': 'BMC_ACL_NORTHBOUND', 'policy_desc': 'BMC_ACL_NORTHBOUND',