Ensure mandatory fields to enable find-replace OK button

client/findreplace.cpp

@@ -21,6 +21,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>
 
 #include "abstractprotocol.h"
 #include "iputils.h"
+#include "mandatoryfieldsgroup.h"
 #include "protocolmanager.h"
 #include "stream.h"
 #include "uint128.h"
@@ -55,7 +56,23 @@ FindReplaceDialog::FindReplaceDialog(Action *action, QWidget *parent)
     // Reset for user input
     action->selectedStreamsOnly = false;
 
-    buttonBox->button(QDialogButtonBox::Ok)->setText(tr("Replace All"));
+    QPushButton *ok = buttonBox->button(QDialogButtonBox::Ok);
+    ok->setText(tr("Replace All"));
+    ok->setDisabled(true);
+
+    mandatoryFields_ = new MandatoryFieldsGroup(this);
+    mandatoryFields_->add(protocol);
+    mandatoryFields_->add(field);
+    mandatoryFields_->add(findValue);
+    mandatoryFields_->add(findMask);
+    mandatoryFields_->add(replaceValue);
+    mandatoryFields_->add(replaceMask);
+    mandatoryFields_->setSubmitButton(ok);
+}
+
+FindReplaceDialog::~FindReplaceDialog()
+{
+    delete mandatoryFields_;
 }
 
 void FindReplaceDialog::on_protocol_currentIndexChanged(const QString &name)

client/findreplace.h

@@ -22,6 +22,8 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>
 
 #include "ui_findreplace.h"
 
+class MandatoryFieldsGroup;
+
 class FindReplaceDialog: public QDialog, public Ui::FindReplace
 {
     Q_OBJECT
@@ -29,6 +31,7 @@ public:
     struct Action;
 
     FindReplaceDialog(Action *action, QWidget *parent = 0);
+    ~FindReplaceDialog();
 
 private slots:
     void on_protocol_currentIndexChanged(const QString &name);
@@ -42,6 +45,7 @@ private:
     quint32 protocolId_{0};
     Action *action_{nullptr};
     QList<FieldAttrib> fieldAttrib_;
+    MandatoryFieldsGroup *mandatoryFields_{nullptr};
 };
 
 struct FindReplaceDialog::Action

client/mandatoryfieldsgroup.cpp

@@ -0,0 +1,126 @@
+/*
+Copyright (C) 2021 Srivats P.
+
+This file is part of "Ostinato"
+
+This is free software: you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation, either version 3 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with this program.  If not, see <http://www.gnu.org/licenses/>
+*/
+
+#include "mandatoryfieldsgroup.h"
+
+// No need for QDateEdit, QSpinBox, etc., since these always return values
+#include <QCheckBox>
+#include <QComboBox>
+#include <QLineEdit>
+#include <QPushButton>
+#include <QWidget>
+
+void MandatoryFieldsGroup::add(QWidget *widget)
+{
+    if (!widgets_.contains(widget)) {
+        if (widget->inherits("QCheckBox"))
+            connect(qobject_cast<QCheckBox*>(widget),
+                    SIGNAL(clicked()),
+                    this, SLOT(changed()));
+        else if (widget->inherits("QComboBox"))
+            connect(qobject_cast<QComboBox*>(widget),
+                    SIGNAL(highlighted(int)),
+                    this, SLOT(changed()));
+        else if (widget->inherits("QLineEdit"))
+            connect(qobject_cast<QLineEdit*>(widget),
+                    SIGNAL(textChanged(const QString&)),
+                    this, SLOT(changed()));
+        else {
+            qWarning("MandatoryFieldsGroup: unsupported class %s",
+                     widget->metaObject()->className());
+            return;
+        }
+
+        widgets_.append(widget);
+        changed();
+    }
+}
+
+void MandatoryFieldsGroup::remove(QWidget *widget)
+{
+    widgets_.removeAll(widget);
+
+    changed();
+}
+
+void MandatoryFieldsGroup::setSubmitButton(QPushButton *button)
+{
+    if (submitButton_ && submitButton_ != button)
+        submitButton_->setEnabled(true);
+    submitButton_ = button;
+
+    changed();
+}
+
+void MandatoryFieldsGroup::changed()
+{
+    if (!submitButton_)
+        return;
+
+    bool enable = true;
+    for (auto widget : widgets_) {
+        // Invisible mandatory widgets are treated as non-mandatory
+        if (!widget->isVisible())
+            continue;
+
+        if (widget->inherits("QCheckBox")) {
+            // Makes sense only for tristate checkbox
+            auto checkBox = qobject_cast<const QCheckBox*>(widget);
+            if (checkBox->checkState() == Qt::PartiallyChecked) {
+                enable = false;
+                break;
+            } else
+                continue;
+        }
+
+        if (widget->inherits("QComboBox")) {
+            auto comboBox = qobject_cast<const QComboBox*>(widget);
+            if (comboBox->currentText().isEmpty()) {
+                enable = false;
+                break;
+            } else
+                continue;
+        }
+
+        if (widget->inherits("QLineEdit")) {
+            auto lineEdit = qobject_cast<const QLineEdit*>(widget);
+            if (lineEdit->text().isEmpty()
+                    || !lineEdit->hasAcceptableInput()) {
+                enable = false;
+                break;
+            } else
+                continue;
+        }
+    }
+
+    submitButton_->setEnabled(enable);
+}
+
+void MandatoryFieldsGroup::clear()
+{
+    widgets_.clear();
+
+    if (submitButton_) {
+        submitButton_->setEnabled(true);
+        submitButton_ = nullptr;
+    }
+}
+
+
+

client/mandatoryfieldsgroup.h

@@ -0,0 +1,59 @@
+/*
+Copyright (C) 2021 Srivats P.
+
+This file is part of "Ostinato"
+
+This is free software: you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation, either version 3 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with this program.  If not, see <http://www.gnu.org/licenses/>
+*/
+
+#ifndef _MANDATORY_FIELDS_GROUP_H
+#define _MANDATORY_FIELDS_GROUP_H
+
+#include <QObject.h>
+#include <QList.h>
+
+class QPushButton;
+class QWidget;
+
+// Adapted from https://doc.qt.io/archives/qq/qq11-mandatoryfields.html
+// and improved
+
+class MandatoryFieldsGroup : public QObject
+{
+    Q_OBJECT
+
+public:
+    MandatoryFieldsGroup(QObject *parent)
+        : QObject(parent)
+    {
+    }
+
+    void add(QWidget *widget);
+    void remove(QWidget *widget);
+    void setSubmitButton(QPushButton *button);
+
+public slots:
+    void clear();
+
+private slots:
+    void changed();
+
+private:
+    QList<const QWidget*> widgets_;
+    QPushButton *submitButton_{nullptr};
+};
+
+
+#endif
+

client/ostinato.pro

@@ -47,6 +47,7 @@ HEADERS += \
     logswindow.h \
     findreplace.h \
     mainwindow.h \
+    mandatoryfieldsgroup.h \
     ndpstatusmodel.h \
     packetmodel.h \
     port.h \
@@ -106,6 +107,7 @@ SOURCES += \
     findreplace.cpp \
     main.cpp \
     mainwindow.cpp \
+    mandatoryfieldsgroup.cpp \
     ndpstatusmodel.cpp \
     packetmodel.cpp \
     params.cpp \