matthew/ostinato
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Change pcap import recalcCksum default to false

Browse Source 
This was changed so that pcap import test produces minimal diffs like
earlier. However, for user, the import options dialog overrules this
default, so that user default remains recalcCksum as true
This commit is contained in:
Srivats P 2021-12-12 11:06:36 +05:30
parent 9208423372
commit 4bfd546f21
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
common/pcapfileformat.cpp
View File

@ -52,6 +52,11 @@ PcapImportOptionsDialog::PcapImportOptionsDialog(QVariantMap *options)
options_->value("RecalculateCksums").toBool());
doDiff->setChecked(options_->value("DoDiff").toBool());
// XXX: By default this is false - for pcap import tests to show
// minimal diffs. However, for the user, this should be enabled
// by default
recalculateCksums->setChecked(true);
connect(buttonBox, SIGNAL(accepted()), this, SLOT(accept()));
}
@ -71,7 +76,7 @@ void PcapImportOptionsDialog::accept()
PcapFileFormat::PcapFileFormat()
{
importOptions_.insert("ViaPdml", true);
importOptions_.insert("RecalculateCksums", true);
importOptions_.insert("RecalculateCksums", false);
importOptions_.insert("DoDiff", true);
}