matthew/ostinato
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bugfix: When we add a portgroup, there was a delay in the port stats window showing '*' in the column titles

Browse Source
This commit is contained in:
Srivats P. 2015-05-08 21:24:52 +05:30
parent 250065970f
commit 1dbc4120c9
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
client/portgroup.cpp
View File

@ -356,10 +356,14 @@ void PortGroup::processPortConfigList(PbRpcController *controller)
mPorts[id]->updatePortConfig(portConfigList->mutable_port(i));
}
//emit portListChanged(mPortGroupId);
// FIXME: check if we need new signals since we are not changing the
// number of ports, just the port data
// FIXME: Ideally we should emit portGroupDataChanged since only
// port data is changing; but writing the corresponding slot in
// PortStatsModel for that signal turned out to be very bug prone
// causing assert failures when portgroups are added/deleted or
// connected/disconnected in different orders
// TODO: Revisit this when we refactor the domain-objects/model/view
// design
emit portListChanged(mPortGroupId);
if (numPorts() > 0)
getStreamIdList();