From 1dbc4120c9731f5bd87fb6d1be0cab6fd1d83170 Mon Sep 17 00:00:00 2001 From: "Srivats P." Date: Fri, 8 May 2015 21:24:52 +0530 Subject: [PATCH] Bugfix: When we add a portgroup, there was a delay in the port stats window showing '*' in the column titles --- client/portgroup.cpp | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/client/portgroup.cpp b/client/portgroup.cpp index 6991f10..46d93a2 100644 --- a/client/portgroup.cpp +++ b/client/portgroup.cpp @@ -356,10 +356,14 @@ void PortGroup::processPortConfigList(PbRpcController *controller) mPorts[id]->updatePortConfig(portConfigList->mutable_port(i)); } - //emit portListChanged(mPortGroupId); - - // FIXME: check if we need new signals since we are not changing the - // number of ports, just the port data + // FIXME: Ideally we should emit portGroupDataChanged since only + // port data is changing; but writing the corresponding slot in + // PortStatsModel for that signal turned out to be very bug prone + // causing assert failures when portgroups are added/deleted or + // connected/disconnected in different orders + // TODO: Revisit this when we refactor the domain-objects/model/view + // design + emit portListChanged(mPortGroupId); if (numPorts() > 0) getStreamIdList();