matthew/sonic-buildimage
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
This repository has been archived on 2025-03-20. You can view files and clone it, but cannot push or open issues or pull requests.
f21a45b68a
sonic-buildimage/.azure-pipelines
History
Mohamed Ghoneim f21a45b68a
[build] fix build exception and revert #9136 (#10037) 
#### Why I did it

1. Fix Build exception [example](https://dev.azure.com/mssonic/build/_build/results?buildId=73911&view=logs&jobId=88ce9a53-729c-5fa9-7b6e-3d98f2488e3f&j=cef3d8a9-152e-5193-620b-567dc18af272&t=ac3bce9f-b126-5a26-3fee-28ce0ec1679d)

```
2022-02-19T01:54:23.4200556Z ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/usr/local/lib/python3.8/dist-packages/markupsafe/__init__.py)
```

This is because Jinja2 uses MarkupSafe without specifying an upper limit to the version, MarkupSafe version that was released today removed 'soft_unicode'. So now Jinja2 is complaining.

Related issues:
https://github.com/pallets/jinja/issues/1591
https://github.com/aws/aws-sam-cli/issues/3661


2. Reverts #9136

Fixing build failures in SONiC utils [example](https://dev.azure.com/mssonic/build/_build/results?buildId=73784&view=logs&jobId=83516c17-6666-5250-abde-63983ce72a49&j=83516c17-6666-5250-abde-63983ce72a49&t=6177235f-d4f1-5f72-835a-90ebb93a1784)

One of the errors:
```
 TestPathAddressing.test_find_ref_paths__ref_is_the_whole_key__returns_ref_paths 

self = <tests.generic_config_updater.gu_common_test.TestPathAddressing testMethod=test_find_ref_paths__ref_is_the_whole_key__returns_ref_paths>

    def test_find_ref_paths__ref_is_the_whole_key__returns_ref_paths(self):
        # Arrange
        path = "/PORT/Ethernet0"
        expected = [
            "/ACL_TABLE/NO-NSW-PACL-V4/ports/0",
            "/VLAN_MEMBER/Vlan1000|Ethernet0",
        ]
    
        # Act
        actual = self.path_addressing.find_ref_paths(path, Files.CROPPED_CONFIG_DB_AS_JSON)
    
        # Assert
>       self.assertEqual(expected, actual)
E       AssertionError: Lists differ: ['/ACL_TABLE/NO-NSW-PACL-V4/ports/0', '/VLAN_MEMBER/Vlan1000|Ethernet0'] != ['/ACL_TABLE/NO-NSW-PACL-V4/ports/0']
E       
E       First list contains 1 additional elements.
E       First extra element 1:
E       '/VLAN_MEMBER/Vlan1000|Ethernet0'
E       
E       - ['/ACL_TABLE/NO-NSW-PACL-V4/ports/0', '/VLAN_MEMBER/Vlan1000|Ethernet0']
E       + ['/ACL_TABLE/NO-NSW-PACL-V4/ports/0']
```

The VLAN_MEMBER backlink (can be called referrer link or ref link) is not found.

Issue introduced by https://github.com/Azure/sonic-buildimage/pull/9136
I don't know how this PR passed the build system, it should have failed.

Known YANG issue https://github.com/Azure/sonic-buildimage/issues/9312

#### How I did it
The import to `sonic-vlan` is breaking the build
```
    import sonic-vlan {
        prefix vlan;
    }
```

I am not sure if that's the only issue, so I think reverting the whole PR should be the safer option.

#### How to verify it
Ran sonic-utils tests locally.
2022-02-21 11:07:29 -08:00
..
azure-pipelines-build.yml [CI] Fix Azure pipeline set -e not work. (#9282) 2021-11-17 21:01:41 -08:00
azure-pipelines-image-template.yml [build] fix build exception and revert #9136 (#10037) 2022-02-21 11:07:29 -08:00
azure-pipelines-job-groups.yml [ci]: Increase pipeline build timeout from 12 hours to 15 hours (#9200) 2021-11-09 07:35:18 -08:00
azure-pipelines-Official.yml Add azure pipelines for reproducible build (#6870) 2021-02-25 13:44:58 +08:00
azure-pipelines-repd-build-variables.yml [Build]: Support reproducible build for release branches (#9426) 2021-12-23 16:16:55 +08:00
azure-pipelines-UpgrateVersion.yml [Bug][Build]: Fix azp trigger branches error (#9668) 2022-01-04 19:55:30 +08:00
build-template.yml [ci]: get build logs when build fails (#7219) 2021-04-03 09:28:56 -07:00
cleanup.yml [CI] Fix pipeline template artifacts struct bug and cleanup bug 2021-04-21 09:03:11 -07:00
docker-sonic-mgmt.yml [CI] Add publish step in docker-sonic-mgmt azure pipeline (#7902) 2021-06-17 10:26:21 -07:00
docker-sonic-slave-arm64.yml [ci]: add native arm64/armhf sonic-slave build pipeline (#9056) 2021-11-06 03:42:51 -07:00
docker-sonic-slave-armhf.yml [ci]: add native arm64/armhf sonic-slave build pipeline (#9056) 2021-11-06 03:42:51 -07:00
docker-sonic-slave-template.yml [ci]: add native arm64/armhf sonic-slave build pipeline (#9056) 2021-11-06 03:42:51 -07:00
docker-sonic-slave.yml [Bug][Build]: fix the file not found issue caused by the relative pat… (#9443) 2021-12-03 21:23:09 -08:00
dpkg-cache-cleanup.yml [CI] Add Bldenv pipeline files (#7458) 2021-04-30 16:35:38 -07:00
official-build-cache.yml [Build]: Support reproducible build for release branches (#9426) 2021-12-23 16:16:55 +08:00
official-build-cisco-8000.yml Fix failed to download cisco artifacts issue (#8942) 2021-10-14 14:14:27 +08:00
official-build-multi-asic.yml [Build]: Support reproducible build for release branches (#9426) 2021-12-23 16:16:55 +08:00
official-build.yml [Build]: Support reproducible build for release branches (#9426) 2021-12-23 16:16:55 +08:00
run-test-template.yml [azure-pipeline][multi-asic]: Add azure pipeline script to generate multi asic vs image (#8215) 2021-09-24 11:14:43 -07:00