93247a6e24
- Why I did it There were compilation errors and warnings like, /usr/src/linux-headers-5.10.0-8-2-common/scripts/Makefile.build:69: You cannot use subdir-y/m to visit a module Makefile. Use obj-y/m instead. fatal error: linux/platform_data/pca954x.h: No such file or directory hwmon_device_register() is deprecated. Please convert the driver to use hwmon_device_register_with_info(). If PDDF kernel module compilation fails, the PDDF debian package was not detecting the break. - How I did it Modified the code with new kernel 5.10 APIs. Modified the Makefiles to use 'obj-m' instead of 'subdir-y' - How to verify it PDDF is supported on Accton platform. Load the build on AS7326 setup and check the 'dmesg'
225 lines
6.4 KiB
C
225 lines
6.4 KiB
C
/*
|
|
* Copyright 2019 Broadcom.
|
|
* The term “Broadcom” refers to Broadcom Inc. and/or its subsidiaries.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
*
|
|
* A pddf kernel module to create I2C client for a CPLD
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/jiffies.h>
|
|
#include <linux/i2c.h>
|
|
#include <linux/hwmon.h>
|
|
#include <linux/hwmon-sysfs.h>
|
|
#include <linux/err.h>
|
|
#include <linux/mutex.h>
|
|
#include <linux/sysfs.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/dmi.h>
|
|
#include <linux/kobject.h>
|
|
#include "pddf_client_defs.h"
|
|
#include "pddf_cpld_defs.h"
|
|
|
|
PDDF_CPLD_DATA pddf_cpld_data={0};
|
|
EXPORT_SYMBOL(pddf_cpld_data);
|
|
|
|
static ssize_t do_device_operation(struct device *dev, struct device_attribute *da, const char *buf, size_t count);
|
|
static ssize_t store_pddf_cpld_data(struct device *dev, struct device_attribute *da, const char *buf, size_t count);
|
|
static ssize_t show_pddf_cpld_data(struct device *dev, struct device_attribute *da, char *buf);
|
|
|
|
extern void *get_device_table(char *name);
|
|
extern void delete_device_table(char *name);
|
|
|
|
|
|
/* MUX CLIENT DATA */
|
|
PDDF_DATA_ATTR(dev_ops, S_IWUSR, NULL, do_device_operation, PDDF_CHAR, 8, NULL, (void*)&pddf_data);
|
|
PDDF_DATA_ATTR(reg_addr, S_IWUSR|S_IRUGO, show_pddf_cpld_data, store_pddf_cpld_data, PDDF_USHORT, sizeof(unsigned short), (void*)&pddf_cpld_data.reg_addr, NULL);
|
|
|
|
|
|
|
|
static struct attribute *cpld_attributes[] = {
|
|
&attr_dev_ops.dev_attr.attr,
|
|
&attr_reg_addr.dev_attr.attr,
|
|
NULL
|
|
};
|
|
|
|
static const struct attribute_group pddf_cpld_client_data_group = {
|
|
.attrs = cpld_attributes,
|
|
};
|
|
|
|
|
|
static ssize_t store_pddf_cpld_data(struct device *dev, struct device_attribute *da, const char *buf, size_t count)
|
|
{
|
|
int ret = 0;
|
|
int num = 0;
|
|
PDDF_ATTR *ptr = (PDDF_ATTR *)da;
|
|
|
|
ret = kstrtoint(buf,16,&num);
|
|
if (ret==0)
|
|
{
|
|
mutex_lock(&pddf_cpld_data.cpld_lock);
|
|
*(unsigned short *)(ptr->addr) = (unsigned short)num;
|
|
mutex_unlock(&pddf_cpld_data.cpld_lock);
|
|
pddf_dbg(CPLD, KERN_ERR "Stored value: 0x%x, num: 0x%x\n", *(int*)(ptr->addr), num);
|
|
}
|
|
|
|
return count;
|
|
}
|
|
|
|
static ssize_t show_pddf_cpld_data(struct device *dev, struct device_attribute *da, char *buf)
|
|
{
|
|
int ret = 0;
|
|
PDDF_ATTR *ptr = (PDDF_ATTR *)da;
|
|
pddf_dbg(CPLD, KERN_ERR "[ READ ] DATA ATTR PTR TYPE:%d, ADDR=%p\n", ptr->type, ptr->addr);
|
|
|
|
mutex_lock(&pddf_cpld_data.cpld_lock);
|
|
ret = sprintf(buf, "0x%x\n", *(unsigned short *)(ptr->addr));
|
|
mutex_unlock(&pddf_cpld_data.cpld_lock);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static ssize_t do_device_operation(struct device *dev, struct device_attribute *da, const char *buf, size_t count)
|
|
{
|
|
PDDF_ATTR *ptr = (PDDF_ATTR *)da;
|
|
NEW_DEV_ATTR *device_ptr = (NEW_DEV_ATTR *)(ptr->data);
|
|
struct i2c_adapter *adapter;
|
|
static struct i2c_board_info board_info;
|
|
struct i2c_client *client_ptr;
|
|
char *pddf_cpld_name = NULL;
|
|
|
|
if (strncmp(buf, "add", strlen(buf)-1)==0)
|
|
{
|
|
adapter = i2c_get_adapter(device_ptr->parent_bus);
|
|
|
|
if (strncmp(device_ptr->dev_type, "i2c_cpld", strlen("i2c_cpld"))==0)
|
|
{
|
|
pddf_cpld_name = (char *)kzalloc(CPLD_CLIENT_NAME_LEN, GFP_KERNEL);
|
|
if (pddf_cpld_name != NULL) strcpy(pddf_cpld_name, device_ptr->i2c_name);
|
|
|
|
board_info = (struct i2c_board_info) {
|
|
.platform_data = (void *)pddf_cpld_name,
|
|
};
|
|
|
|
board_info.addr = device_ptr->dev_addr;
|
|
strcpy(board_info.type, device_ptr->dev_type);
|
|
|
|
client_ptr = i2c_new_client_device(adapter, &board_info);
|
|
|
|
if (!IS_ERR(client_ptr)) {
|
|
i2c_put_adapter(adapter);
|
|
pddf_dbg(CPLD, KERN_ERR "Created %s client: 0x%p\n", device_ptr->i2c_name, (void *)client_ptr);
|
|
add_device_table(device_ptr->i2c_name, (void*)client_ptr);
|
|
}
|
|
else {
|
|
i2c_put_adapter(adapter);
|
|
goto free_data;
|
|
}
|
|
|
|
}
|
|
else
|
|
{
|
|
printk(KERN_ERR "%s: Unsupported type of cpld - unable to add i2c client\n", __FUNCTION__);
|
|
}
|
|
}
|
|
else if (strncmp(buf, "delete", strlen(buf)-1)==0)
|
|
{
|
|
/*Get the i2c_client handle for the created client*/
|
|
client_ptr = (struct i2c_client *)get_device_table(device_ptr->i2c_name);
|
|
if (client_ptr)
|
|
{
|
|
pddf_dbg(CPLD, KERN_ERR "Removing %s client: 0x%p\n", device_ptr->i2c_name, (void *)client_ptr);
|
|
i2c_unregister_device(client_ptr);
|
|
delete_device_table(device_ptr->i2c_name);
|
|
}
|
|
else
|
|
{
|
|
printk(KERN_ERR "Unable to get the client handle for %s\n", device_ptr->i2c_name);
|
|
}
|
|
}
|
|
else
|
|
{
|
|
printk(KERN_ERR "PDDF_ERROR: %s: Invalid value for dev_ops %s", __FUNCTION__, buf);
|
|
}
|
|
goto clear_data;
|
|
|
|
free_data:
|
|
if (board_info.platform_data)
|
|
kfree(board_info.platform_data);
|
|
clear_data:
|
|
/*TODO: free the device_ptr->data is dynamically allocated*/
|
|
memset(device_ptr, 0 , sizeof(NEW_DEV_ATTR));
|
|
|
|
return count;
|
|
}
|
|
|
|
|
|
static struct kobject *cpld_kobj;
|
|
|
|
int __init cpld_data_init(void)
|
|
{
|
|
struct kobject *device_kobj;
|
|
int ret = 0;
|
|
|
|
|
|
pddf_dbg(CPLD, "CPLD_DATA MODULE.. init\n");
|
|
|
|
device_kobj = get_device_i2c_kobj();
|
|
if(!device_kobj)
|
|
return -ENOMEM;
|
|
|
|
cpld_kobj = kobject_create_and_add("cpld", device_kobj);
|
|
if(!cpld_kobj)
|
|
return -ENOMEM;
|
|
|
|
|
|
ret = sysfs_create_group(cpld_kobj, &pddf_clients_data_group);
|
|
if (ret)
|
|
{
|
|
kobject_put(cpld_kobj);
|
|
return ret;
|
|
}
|
|
pddf_dbg(CPLD, "CREATED PDDF I2C CLIENTS CREATION SYSFS GROUP\n");
|
|
|
|
mutex_init(&pddf_cpld_data.cpld_lock);
|
|
|
|
ret = sysfs_create_group(cpld_kobj, &pddf_cpld_client_data_group);
|
|
if (ret)
|
|
{
|
|
sysfs_remove_group(cpld_kobj, &pddf_clients_data_group);
|
|
kobject_put(cpld_kobj);
|
|
return ret;
|
|
}
|
|
pddf_dbg(CPLD, "CREATED PDDF I2C CLIENTS CREATION SYSFS GROUP\n");
|
|
return ret;
|
|
}
|
|
|
|
void __exit cpld_data_exit(void)
|
|
{
|
|
pddf_dbg(CPLD, "CPLD_DATA MODULE.. exit\n");
|
|
sysfs_remove_group(cpld_kobj, &pddf_cpld_client_data_group);
|
|
sysfs_remove_group(cpld_kobj, &pddf_clients_data_group);
|
|
kobject_put(cpld_kobj);
|
|
pddf_dbg(CPLD, KERN_ERR "%s: Removed the kobjects for 'cpld'\n",__FUNCTION__);
|
|
return;
|
|
}
|
|
|
|
module_init(cpld_data_init);
|
|
module_exit(cpld_data_exit);
|
|
|
|
MODULE_AUTHOR("Broadcom");
|
|
MODULE_DESCRIPTION("cpld platform data");
|
|
MODULE_LICENSE("GPL");
|