3cd9b2e1b5
Signed-off-by: maipbui <maibui@microsoft.com> #### Why I did it `subprocess.Popen()` and `subprocess.run()` is used with `shell=True`, which is very dangerous for shell injection. `os` - not secure against maliciously constructed input and dangerous if used to evaluate dynamic content #### How I did it Replace `os` by `subprocess`, remove `shell=True` Remove unused functions
57 lines
1.6 KiB
Python
57 lines
1.6 KiB
Python
import subprocess
|
|
|
|
try:
|
|
from sonic_psu.psu_base import PsuBase
|
|
except ImportError as e:
|
|
raise ImportError(str(e) + "- required module not found")
|
|
|
|
|
|
class PsuUtil(PsuBase):
|
|
"""Platform-specific PSUutil class"""
|
|
|
|
def __init__(self):
|
|
PsuBase.__init__(self)
|
|
|
|
self.psu_path = "/sys/bus/i2c/devices/{}-0058/"
|
|
self.psu_oper_status = "in1_input"
|
|
self.psu_presence = ["i2cget", "-y", "", "0x50", "0x00"]
|
|
|
|
def get_num_psus(self):
|
|
"""
|
|
Retrieves the number of PSUs available on the device
|
|
|
|
:return: An integer, the number of PSUs available on the device
|
|
"""
|
|
return 2
|
|
|
|
def get_psu_status(self, index):
|
|
if index is None:
|
|
return False
|
|
Base_bus_number = 39
|
|
status = 0
|
|
# index from 1, psu attribute bus from 40
|
|
try:
|
|
with open(self.psu_path.format(index + Base_bus_number) + self.psu_oper_status, 'r') as power_status:
|
|
if int(power_status.read()) == 0:
|
|
return False
|
|
else:
|
|
status = 1
|
|
except IOError:
|
|
return True
|
|
return status == 1
|
|
|
|
def get_psu_presence(self, index):
|
|
if index is None:
|
|
return False
|
|
Base_bus_number = 39
|
|
status = 0
|
|
try:
|
|
self.psu_presence[2] = str(index + Base_bus_number)
|
|
p = subprocess.Popen(self.psu_presence)
|
|
if p.stdout.readline() is not None:
|
|
status = 1
|
|
p.close()
|
|
except IOError:
|
|
return False
|
|
return status == 1
|