sonic-buildimage/device/celestica/x86_64-cel_e1031-r0
Mai Bui 51a1eb112b
[device/celestica] Mitigation for command injection vulnerability (#11740)
Signed-off-by: maipbui <maibui@microsoft.com>
Dependency: [PR (#12065)](https://github.com/sonic-net/sonic-buildimage/pull/12065) needs to merge first.
#### Why I did it
1. `eval()` - not secure against maliciously constructed input, can be dangerous if used to evaluate dynamic content. This may be a code injection vulnerability.
2. `subprocess()` - when using with `shell=True` is dangerous. Using subprocess function without a static string can lead to command injection.
3. `os` - not secure against maliciously constructed input and dangerous if used to evaluate dynamic content.
4. `is` operator - string comparison should not be used with reference equality.
5. `globals()` - extremely dangerous because it may allow an attacker to execute arbitrary code on the system
#### How I did it
1. `eval()` - use `literal_eval()`
2. `subprocess()` - use `shell=False` instead. use an array string. Ref: [https://semgrep.dev/docs/cheat-sheets/python-command-injection/#mitigation](https://semgrep.dev/docs/cheat-sheets/python-command-injection/#mitigation)
3. `os` - use with `subprocess`
4. `is` - replace by `==` operator for value equality
5. `globals()` - avoid the use of globals()
2022-12-09 10:30:20 -05:00
..
Celestica-E1031-T48S4 Fix issue test_crm and test_fib (#10585) 2022-04-22 20:35:52 +08:00
plugins [device/celestica]: Fix failed test cases of Haliburton platform API (#7579) 2021-07-23 06:18:39 -07:00
sonic_platform [device/celestica] Mitigation for command injection vulnerability (#11740) 2022-12-09 10:30:20 -05:00
default_sku [updategraph] add support to use preset config instead of default minigraph (#2050) 2018-09-21 22:01:10 -07:00
fancontrol-B2F [device/celestica]: Add thermalctld support on Haliburton platform APIs (#6493) 2021-05-03 09:14:35 -07:00
fancontrol-F2B [device/celestica]: Add thermalctld support on Haliburton platform APIs (#6493) 2021-05-03 09:14:35 -07:00
installer.conf [device/celestica] haliburton add gpio_ich driver module blacklist (#2704) 2019-03-27 18:35:35 -07:00
pcie.yaml [pcie.yaml] Move pcie configuration file path to platform directory (#6475) 2021-02-21 08:27:37 -08:00
platform_asic Add platform_asic file to each platform folder in sonic-device-data based package (#8542) 2021-10-08 19:27:48 -07:00
platform_components.json [device/celestica]: Fix failed test cases of Haliburton platform API (#7579) 2021-07-23 06:18:39 -07:00
platform.json [device/celestica]: add controllable config to platform.json of e1031 (#9183) 2021-11-30 13:59:21 +08:00
pmon_daemon_control.json [device/celestica]: Fix xcvrd error (#3979) 2020-01-10 12:50:51 -08:00
sensors.conf [device/celestica]: Implement thermal base API based on the new platform API (#3220) 2019-08-05 09:01:50 -07:00
system_health_monitoring_config.json [healthd] Add system health configuration for platform Celestica E1031 (#8783) 2021-09-18 10:31:36 -07:00
thermal_overload_control.sh [device/celestica]: Add thermalctld support on Haliburton platform APIs (#6493) 2021-05-03 09:14:35 -07:00
thermal_policy.json [device/celestica]: Add thermalctld support on Haliburton platform APIs (#6493) 2021-05-03 09:14:35 -07:00