matthew/sonic-buildimage
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
c16b8dbcc5
sonic-buildimage/platform
History
Mai Bui 35c4e9912d
[ruijie] Replace os.system and remove subprocess with shell=True (#12107) 
Signed-off-by: maipbui <maibui@microsoft.com>
Dependency: [https://github.com/sonic-net/sonic-buildimage/pull/12065](https://github.com/sonic-net/sonic-buildimage/pull/12065)
#### Why I did it
1. `getstatusoutput` is used without a static string and it uses `shell=True`
2. `subprocess()` - when using with `shell=True` is dangerous. Using subprocess function without a static string can lead to command injection.
3. `os` - not secure against maliciously constructed input and dangerous if used to evaluate dynamic content.
#### How I did it
1. use `getstatusoutput` without shell=True
2. `subprocess()` - use `shell=False` instead. use an array string. Ref: [https://semgrep.dev/docs/cheat-sheets/python-command-injection/#mitigation](https://semgrep.dev/docs/cheat-sheets/python-command-injection/#mitigation)
3. `os` - use with `subprocess`
2022-11-28 12:43:43 -05:00
..
barefoot [Arista] Update platform library submodules (#12736) 2022-11-18 13:24:13 -08:00
broadcom [ruijie] Replace os.system and remove subprocess with shell=True (#12107) 2022-11-28 12:43:43 -05:00
cavium Parallel building of sonic dockers using native dockerd(dood). (#10352) 2022-04-28 08:39:37 +08:00
centec Update Linux kernel from 5.10.103 to 5.10.140 (#12660) 2022-11-14 16:33:34 -08:00
centec-arm64 Update Linux kernel from 5.10.103 to 5.10.140 (#12660) 2022-11-14 16:33:34 -08:00
checkout Platform/cisco-8000 module for sonic-buildimage (#8172) 2021-08-06 09:11:54 +08:00
components [gbsyncd] Enable debug shell for BRCM broncos PHY (#12622) 2022-11-08 17:58:25 -08:00
generic [dockers] Rename 'docker-snmp-sv2' to 'docker-snmp' (#4699) 2020-06-11 16:04:23 -07:00
innovium Revert "Support for serdes platform library debian installation for Innovium SONiC image (#11920)" (#12227) 2022-09-29 17:12:20 -07:00
marvell [bcm sai] upgrade Broadcom SAI to 7.1.0.0-5 (#11236) 2022-06-23 15:34:51 -07:00
marvell-arm64 Support symcrypt fips config for aboot/uboot (#10729) 2022-06-02 15:35:17 +08:00
marvell-armhf [Marvell] Move armhf syncd docker to bullseye. (#12585) 2022-11-17 22:17:37 +08:00
mellanox [Mellanox] Add SDK hash calculator debian and update SDK makefile to compile it (#12840) 2022-11-28 13:30:40 +02:00
nephos Parallel building of sonic dockers using native dockerd(dood). (#10352) 2022-04-28 08:39:37 +08:00
p4 Parallel building of sonic dockers using native dockerd(dood). (#10352) 2022-04-28 08:39:37 +08:00
pddf Adding support for get/set low power mode for QSFPs in PDDF common APIs (#11786) 2022-09-09 14:33:12 -07:00
template Mount directory warmboot in docker gbsyncd (#11852) 2022-08-26 22:00:45 +08:00
vs [SAI PTF] SAI PTF docker support sai-ptf v2 (#12719) 2022-11-17 04:42:51 -08:00