16e54340b7
**- Why I did it** Earlier today we found a bug in the SONiC TSA implementation. TSC shows incorrect output (see below) in case we have a route-map which contains TSA route-map as a prefix. ``` admin@str-s6100-acs-1:~$ TSC Traffic Shift Check: System Mode: Not consistent ``` The reason is that TSC implementation has too loose regexps in TSA utilities, which match wrong route-map entries: For example, current TSC matches following ``` route-map TO_BGP_PEER_V4 permit 200 route-map TO_BGP_PEER_V6 permit 200 ``` But it should match only ``` route-map TO_BGP_PEER_V4 permit 20 route-map TO_BGP_PEER_V4 deny 30 route-map TO_BGP_PEER_V6 permit 20 route-map TO_BGP_PEER_V6 deny 30 ``` **- How I did it** I fixed it by using egrep with `^` and `$` regexp markers which match begin and end of the line. **- How to verify it** 1. Add follwing entry to FRR config: ``` str-s6100-acs-1# str-s6100-acs-1# conf t str-s6100-acs-1(config)# route-map TO_BGP_PEER_V4 permit 200 str-s6100-acs-1(config-route-map)# end ``` 2. Use the TSC command and check output. It should show normal. ``` admin@str-s6100-acs-1:~$ TSC Traffic Shift Check: System Mode: Normal```
45 lines
1.2 KiB
Bash
Executable File
45 lines
1.2 KiB
Bash
Executable File
#!/bin/bash
|
|
|
|
function check_not_installed()
|
|
{
|
|
c=0
|
|
config=$(vtysh -c "show run")
|
|
for route_map_name in $(echo "$config" | sed -ne 's/ neighbor \S* route-map \(\S*\) out/\1/p');
|
|
do
|
|
echo "$config" | egrep -q "^route-map $route_map_name permit 20$"
|
|
c=$((c+$?))
|
|
echo "$config" | egrep -q "^route-map $route_map_name deny 30$"
|
|
c=$((c+$?))
|
|
done
|
|
return $c
|
|
}
|
|
|
|
check_not_installed
|
|
not_installed=$?
|
|
if [[ $not_installed -ne 0 ]];
|
|
then
|
|
TSA_FILE=$(mktemp)
|
|
for route_map_name in $(echo "$config" | sed -ne 's/ neighbor \S* route-map \(\S*\) out/\1/p');
|
|
do
|
|
case "$route_map_name" in
|
|
*V4*)
|
|
ip_version=V4
|
|
ip_protocol=ip
|
|
;;
|
|
*V6*)
|
|
ip_version=V6
|
|
ip_protocol=ipv6
|
|
;;
|
|
*)
|
|
continue
|
|
;;
|
|
esac
|
|
sonic-cfggen -d -a "{\"route_map_name\":\"$route_map_name\", \"ip_version\": \"$ip_version\", \"ip_protocol\": \"$ip_protocol\"}" -y /etc/sonic/constants.yml -t /usr/share/sonic/templates/bgpd/tsa/bgpd.tsa.isolate.conf.j2 > "$TSA_FILE"
|
|
vtysh -f "$TSA_FILE"
|
|
rm -f "$TSA_FILE"
|
|
done
|
|
echo "System Mode: Normal -> Maintenance"
|
|
else
|
|
echo "System is already in Maintenance mode"
|
|
fi
|