sonic-buildimage/platform/broadcom/sonic-platform-modules-inventec/common/utils
Mai Bui 92d25be08f
[inventec] Replace os.system and remove subprocess with shell=True (#12108)
Signed-off-by: maipbui <maibui@microsoft.com>
Dependency: [https://github.com/sonic-net/sonic-buildimage/pull/12065](https://github.com/sonic-net/sonic-buildimage/pull/12065)
#### Why I did it
1. `getstatusoutput` is used without a static string and it uses `shell=True`
2. `subprocess()` - when using with `shell=True` is dangerous. Using subprocess function without a static string can lead to command injection.
3. `os` - not secure against maliciously constructed input and dangerous if used to evaluate dynamic content.
#### How I did it
1. use `getstatusoutput` without shell=True
2. `subprocess()` - use `shell=False` instead. use an array string. Ref: [https://semgrep.dev/docs/cheat-sheets/python-command-injection/#mitigation](https://semgrep.dev/docs/cheat-sheets/python-command-injection/#mitigation)
3. `os` - use with `subprocess`
2022-10-14 10:21:44 -04:00
..
asic_monitor.py [inventec] Replace os.system and remove subprocess with shell=True (#12108) 2022-10-14 10:21:44 -04:00
led_proc.py [inventec] Replace os.system and remove subprocess with shell=True (#12108) 2022-10-14 10:21:44 -04:00
platform_status.py [inventec] Replace os.system and remove subprocess with shell=True (#12108) 2022-10-14 10:21:44 -04:00
transceiver_monitor.py [inventec] Replace os.system and remove subprocess with shell=True (#12108) 2022-10-14 10:21:44 -04:00