e286869b24
- Why I did it 1. Update Mellanox HW-MGMT package to newer version V.7.0030.1011 2. Replace the SONiC PMON Thermal control algorithm with the one inside the HW-MGMT package on all Nvidia platforms 3. Support Spectrum-4 systems - How I did it 1. Update the HW-MGMT package version number and submodule pointer 2. Remove the thermal control algorithm implementation from Mellanox platform API 3. Revise the patch to HW-MGMT package which will disable HW-MGMT from running on SIMX 4. Update the downstream kernel patch list Signed-off-by: Kebo Liu <kebol@nvidia.com>
245 lines
8.8 KiB
Diff
245 lines
8.8 KiB
Diff
From 793a81817df0dcee08aad3385a6971895437ab80 Mon Sep 17 00:00:00 2001
|
|
From: David Thompson <davthompson@nvidia.com>
|
|
Date: Fri, 26 Aug 2022 11:59:16 -0400
|
|
Subject: [PATCH backport 5.10 38/63] mlxbf_gige: compute MDIO period based on
|
|
i1clk
|
|
|
|
BugLink: https://launchpad.net/bugs/1989035
|
|
|
|
This patch adds logic to compute the MDIO period based on
|
|
the i1clk, and thereafter write the MDIO period into the YU
|
|
MDIO config register. The i1clk resource from the ACPI table
|
|
is used to provide addressing to YU bootrecord PLL registers.
|
|
The values in these registers are used to compute MDIO period.
|
|
If the i1clk resource is not present in the ACPI table, then
|
|
the current default hardcorded value of 430Mhz is used.
|
|
The i1clk clock value of 430MHz is only accurate for boards
|
|
with BF2 mid bin and main bin SoCs. The BF2 high bin SoCs
|
|
have i1clk = 500MHz, but can support a slower MDIO period.
|
|
|
|
Fixes: f92e1869d74e ("Add Mellanox BlueField Gigabit Ethernet driver")
|
|
Reviewed-by: Asmaa Mnebhi <asmaa@nvidia.com>
|
|
Signed-off-by: David Thompson <davthompson@nvidia.com>
|
|
Link: https://lore.kernel.org/r/20220826155916.12491-1-davthompson@nvidia.com
|
|
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
|
|
(cherry picked from commit 3a1a274e933fca73fdc960cb1f60636cd285a265)
|
|
Signed-off-by: Ike Panhc <ike.pan@canonical.com>
|
|
---
|
|
.../ethernet/mellanox/mlxbf_gige/mlxbf_gige.h | 4 +-
|
|
.../mellanox/mlxbf_gige/mlxbf_gige_mdio.c | 121 +++++++++++++++---
|
|
.../mellanox/mlxbf_gige/mlxbf_gige_regs.h | 2 +
|
|
3 files changed, 109 insertions(+), 18 deletions(-)
|
|
|
|
diff --git a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige.h b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige.h
|
|
index 5fdf9b717..5a1027b07 100644
|
|
--- a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige.h
|
|
+++ b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige.h
|
|
@@ -75,6 +75,7 @@ struct mlxbf_gige {
|
|
struct net_device *netdev;
|
|
struct platform_device *pdev;
|
|
void __iomem *mdio_io;
|
|
+ void __iomem *clk_io;
|
|
struct mii_bus *mdiobus;
|
|
spinlock_t lock; /* for packet processing indices */
|
|
u16 rx_q_entries;
|
|
@@ -137,7 +138,8 @@ enum mlxbf_gige_res {
|
|
MLXBF_GIGE_RES_MDIO9,
|
|
MLXBF_GIGE_RES_GPIO0,
|
|
MLXBF_GIGE_RES_LLU,
|
|
- MLXBF_GIGE_RES_PLU
|
|
+ MLXBF_GIGE_RES_PLU,
|
|
+ MLXBF_GIGE_RES_CLK
|
|
};
|
|
|
|
/* Version of register data returned by mlxbf_gige_get_regs() */
|
|
diff --git a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_mdio.c b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_mdio.c
|
|
index b7363c6c3..736849d07 100644
|
|
--- a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_mdio.c
|
|
+++ b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_mdio.c
|
|
@@ -22,10 +22,23 @@
|
|
#include <linux/property.h>
|
|
|
|
#include "mlxbf_gige.h"
|
|
+#include "mlxbf_gige_regs.h"
|
|
|
|
#define MLXBF_GIGE_MDIO_GW_OFFSET 0x0
|
|
#define MLXBF_GIGE_MDIO_CFG_OFFSET 0x4
|
|
|
|
+#define MLXBF_GIGE_MDIO_FREQ_REFERENCE 156250000ULL
|
|
+#define MLXBF_GIGE_MDIO_COREPLL_CONST 16384ULL
|
|
+#define MLXBF_GIGE_MDC_CLK_NS 400
|
|
+#define MLXBF_GIGE_MDIO_PLL_I1CLK_REG1 0x4
|
|
+#define MLXBF_GIGE_MDIO_PLL_I1CLK_REG2 0x8
|
|
+#define MLXBF_GIGE_MDIO_CORE_F_SHIFT 0
|
|
+#define MLXBF_GIGE_MDIO_CORE_F_MASK GENMASK(25, 0)
|
|
+#define MLXBF_GIGE_MDIO_CORE_R_SHIFT 26
|
|
+#define MLXBF_GIGE_MDIO_CORE_R_MASK GENMASK(31, 26)
|
|
+#define MLXBF_GIGE_MDIO_CORE_OD_SHIFT 0
|
|
+#define MLXBF_GIGE_MDIO_CORE_OD_MASK GENMASK(3, 0)
|
|
+
|
|
/* Support clause 22 */
|
|
#define MLXBF_GIGE_MDIO_CL22_ST1 0x1
|
|
#define MLXBF_GIGE_MDIO_CL22_WRITE 0x1
|
|
@@ -50,27 +63,76 @@
|
|
#define MLXBF_GIGE_MDIO_CFG_MDIO_IN_SAMP_MASK GENMASK(23, 16)
|
|
#define MLXBF_GIGE_MDIO_CFG_MDIO_OUT_SAMP_MASK GENMASK(31, 24)
|
|
|
|
+#define MLXBF_GIGE_MDIO_CFG_VAL (FIELD_PREP(MLXBF_GIGE_MDIO_CFG_MDIO_MODE_MASK, 1) | \
|
|
+ FIELD_PREP(MLXBF_GIGE_MDIO_CFG_MDIO3_3_MASK, 1) | \
|
|
+ FIELD_PREP(MLXBF_GIGE_MDIO_CFG_MDIO_FULL_DRIVE_MASK, 1) | \
|
|
+ FIELD_PREP(MLXBF_GIGE_MDIO_CFG_MDIO_IN_SAMP_MASK, 6) | \
|
|
+ FIELD_PREP(MLXBF_GIGE_MDIO_CFG_MDIO_OUT_SAMP_MASK, 13))
|
|
+
|
|
+#define MLXBF_GIGE_BF2_COREPLL_ADDR 0x02800c30
|
|
+#define MLXBF_GIGE_BF2_COREPLL_SIZE 0x0000000c
|
|
+
|
|
+static struct resource corepll_params[] = {
|
|
+ [MLXBF_GIGE_VERSION_BF2] = {
|
|
+ .start = MLXBF_GIGE_BF2_COREPLL_ADDR,
|
|
+ .end = MLXBF_GIGE_BF2_COREPLL_ADDR + MLXBF_GIGE_BF2_COREPLL_SIZE - 1,
|
|
+ .name = "COREPLL_RES"
|
|
+ },
|
|
+};
|
|
+
|
|
+/* Returns core clock i1clk in Hz */
|
|
+static u64 calculate_i1clk(struct mlxbf_gige *priv)
|
|
+{
|
|
+ u8 core_od, core_r;
|
|
+ u64 freq_output;
|
|
+ u32 reg1, reg2;
|
|
+ u32 core_f;
|
|
+
|
|
+ reg1 = readl(priv->clk_io + MLXBF_GIGE_MDIO_PLL_I1CLK_REG1);
|
|
+ reg2 = readl(priv->clk_io + MLXBF_GIGE_MDIO_PLL_I1CLK_REG2);
|
|
+
|
|
+ core_f = (reg1 & MLXBF_GIGE_MDIO_CORE_F_MASK) >>
|
|
+ MLXBF_GIGE_MDIO_CORE_F_SHIFT;
|
|
+ core_r = (reg1 & MLXBF_GIGE_MDIO_CORE_R_MASK) >>
|
|
+ MLXBF_GIGE_MDIO_CORE_R_SHIFT;
|
|
+ core_od = (reg2 & MLXBF_GIGE_MDIO_CORE_OD_MASK) >>
|
|
+ MLXBF_GIGE_MDIO_CORE_OD_SHIFT;
|
|
+
|
|
+ /* Compute PLL output frequency as follow:
|
|
+ *
|
|
+ * CORE_F / 16384
|
|
+ * freq_output = freq_reference * ----------------------------
|
|
+ * (CORE_R + 1) * (CORE_OD + 1)
|
|
+ */
|
|
+ freq_output = div_u64((MLXBF_GIGE_MDIO_FREQ_REFERENCE * core_f),
|
|
+ MLXBF_GIGE_MDIO_COREPLL_CONST);
|
|
+ freq_output = div_u64(freq_output, (core_r + 1) * (core_od + 1));
|
|
+
|
|
+ return freq_output;
|
|
+}
|
|
+
|
|
/* Formula for encoding the MDIO period. The encoded value is
|
|
* passed to the MDIO config register.
|
|
*
|
|
- * mdc_clk = 2*(val + 1)*i1clk
|
|
+ * mdc_clk = 2*(val + 1)*(core clock in sec)
|
|
*
|
|
- * 400 ns = 2*(val + 1)*(((1/430)*1000) ns)
|
|
+ * i1clk is in Hz:
|
|
+ * 400 ns = 2*(val + 1)*(1/i1clk)
|
|
*
|
|
- * val = (((400 * 430 / 1000) / 2) - 1)
|
|
+ * val = (((400/10^9) / (1/i1clk) / 2) - 1)
|
|
+ * val = (400/2 * i1clk)/10^9 - 1
|
|
*/
|
|
-#define MLXBF_GIGE_I1CLK_MHZ 430
|
|
-#define MLXBF_GIGE_MDC_CLK_NS 400
|
|
+static u8 mdio_period_map(struct mlxbf_gige *priv)
|
|
+{
|
|
+ u8 mdio_period;
|
|
+ u64 i1clk;
|
|
|
|
-#define MLXBF_GIGE_MDIO_PERIOD (((MLXBF_GIGE_MDC_CLK_NS * MLXBF_GIGE_I1CLK_MHZ / 1000) / 2) - 1)
|
|
+ i1clk = calculate_i1clk(priv);
|
|
|
|
-#define MLXBF_GIGE_MDIO_CFG_VAL (FIELD_PREP(MLXBF_GIGE_MDIO_CFG_MDIO_MODE_MASK, 1) | \
|
|
- FIELD_PREP(MLXBF_GIGE_MDIO_CFG_MDIO3_3_MASK, 1) | \
|
|
- FIELD_PREP(MLXBF_GIGE_MDIO_CFG_MDIO_FULL_DRIVE_MASK, 1) | \
|
|
- FIELD_PREP(MLXBF_GIGE_MDIO_CFG_MDC_PERIOD_MASK, \
|
|
- MLXBF_GIGE_MDIO_PERIOD) | \
|
|
- FIELD_PREP(MLXBF_GIGE_MDIO_CFG_MDIO_IN_SAMP_MASK, 6) | \
|
|
- FIELD_PREP(MLXBF_GIGE_MDIO_CFG_MDIO_OUT_SAMP_MASK, 13))
|
|
+ mdio_period = div_u64((MLXBF_GIGE_MDC_CLK_NS >> 1) * i1clk, 1000000000) - 1;
|
|
+
|
|
+ return mdio_period;
|
|
+}
|
|
|
|
static u32 mlxbf_gige_mdio_create_cmd(u16 data, int phy_add,
|
|
int phy_reg, u32 opcode)
|
|
@@ -127,9 +189,9 @@ static int mlxbf_gige_mdio_write(struct mii_bus *bus, int phy_add,
|
|
int phy_reg, u16 val)
|
|
{
|
|
struct mlxbf_gige *priv = bus->priv;
|
|
+ u32 temp;
|
|
u32 cmd;
|
|
int ret;
|
|
- u32 temp;
|
|
|
|
if (phy_reg & MII_ADDR_C45)
|
|
return -EOPNOTSUPP;
|
|
@@ -150,6 +212,18 @@ static int mlxbf_gige_mdio_write(struct mii_bus *bus, int phy_add,
|
|
return ret;
|
|
}
|
|
|
|
+static void mlxbf_gige_mdio_cfg(struct mlxbf_gige *priv)
|
|
+{
|
|
+ u8 mdio_period;
|
|
+ u32 val;
|
|
+
|
|
+ mdio_period = mdio_period_map(priv);
|
|
+
|
|
+ val = MLXBF_GIGE_MDIO_CFG_VAL;
|
|
+ val |= FIELD_PREP(MLXBF_GIGE_MDIO_CFG_MDC_PERIOD_MASK, mdio_period);
|
|
+ writel(val, priv->mdio_io + MLXBF_GIGE_MDIO_CFG_OFFSET);
|
|
+}
|
|
+
|
|
int mlxbf_gige_mdio_probe(struct platform_device *pdev, struct mlxbf_gige *priv)
|
|
{
|
|
struct device *dev = &pdev->dev;
|
|
@@ -164,9 +238,22 @@ int mlxbf_gige_mdio_probe(struct platform_device *pdev, struct mlxbf_gige *priv)
|
|
if (IS_ERR(priv->mdio_io))
|
|
return PTR_ERR(priv->mdio_io);
|
|
|
|
- /* Configure mdio parameters */
|
|
- writel(MLXBF_GIGE_MDIO_CFG_VAL,
|
|
- priv->mdio_io + MLXBF_GIGE_MDIO_CFG_OFFSET);
|
|
+ /* clk resource shared with other drivers so cannot use
|
|
+ * devm_platform_ioremap_resource
|
|
+ */
|
|
+ res = platform_get_resource(pdev, IORESOURCE_MEM, MLXBF_GIGE_RES_CLK);
|
|
+ if (!res) {
|
|
+ /* For backward compatibility with older ACPI tables, also keep
|
|
+ * CLK resource internal to the driver.
|
|
+ */
|
|
+ res = &corepll_params[MLXBF_GIGE_VERSION_BF2];
|
|
+ }
|
|
+
|
|
+ priv->clk_io = devm_ioremap(dev, res->start, resource_size(res));
|
|
+ if (IS_ERR(priv->clk_io))
|
|
+ return PTR_ERR(priv->clk_io);
|
|
+
|
|
+ mlxbf_gige_mdio_cfg(priv);
|
|
|
|
priv->mdiobus = devm_mdiobus_alloc(dev);
|
|
if (!priv->mdiobus) {
|
|
diff --git a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_regs.h b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_regs.h
|
|
index 5fb33c929..7be3a7939 100644
|
|
--- a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_regs.h
|
|
+++ b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_regs.h
|
|
@@ -8,6 +8,8 @@
|
|
#ifndef __MLXBF_GIGE_REGS_H__
|
|
#define __MLXBF_GIGE_REGS_H__
|
|
|
|
+#define MLXBF_GIGE_VERSION 0x0000
|
|
+#define MLXBF_GIGE_VERSION_BF2 0x0
|
|
#define MLXBF_GIGE_STATUS 0x0010
|
|
#define MLXBF_GIGE_STATUS_READY BIT(0)
|
|
#define MLXBF_GIGE_INT_STATUS 0x0028
|
|
--
|
|
2.20.1
|
|
|