This repository has been archived on 2025-03-20. You can view files and clone it, but cannot push or open issues or pull requests.
sonic-buildimage/dockers
novikauanton 1da8c145a6
[iccpd][docker] fix initial startup configuration (#7982)
#### Why I did it
The process of config generation (sonic-cfggen) fails, but the services continue to run with invalid config

#### How I did it
* add exit with error on errors in start.sh script (because supervisord relies on start.sh return code).
* fix jinja template. Jinja use common python expressions under the hood and `has_key` method was removed from dict in py3, so use check by `in` operator as it is supported by both py2 and py3.
#### How to verify it
* compile sonic with enabled iccp. 
* add mclag config to CONFIG_DB. 
    ``` 
    'MC_LAG|1' => {
        "local_ip": "10.0.0.2",
        "peer_ip": "10.0.0.3",
        "peer_link": "Ethernet8",
        "mclag_interface": "Ethernet12" 
    }
* unmaks, enable and start swss and iccpd services in sonic.
* log in into the iccpd container and check the config file `/etc/iccpd/iccpd.conf`
* expected config:
    ```
    mclag_id:1
        local_ip:10.0.0.2
        peer_ip:10.0.0.3
        peer_link:Ethernet8
        mclag_interface:Ethernet12
    system_mac:YOUR_SYSTEM_MAC

#### Description for the changelog
Fixed initial iccpd startup configuration.
2021-07-01 00:47:26 -07:00
..
docker-base [arm] support compile sonic arm image on arm server (#7285) 2021-04-18 08:17:57 -07:00
docker-base-buster [arm] support compile sonic arm image on arm server (#7285) 2021-04-18 08:17:57 -07:00
docker-base-stretch [arm] support compile sonic arm image on arm server (#7285) 2021-04-18 08:17:57 -07:00
docker-basic_router [supervisord]: use abspath as supervisord entrypoint (#5995) 2020-11-22 21:18:44 -08:00
docker-config-engine [docker-base-buster][docker-config-engine-buster] No longer install Python 2 (#6162) 2020-12-25 21:29:25 -08:00
docker-config-engine-buster [docker-base-buster][docker-config-engine-buster] No longer install Python 2 (#6162) 2020-12-25 21:29:25 -08:00
docker-config-engine-stretch [docker-base-buster][docker-config-engine-buster] No longer install Python 2 (#6162) 2020-12-25 21:29:25 -08:00
docker-database [Monit] Deprecate the feature of monitoring the critical processes by Monit (#7676) 2021-06-04 10:16:53 -07:00
docker-dhcp-relay dhcpmon: support dual tor in docker template (#7470) 2021-05-03 10:51:34 -07:00
docker-fpm-frr [multi-asic] fix network command for internal loopback (#7878) 2021-06-24 12:02:01 -07:00
docker-fpm-gobgp [dockers][supervisor] Increase event buffer size for process exit listener; Set all event buffer sizes to 1024 (#7083) 2021-03-27 21:14:24 -07:00
docker-iccpd [iccpd][docker] fix initial startup configuration (#7982) 2021-07-01 00:47:26 -07:00
docker-lldp [Monit] Deprecate the feature of monitoring the critical processes by Monit (#7676) 2021-06-04 10:16:53 -07:00
docker-macsec [dockers][supervisor] Increase event buffer size for process exit listener; Set all event buffer sizes to 1024 (#7083) 2021-03-27 21:14:24 -07:00
docker-nat [dockers][supervisor] Increase event buffer size for process exit listener; Set all event buffer sizes to 1024 (#7083) 2021-03-27 21:14:24 -07:00
docker-orchagent [fabric] Disable unnecessary processes in swss and the orchagent-portsyncd dependency for fabric asic (#5569) 2021-06-09 10:53:47 -07:00
docker-platform-monitor Add ethtool to docker-platform-monitor (#8017) 2021-06-30 09:36:47 -07:00
docker-ptf [arm] support compile sonic arm image on arm server (#7285) 2021-04-18 08:17:57 -07:00
docker-router-advertiser [radv] fix bug for radv can't startup if DEVICE_METADATA.localhost.type is NULL (#7651) 2021-05-25 08:17:44 -07:00
docker-sflow [Monit] Deprecate the feature of monitoring the critical processes by Monit (#7676) 2021-06-04 10:16:53 -07:00
docker-snmp [Monit] Deprecate the feature of monitoring the critical processes by Monit (#7676) 2021-06-04 10:16:53 -07:00
docker-sonic-mgmt [build]: Fix sonic-cfggen contextlib err (#7996) 2021-06-28 17:15:03 -07:00
docker-sonic-mgmt-framework [docker-mgmt-framework]: update mgmt framework docker to support sonic-cli cmd (#6148) 2021-06-02 19:38:21 -07:00
docker-sonic-restapi [Monit] Deprecate the feature of monitoring the critical processes by Monit (#7676) 2021-06-04 10:16:53 -07:00
docker-sonic-sdk [sonic-sdk] add sonic sdk and sonic sdk buildenv (#6712) 2021-05-28 10:16:02 -07:00
docker-sonic-sdk-buildenv [sonic-sdk] add sonic sdk and sonic sdk buildenv (#6712) 2021-05-28 10:16:02 -07:00
docker-sonic-telemetry [Monit] Deprecate the feature of monitoring the critical processes by Monit (#7676) 2021-06-04 10:16:53 -07:00
docker-teamd [Monit] Deprecate the feature of monitoring the critical processes by Monit (#7676) 2021-06-04 10:16:53 -07:00
dockerfile-macros.j2 [sonic-config-engine] Clean up dependencies, pin versions; install Python 3 package in Buster container (#5656) 2020-10-26 13:48:50 -07:00