Patch isc-dhcp-relay in order to allow the relay agent to discover configured interfaces even if they are down.
Without this patch, the relay agent will not discover configured interfaces if they are down when the relay agent starts up. If the interface(s) then get brought up after the relay started, the relay will discard packets received on these interfaces and log the message, Discarding packet received on <iface_name> interface that has no IPv4 address assigned. This led to race conditions when starting SONiC (or loading configuration). To resolve this, the relay agent would need to be restarted with all configured interfaces up.
With this patch, the relay agent will discover all configured interfaces, whether or not they are up at the time the relay agent starts. Thus, the state of the configured interfaces can be down when the relay agent starts and brought up during the lifetime of the relay agent process, and the relay agent will relay packets as expected; it will not discard them.
* Added debug symbol to dhcp-relay.
Note: Master is different; Hence explicitly for 201811 only.
* Include debug symbols of isc-dhcp in its debug docker.
Include isc-dhcp src in source archive.
This change is intended to fix the issue with dpkg-query during build
process.
The symptom is dpkg-query failed to open package info file, usually
/var/lib/dpkg/updates/000?
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Revert "Configure buffer profile to all ports (#3561)" (#3628)
Configure buffer profile to all ports (#3561)
This reverts commit 8861cbe98e.
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Submodule src/sonic-utilities 2ca1ae1..3ed25a4:
> Do not start pfcwd for M0 devices (#726)
> Make configlet application script idempotent for updates. (#728)
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
* BGPm for 201811 (#3601)
* Feature is downported
* Add monitors to the test minigraphs
* Test
* No pfx filer
* Fix bgp sample
* Quagga requires to activate peer-group before configuration
* Add bgpcfgd and bgpd.peer template
* Catch exception if rendering external template
* Fix tests
* Update minigraph.py to filter out front-panel ports that are not active
* Update cfggen tests to reflect new behavior
Signed-off-by: Danny Allen <daall@microsoft.com>
* Incorporate PR comments
- Update t0 tests to include additional device neighbors
- Refactor xml parsing logic
Submodule src/sonic-swss f09ddb4..49c9c16:
> Allow buffer profile apply after init (#1099)
> [aclorch]: Check for existing mirror table only when creating a new table (#1089)
> [201811] [portsorch] fix PortsOrch::allPortsReady() returns true when it should not (#1116)
> Address review comment: remove data member m_entriesCreated, which is introduced for dependancy resolution purpose. (#839)
> Fix PFC watchdog not getting lossless TC (#876)
Submodule src/sonic-utilities c049e54..2ca1ae1:
> Add a generic configlet application script (#716)
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
interfaces-config service configures lo address. If bgp service
starts before lo address is configured, then following config
in zebra will not be applied.
route-map RM_SET_SRC permit 10
set src 10.1.0.32
The adds a few seconds delay in bgp service start
Submodule src/sonic-swss 98cfe56..f09ddb4:
> [fix] Use the same storm detection condition for queue occupancy non-zero case as the zero case (#1111)
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
We noticed in tests/production that there is a low probability failure
where /etc/hosts could have some garbage characters before the entry for
local host name. The consequence is that all sudo command would be very
slow. In extreme cases it would prevent some services from starting
properly.
I suspect that the /etc/hosts file might be opened by some process causing
the issue. Editing contents with new file level and replace the whole file
should be safer.
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
- What I did
This fix removes the possibility of 'localhost' entry getting removed from /etc/hosts file by hostname-config service.
Without this change, whenever we change the hostname from 'localhost' to any other name on the config_db.json and reload the config, /etc/hosts file will only have the new hostname on it. But there are multiple sonic utilities (eg: swssconfig) which relies on the hard coded 'localhost' name and they tend to stop working.
- How I did it
Added a new check on hostname-config.sh script to avid blindly deleting the line containing the old hostname from /etc/hosts file. Now it will delete the old hostname only if its not localhost or when the hostname is not changing.
- How to verify it
Bring up SONiC on a device with hostname as localhost
Edit /etc/sonic/config_db.json to update the 'hostname' filed under DEVICE_METADATA from "hostname" : "localhost" --> "hostname" : "sonic"
run config reload -y to reflect the hostname change done on config_db.json file.
cat /etc/hosts and check whether both 127.0.0.1 localhost and 127.0.0.1 sonic entry are present on the file.
ping localhost should work fine.
- Description for the changelog
Make hostname-config service more robust in handling SONiC hostname change from localhost to anything else.
