Commit Graph

2245 Commits

Author SHA1 Message Date
Samuel Angebault
227bc32594 Install python3.6 smbus module in snmp (#2772) 2019-04-16 15:36:57 +00:00
pavel-shirshov
fde3a4f035 [sonic-cfggen]: Output differences for bgp configurations (#2768) 2019-04-16 15:36:21 +00:00
pavel-shirshov
144fe975e5 [docker-fpm-quagga]: Add support for PeerAsn and UpdateAddress (#2766) 2019-04-16 15:35:51 +00:00
Ying Xie
19813c2924 [bgp quagga] increase BGP graceful restart timeout to 240 seconds (#2754)
There are some platforms with less powerful CPU/hard-drive could take
longer to get ready for BGP. For these platforms, 240 seconds would be
a safer threshold.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
2019-04-16 15:35:09 +00:00
pavel-shirshov
f62d2b0df2 [vstest]: Test for quagga livelock fix (#2751)
* Test for quagga livelock fix

* Create /usr/local/etc for the test

* Add more debug info

* Install specific version of exabgp

* Update sonic-quagga
2019-04-16 15:34:38 +00:00
Mykola F
bed716edfe [Mellanox] Update SAI (#2778)
New SAI version is not going to flood our log with unnecessary log messages.

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
2019-04-14 10:59:26 -07:00
Ying Xie
97e996f87e [bcm SAI] upgrade Broadcom SAI to version 3.3.5.4-1 (#2764)
- Broadcom SAI GA drop 20190402

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
2019-04-10 19:12:29 -07:00
Ying Xie
9ae11035d7
[20181][sub-modules] advance sairedis, swss, swss-common and utilities (#2759)
Submodule src/sonic-sairedis 483c89e..97dd2a8:
  > Fix compilation issues in stretch docker with gcc-6.3 (#426)
  >  Make object list deterministic when iterating (#438)
  > Ignore ACL_COUNTER bytes and packets during comparison logic (#443)

Submodule src/sonic-swss d22b2de..ae74a27:
  > Survive pfc watchdog storm action across warm-reboot (#794)

Submodule src/sonic-swss-common 36fd5e9..24c0ff7:
  > Update PFC_WD table name in CONFIG_DB (#266)

Submodule src/sonic-utilities bae21e7..6aee909:
  > [neighbor advertiser] convert int to string before concatenating (#505)
  > [config]: Change the order of interface commands (#504)
  > Change PFC watchdog CONFIG_DB table name from PFC_WD_TABLE to PFC_WD (#475)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
2019-04-09 14:20:35 -07:00
Renuka Manavalan
6c1a0ce58c [hostcfgd] -- Fix the default for failthrough as false.
This implies that by default, if TACACS is configured properly and it reported auth_err, then don't try fail through to traditional unix authentication through /etc/passwd.

If this failthrough is intended, make it explicit through "sudo config aaa authentication failthrough enable"

Removed an unused variable "aaa.fallback"

Tested manually. Note the presence of 'auth_err=die' in all cases except when failthrough is explicitly enabled.

admin@str-s6000-acs-13:~$ sudo config aaa authentication failthrough default; date
Wed Apr  3 23:05:18 UTC 2019
admin@str-s6000-acs-13:~$ ls -lrt /etc/pam.d/common-auth-sonic ; grep 123 /etc/pam.d/common-auth-sonic
-rw-r--r-- 1 root root 1316 Apr  3 23:05 /etc/pam.d/common-auth-sonic
auth    [success=done new_authtok_reqd=done default=ignore auth_err=die]        pam_tacplus.so server=100.127.20.22:49 secret=testing123 login=login timeout=5 try_first_pass
auth    [success=done new_authtok_reqd=done default=ignore auth_err=die]        pam_tacplus.so server=100.127.20.21:49 secret=testing123 login=login timeout=5 try_first_pass

admin@str-s6000-acs-13:~$ sudo config aaa authentication failthrough enable; date ; h4 "AAA|authentication"
Wed Apr  3 23:06:37 UTC 2019
admin@str-s6000-acs-13:~$ ls -lrt /etc/pam.d/common-auth-sonic ; grep 123 /etc/pam.d/common-auth-sonic
-rw-r--r-- 1 root root 1294 Apr  3 23:06 /etc/pam.d/common-auth-sonic
auth    [success=done new_authtok_reqd=done default=ignore]     pam_tacplus.so server=100.127.20.22:49 secret=testing123 login=login timeout=5 try_first_pass
auth    [success=done new_authtok_reqd=done default=ignore]     pam_tacplus.so server=100.127.20.21:49 secret=testing123 login=login timeout=5 try_first_pass

admin@str-s6000-acs-13:~$ sudo config aaa authentication failthrough disable; date ; h4 "AAA|authentication"
Wed Apr  3 23:07:09 UTC 2019
admin@str-s6000-acs-13:~$ ls -lrt /etc/pam.d/common-auth-sonic ; grep 123 /etc/pam.d/common-auth-sonic
-rw-r--r-- 1 root root 1321 Apr  3 23:07 /etc/pam.d/common-auth-sonic
auth    [success=done new_authtok_reqd=done default=ignore auth_err=die]        pam_tacplus.so server=100.127.20.22:49 secret=testing123 login=login timeout=5 try_first_pass
auth    [success=done new_authtok_reqd=done default=ignore auth_err=die]        pam_tacplus.so server=100.127.20.21:49 secret=testing123 login=login timeout=5 try_first_pass
2019-04-08 23:41:51 +00:00
Ying Xie
5c663ca7bb
[201811][utilities] advance submodule head (#2748)
Submodule src/sonic-utilities d1070b2..bae21e7:
  > Update neighbor advertiser (#498)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
2019-04-04 08:34:44 -07:00
Ying Xie
4eaa4dabff Revert "[teamd service] teamd service should start after syncd (#2724)" (#2733)
This reverts commit 0d1efb131c.
2019-04-04 15:22:44 +00:00
paavaanan
27f1aa7e09 removing dhcp- turn- off option from initrd (#2555)
* removing dhcp changes from initrd

* removing mgmt-intf-dhcp file
2019-04-04 15:22:14 +00:00
Ying Xie
1a4bac7e27
[201811][platform-common] add platform-common 201811 branch (#2743)
- Cherry-picked one change:

Submodule src/sonic-platform-common d4bf78c..42119e1:
  > remove gang port parsing (#24)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
2019-04-04 08:12:54 -07:00
Ying Xie
502ddb0978
[201811][sairedis][swss] advance sub module head of sairedis and swss (#2728)
Submodule src/sonic-sairedis 8182916..483c89e:
  > Notify OA about exception and process only restart query events (#437)

Submodule src/sonic-swss 91171b6..d22b2de:
  > Allow ACL entry creation without ACL counter (#818)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
2019-04-01 16:58:39 -07:00
Ying Xie
bc98f9fe64 [teamd] prevent re-entrance of port priv change handler (#2723)
When adding a lag member dynamically after system boots up, teamd
port priv change handler could re-entrant itself and causing adding
operation to fail.

While handling PORT_CHANGE event, teamd_per_port.c port priv change
handler was called, it will then call runner_lacp to add port to lag,
the later causes IFINFO_CHANGE to be notified and calls the priv change
handler again, this re-entrance would cause runner_lacp port_added to
be called again and messes up with the previous adding sequence. Then
fails the lag member adding operation.

Prevent per port priv change handler re-entrance solves the problem.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
2019-04-01 23:52:31 +00:00
Ying Xie
13a643bb3e [teamd service] teamd service should start after syncd (#2724)
* [teamd service] teamd service should start after syncd

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* combine after lines
2019-04-01 22:47:47 +00:00
Ying Xie
021b3788d5 [build] force Linux to drop cache before calling kvm (#2717)
* [vm build] force Linux to drop cache before calling kvm

KVM need to allocate 2G memory for this build. The system memory might
be occupied by cache at the moment and doesn't have 2G chunk to give
out. Forcing Kernel to drop cache to boost the chance of getting 2G
memory.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* [make] add option to enable/disable VS build memory preparation

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
2019-04-01 22:47:23 +00:00
Ying Xie
681e34a2b1
[service] add warmboot finializer service (#2725)
After warm reboot is done, we need to disable warm reboot flag and
tear down anything setup for warm reboot and persisted across.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
2019-04-01 14:16:31 -07:00
Ying Xie
1b07437205
[201811][snmpagent][swss-common] advance sub module head to include overlay SNMP (#2721)
* [snmpagent][swss-common] advance sub module head to include overlay SNMP

Submodule src/sonic-snmpagent 0f2bbd7..26f0495:
  > Remove verbose feature missing logs (#102)
  > Enable overriding interface counters OIDs (#98)

Submodule src/sonic-swss-common 5f4abd9..36fd5e9:
  > Add new DB index for SNMP_OVERLAY_DB (#262)

Note: overlay DB also requires change in swss-common, which has been
      moved ahead.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* [utilities] advance utilities sub-module head

Submodule src/sonic-utilities 9d9aaa0..d1070b2:
  > [warm-reboot] initialize warm reboot state table before warm rebooting (#492)
  > Allow config shutdown and startup operations on valid PortChannel interface names (#474)
2019-03-30 17:18:57 -07:00
Qi Luo
3d8d4aeef0 [security] Do not generate ssh server keys for non RSA protocols (#2718) 2019-03-29 22:37:47 +00:00
Andriy Moroz
e985372108 [devices]: Add support of HwSKU Mellanox-SN2700-C28D8 (#2700)
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
2019-03-28 17:26:43 +00:00
Ying Xie
378fa08da6 [teamd] retry creating team_port after interface info changed (#2699)
Race condition has been noticed after warm reboot: sometimes when
port_changed notification was received, the link message didn't
have the device name. Without device name, creating team port
would fail.

Registering to the interface information change notification, so
later when device name becomes available, retry creating team port.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
2019-03-28 17:26:43 +00:00
Jipan Yang
dc2317a697 [libteam]: Skip setting the same hwaddr to lag port to avoid disrupting neighbor… (#2602)
* Skip setting the same hwaddr to lag port to avoid disrupting neighbor entries

Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
2019-03-28 17:25:58 +00:00
Ying Xie
5043e229eb [jessie based docker] remove dependency on some retired jessie repos (#2707)
* [jessie repo] remove one dependency on jessie-backport repo

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* [build] remove dependency on retried jessie-backports repo

The downloaded Jessie docker image still reference jessie-updates.
Removing it from the list.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* fix typo

* move chunk

* [docker-ptf] avoid using retired Jessie repos

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
2019-03-27 06:48:39 +00:00
Ying Xie
14e3c60ae4
[201811 sub module] advance utilitie sub module (#2695)
Submodule src/sonic-utilities 2fe01fe..9d9aaa0:
  > [warm/fast reboot] setup control plane assistant when available (#487)
  > [reboot script] add -h, -? options (#484)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
2019-03-22 13:58:53 -07:00
Ying Xie
00081c5f61 [make file] managing teamd patches with stg (#2689)
Just so that the folder will be clean and make working on new patches
much easier.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
2019-03-22 15:53:58 +00:00
Ying Xie
f29e6230e5 [docker script] skip docker mount point checking for database container (#2683)
database container doesn't mount hwsku folder.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
2019-03-22 15:53:41 +00:00
Kebo Liu
ed8e29cb6f [Mellanox] fix sfp lpmode set failure caused by extra nv port (#2671)
* fix lpmode set failure issue by skipping nvport
2019-03-22 15:53:04 +00:00
Ying Xie
d80ea02782 [sonic-py-swsssdk] Update submodule (#2660) 2019-03-22 15:52:34 +00:00
Andriy Moroz
21ea29a23f [Mellanox] Update SAI (#2686)
New SAI fixes getting of queue buffer profile

Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
2019-03-21 10:42:13 -07:00
Ying Xie
4c61c0e958
[201811 sub-module] advance sub-modules: utilities, swss, swss-common (#2679)
Submodule src/sonic-utilities f95da07..2fe01fe:
  > neighbor advertiser script (#469)
  > [aclshow] restore PRIO column and sort entries by priority (#476)
  > Update watermark default polling interval to 10s (#470)
  > show interface status <interface-name> throws error (fixes #427) (#440)

Submodule src/sonic-swss 90eb25d..91171b6:
  > fix a unstable swss egress acl test (#776)
  > [aclorch] Remove  L4 port range support limitation on egress ACL table and add new SWSS virtual test. (#741)
  > Fix orchagent SEGV when PortConfigDone not set (#803)

Submodule src/sonic-swss-common 2592b0c..5f4abd9:
  > Force only supported commands on consumer table (#261)
  > Add multiple fields hdel support (#267)


Signed-off-by: Ying Xie <ying.xie@microsoft.com>
2019-03-19 08:44:33 -07:00
Ying Xie
bbfe094ecb [docker] Update docker package version for CVE-2019-5736 fix (#2663) 2019-03-19 03:10:56 +00:00
Stepan Blyshchak
ba5accda32 [mellanox] Fix in mlnx-ffb.sh (#2676)
Fixes "No ISSU version file found /etc/mlnx/issu-version"
when rebooting to different image;
Add aditional check condition.

Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
2019-03-19 03:06:34 +00:00
Joe LeVeque
ecec579933 [services] Services which start containers now use 'docker wait' instead of 'docker attach' (#2661) 2019-03-19 03:05:37 +00:00
Qi Luo
638724f49f Update bcmcmd binary: fix crash issue when long line >= 1023 chars (#2659)
Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
2019-03-19 03:05:10 +00:00
Wenda Ni
f720c2a9a3 [qos]: Map tc 1, 2, 5, and 6 back to pg 0 (#2650)
Lossy traffic does not need to be mapped to different ingress PGs. They can all share the same ingress PG.

Signed-off-by: Wenda Ni <wenni@microsoft.com>
2019-03-19 03:04:46 +00:00
Nadiia Stetskovych
4998609c2f [minigraph]: Do not fail for minigraphs which do not have neighbors listed in <Devices> section (#2522)
Signed-off-by: Nadiya.Stetskovych <nstetskovych@barefootnetworks.com>
2019-03-19 03:02:33 +00:00
Mykola F
1ddf4b75c9 revert 'Remove MAC alignment WA for Mellanox platforms.' (#2677)
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
2019-03-18 08:52:31 -07:00
Ying Xie
6341b87d1b
[sub module] remove changes not ready yet (#2662)
PFC_WD table naming change is not ready to be included yet.

Submodule src/sonic-swss-common c674e64..2592b0c (rewind):
  < Add multiple fields hdel support (#267)
  < Update PFC_WD table name in CONFIG_DB (#266)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
2019-03-08 22:30:30 -08:00
Ying Xie
23aa759d7a
[201811 sub module] advance sairedis sub module (#2657)
Submodule src/sonic-sairedis 54b02a1..8182916:
  > Add pre match to comparison logic and unittests (#423)
  > Drop FDB notifications if they contain invalid OIDs (#428)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
2019-03-07 11:07:59 -08:00
Nazarii Hnydyn
8a602c67f9 [mellanox]: Remove MAC alignment WA for Mellanox platforms. (#2632)
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
2019-03-07 17:40:40 +00:00
Ying Xie
898a5ac609
[201811 sub module] update swss, swss-common sub modules (#2652)
Submodule src/sonic-swss 4b489ce..90eb25d:
  > [portsorch] fix bug in speed set (#806)

Submodule src/sonic-swss-common 2592b0c..c674e64:
  > Add multiple fields hdel support (#267)
  > Update PFC_WD table name in CONFIG_DB (#266)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
2019-03-07 08:54:53 -08:00
Ying Xie
4f3a5e863d [devices]: sfputil support more mellanox sku (#2645) 2019-03-07 03:34:18 +00:00
Wenda Ni
0b13c45774 Add hook to allow customizing link cable lengths
Signed-off-by: Wenda Ni <wenni@microsoft.com>
2019-03-07 03:32:56 +00:00
Ying Xie
deab95cff6 [swss/syncd] cold start syncd service in swss in attach method (#2639)
start() is called by service startPre method, which is blocking. Starting
syncd service here is causing deadlock.

attach() is called by service start method, which is non-blocking.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
2019-03-07 03:30:34 +00:00
Joe LeVeque
e5b8302fee Set a rate limit on syslog messages from all Docker containers (#2573)
Rate limiting at 20,000 messages per 5-minute interval
2019-03-07 03:29:41 +00:00
Joe LeVeque
daf45c5179 [supervisor] Fix crash if system clock rolls back within startsecs; Refactor patch (#2624) 2019-03-07 03:28:56 +00:00
Ying Xie
ece0050acf [router-advertiser] Add templated script to wait for pertinent interfaces to be ready before starting radvd (#2558) 2019-03-07 03:26:41 +00:00
Joe LeVeque
c6ccb80803 [services] Ensure swss and syncd services start before dependent services (#2634)
* [services] Ensure swss and syncd services start before dependent services

* Add 'attach' functions to scripts which get installed to /usr/local/bin so that services only reference the one script each

* Add 'After=swss.service' to syncd.service
2019-03-07 03:23:13 +00:00
Andriy Moroz
83c645d69f [Mellanox] Fix SAI version (#2628)
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
2019-03-01 10:27:17 -08:00