When adding a lag member dynamically after system boots up, teamd
port priv change handler could re-entrant itself and causing adding
operation to fail.
While handling PORT_CHANGE event, teamd_per_port.c port priv change
handler was called, it will then call runner_lacp to add port to lag,
the later causes IFINFO_CHANGE to be notified and calls the priv change
handler again, this re-entrance would cause runner_lacp port_added to
be called again and messes up with the previous adding sequence. Then
fails the lag member adding operation.
Prevent per port priv change handler re-entrance solves the problem.
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
* [vm build] force Linux to drop cache before calling kvm
KVM need to allocate 2G memory for this build. The system memory might
be occupied by cache at the moment and doesn't have 2G chunk to give
out. Forcing Kernel to drop cache to boost the chance of getting 2G
memory.
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
* [make] add option to enable/disable VS build memory preparation
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
After warm reboot is done, we need to disable warm reboot flag and
tear down anything setup for warm reboot and persisted across.
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
* [snmpagent][swss-common] advance sub module head to include overlay SNMP
Submodule src/sonic-snmpagent 0f2bbd7..26f0495:
> Remove verbose feature missing logs (#102)
> Enable overriding interface counters OIDs (#98)
Submodule src/sonic-swss-common 5f4abd9..36fd5e9:
> Add new DB index for SNMP_OVERLAY_DB (#262)
Note: overlay DB also requires change in swss-common, which has been
moved ahead.
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
* [utilities] advance utilities sub-module head
Submodule src/sonic-utilities 9d9aaa0..d1070b2:
> [warm-reboot] initialize warm reboot state table before warm rebooting (#492)
> Allow config shutdown and startup operations on valid PortChannel interface names (#474)
Race condition has been noticed after warm reboot: sometimes when
port_changed notification was received, the link message didn't
have the device name. Without device name, creating team port
would fail.
Registering to the interface information change notification, so
later when device name becomes available, retry creating team port.
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Submodule src/sonic-utilities f95da07..2fe01fe:
> neighbor advertiser script (#469)
> [aclshow] restore PRIO column and sort entries by priority (#476)
> Update watermark default polling interval to 10s (#470)
> show interface status <interface-name> throws error (fixes#427) (#440)
Submodule src/sonic-swss 90eb25d..91171b6:
> fix a unstable swss egress acl test (#776)
> [aclorch] Remove L4 port range support limitation on egress ACL table and add new SWSS virtual test. (#741)
> Fix orchagent SEGV when PortConfigDone not set (#803)
Submodule src/sonic-swss-common 2592b0c..5f4abd9:
> Force only supported commands on consumer table (#261)
> Add multiple fields hdel support (#267)
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Fixes "No ISSU version file found /etc/mlnx/issu-version"
when rebooting to different image;
Add aditional check condition.
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
Lossy traffic does not need to be mapped to different ingress PGs. They can all share the same ingress PG.
Signed-off-by: Wenda Ni <wenni@microsoft.com>
PFC_WD table naming change is not ready to be included yet.
Submodule src/sonic-swss-common c674e64..2592b0c (rewind):
< Add multiple fields hdel support (#267)
< Update PFC_WD table name in CONFIG_DB (#266)
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Submodule src/sonic-sairedis 54b02a1..8182916:
> Add pre match to comparison logic and unittests (#423)
> Drop FDB notifications if they contain invalid OIDs (#428)
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
start() is called by service startPre method, which is blocking. Starting
syncd service here is causing deadlock.
attach() is called by service start method, which is non-blocking.
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
* [services] Ensure swss and syncd services start before dependent services
* Add 'attach' functions to scripts which get installed to /usr/local/bin so that services only reference the one script each
* Add 'After=swss.service' to syncd.service
need to flush asic db in swss.sh instead of syncd.sh
orchagent might already started in swss.sh and put commands
into asic db before asic db is flushed in syncd.sh. This
causes race condition such as INIT_VIEW not passing to syncd.
Signed-off-by: Guohan Lu <gulv@microsoft.com>
* Add a log message for each notification of add/del TACACS server.
Signed-off-by: Renuka Manavalan <remanava@microsoft.com>
* Moved another syslog message from DEBUG to INFO to be able to see those notifications.
All these changes are to help with a one-time-seen-bug, that hostcfgd did not act upon changes to redis for TACACS servers. We could not repro the bug.
Signed-off-by: Renuka Manavalan <remanava@microsoft.com>
