Commit Graph

15 Commits

Author SHA1 Message Date
shlomibitton
97f2cafe0b [LLDP] Fix for LLDP advertisements being sent with wrong information. (#5493)
* Fix for LLDP advertisments being sent with wrong information.
Since lldpd is starting before lldpmgr, some advertisment packets might sent with default value, mac address as Port ID.
This fix hold the packets from being sent by the lldpd until all interfaces are well configured by the lldpmgrd.

Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>

* Fix comments

* Fix unit-test output caused a failure during build

* Add 'run_cmd' function and use it

* Resume lldpd even if port init timeout reached
2020-10-30 09:06:23 -07:00
Joe LeVeque
c3117bc35e [lldpmgrd] Inherit DaemonBase class from sonic-py-common package (#5370)
Eliminate duplicate logging and signal handling code by inheriting from DaemonBase class in sonic-py-common package.
2020-09-19 13:59:01 -07:00
zhenggen-xu
80e388d6a0 [docker-lldp] Fix lldpcli issue when description has special characters (#4133)
Before the fix:
lldpcli configure ports Ethernet96 lldp portidsubtype local 'Eth1/1' description 50G|sonic1|Eth1/3/2
bash: sonic1: command not found
bash: Eth1/3/2: No such file or directory

After fix:
lldpcli configure ports Ethernet96 lldp portidsubtype local 'Eth1/1' description '50G|sonic1|Eth1/3/2'
run successfully.

Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
2020-02-13 16:06:11 -08:00
Dong Zhang
a2656416fe [MultiDB] (./dockers dir) : replace redis-cli with sonic-db-cli and use new DBConnector (#3923)
* [MultiDB] (./dockers dirs): replace redis-cli with sonic-db-cli and use new DBConnector

* remove unnecessary quota

* update typo
2020-02-03 15:33:30 -08:00
Joe LeVeque
bbbd3db5d7
[lldpmgrd] Initialize port_desc to None to prevent crashing (#3451) 2019-09-12 15:21:53 -07:00
Sumukha Tumkur Vani
6e37e23006
Reverting permission changes on lldpmgrd (#3184)
The permissions got changed inadverently in this PR: https://github.com/Azure/sonic-buildimage/pull/3152
2019-07-18 14:30:43 -07:00
Sumukha Tumkur Vani
ac9934a83d
Fix for LLDP portname exposed as MAC address bug (#3152)
* Subscribe to both ConfigDB and AppDB
to get notifications to apply LLDP port config

* the operstate file is not consistent
Removing this since it is not serving any purpose

* Remove check for PortInitDone and PortConfigDone
This is not prteset in Config DB

* Remove checking State DB for port creation

* Check for key to be present before fetching it

* Addressing review comments
2019-07-17 16:04:01 -07:00
Sumukha Tumkur Vani
3a8ce5f388
Fix for LLDP portname issue (#2886)
* Fix for LLDP portname issue
First check for operstate and if its not present then check for ifindex

* Addressing review comments
2019-05-10 14:28:24 -07:00
Guohan Lu
c46852a087 configure lldp when the port exists
On some platform, portstate might be unknown as it might not
be supported by the driver.

Signed-off-by: Guohan Lu <gulv@microsoft.com>
2019-02-12 09:48:05 +00:00
Mykola F
52c533fe01 [lldpmgr] add mgmt ip to lldpd conf template, handle port description/alias changes (#2396)
* [lldpmgr] add mgmt ip to lldpd conf templte, handle port description/alias config

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>

* fix typo

* [config-engine] update test sample output lldpd.conf

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>

* fix the log message

* fix lldpd.conf.j2
2019-01-30 11:05:36 +02:00
pavel-shirshov
18e97fba2c [docker-lldpd]: Various fixes (#1650)
* We don't need configure anything until we have interfaces created

* Don't run lldpcli for a port, until a port is up and running

* Remove lldpd socket before starting lldpd

* Fix sample files for lldpd configuration

* Another attempt to make the test working

* Quick fix for lldpd paused after start bug
2018-04-26 19:01:33 -07:00
pavel-shirshov
8a714c88c7
Use refactored Selectables from sonic-swss-common (#1604) 2018-04-16 18:38:48 -07:00
Joe LeVeque
291321d851 Incorporate swss-common Table Name Separator Changes (#1584)
* Table name separator now determined by database ID, no longer passed manually upon table creation

* Update submodules to include table name separator changes
2018-04-11 01:50:17 -07:00
Joe LeVeque
c161de406a
[lldpmgrd] Fix potential race condition when interfaces are created (#1469) 2018-03-07 17:08:45 -08:00
Joe LeVeque
c689253b3f
[LLDP] Add lldpmgrd Daemon to Manage LLDP Configuration (#1428) 2018-03-02 16:46:22 -08:00