From ff7c9930609c51e1dc20683d30e55dbde5a93279 Mon Sep 17 00:00:00 2001 From: Mai Bui Date: Tue, 23 Jan 2024 14:02:54 -0500 Subject: [PATCH] [docker-p4rt limit privileged flag for p4rt container (#17796) ### Why I did it HLD implementation: Container Hardening (https://github.com/sonic-net/SONiC/pull/1364) ##### Work item tracking - Microsoft ADO **(number only)**: 14807420 #### How I did it Reduce linux capabilities in privileged flag #### How to verify it Check container's settings: Privileged is false and container only has default Linux caps, does not have extended caps. ``` admin@vlab-01:~$ docker inspect p4rt | grep Privi "Privileged": false, admin@vlab-01:~$ docker exec -it p4rt bash root@vlab-01:/# capsh --print Current: cap_chown,cap_dac_override,cap_fowner,cap_fsetid,cap_kill,cap_setgid,cap_setuid,cap_setpcap,cap_net_bind_service,cap_net_raw,cap_sys_chroot,cap_mknod,cap_audit_write,cap_setfcap=ep ``` --- rules/docker-p4rt.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules/docker-p4rt.mk b/rules/docker-p4rt.mk index d34447b0ee..bc8d6b9fbe 100644 --- a/rules/docker-p4rt.mk +++ b/rules/docker-p4rt.mk @@ -31,7 +31,7 @@ SONIC_INSTALL_DOCKER_IMAGES += $(DOCKER_P4RT) endif $(DOCKER_P4RT)_CONTAINER_NAME = p4rt -$(DOCKER_P4RT)_RUN_OPT += --privileged -t +$(DOCKER_P4RT)_RUN_OPT += -t $(DOCKER_P4RT)_RUN_OPT += -v /etc/sonic:/etc/sonic:ro $(DOCKER_P4RT)_RUN_OPT += -v /etc/timezone:/etc/timezone:ro $(DOCKER_P4RT)_GIT_COMMIT = $(shell cd "$($(SONIC_P4RT)_SRC_PATH)" && git log -n 1 --format=format:"%H %s" || echo "Unable to fetch git log for p4rt")