Fix Allow prefix Delete case (#6671)
When we add allow-list key with action above route-map gets updated . For eg if we add deny action above template will become to no-export community. Now if we delete the key Issue is we still keep the no-export and do not move back to drop community. This PR fixes this issue by rolling back default route-map community value back to constants.yml default action.
This commit is contained in:
abdosi
Abhishek Dosi
parent
9c9f0453f9
commit
fede95da19
@ -173,6 +173,7 @@ class BGPAllowListMgr(Manager):
|
|||||||
msg += " deployment_id '%s'. community: '%s'"
|
msg += " deployment_id '%s'. community: '%s'"
|
||||||
log_info(msg % info)
|
log_info(msg % info)
|
||||||
|
|
||||||
|
default_action = self.__get_default_action_community()
|
||||||
names = self.__generate_names(deployment_id, community_value)
|
names = self.__generate_names(deployment_id, community_value)
|
||||||
self.cfg_mgr.update()
|
self.cfg_mgr.update()
|
||||||
cmds = []
|
cmds = []
|
||||||
@ -181,6 +182,8 @@ class BGPAllowListMgr(Manager):
|
|||||||
cmds += self.__remove_prefix_list(self.V4, names['pl_v4'])
|
cmds += self.__remove_prefix_list(self.V4, names['pl_v4'])
|
||||||
cmds += self.__remove_prefix_list(self.V6, names['pl_v6'])
|
cmds += self.__remove_prefix_list(self.V6, names['pl_v6'])
|
||||||
cmds += self.__remove_community(names['community'])
|
cmds += self.__remove_community(names['community'])
|
||||||
|
cmds += self.__update_default_route_map_entry(names['rm_v4'], default_action)
|
||||||
|
cmds += self.__update_default_route_map_entry(names['rm_v6'], default_action)
|
||||||
if cmds:
|
if cmds:
|
||||||
self.cfg_mgr.push_list(cmds)
|
self.cfg_mgr.push_list(cmds)
|
||||||
peer_groups = self.__find_peer_group_by_deployment_id(deployment_id)
|
peer_groups = self.__find_peer_group_by_deployment_id(deployment_id)
|
||||||
@ -676,7 +679,7 @@ class BGPAllowListMgr(Manager):
|
|||||||
"""
|
"""
|
||||||
return 'ip' if af == self.V4 else 'ipv6'
|
return 'ip' if af == self.V4 else 'ipv6'
|
||||||
|
|
||||||
def __get_default_action_community(self, data):
|
def __get_default_action_community(self, data=None):
|
||||||
"""
|
"""
|
||||||
Determine the default action community based on the request.
|
Determine the default action community based on the request.
|
||||||
If request doesn't contain "default_action" field - the default_action value
|
If request doesn't contain "default_action" field - the default_action value
|
||||||
@ -685,7 +688,7 @@ class BGPAllowListMgr(Manager):
|
|||||||
:return: returns community value for "default_action"
|
:return: returns community value for "default_action"
|
||||||
"""
|
"""
|
||||||
drop_community = self.constants["bgp"]["allow_list"]["drop_community"]
|
drop_community = self.constants["bgp"]["allow_list"]["drop_community"]
|
||||||
if "default_action" in data:
|
if data and "default_action" in data:
|
||||||
if data["default_action"] == "deny":
|
if data["default_action"] == "deny":
|
||||||
return "no-export"
|
return "no-export"
|
||||||
else: # "permit"
|
else: # "permit"
|
||||||
|
|||||||
@ -3,6 +3,7 @@ from bgpcfgd.directory import Directory
|
|||||||
from bgpcfgd.template import TemplateFabric
|
from bgpcfgd.template import TemplateFabric
|
||||||
import bgpcfgd
|
import bgpcfgd
|
||||||
from mock import MagicMock, patch
|
from mock import MagicMock, patch
|
||||||
|
from copy import deepcopy
|
||||||
|
|
||||||
|
|
||||||
swsscommon_module_mock = MagicMock()
|
swsscommon_module_mock = MagicMock()
|
||||||
@ -25,7 +26,7 @@ global_constants = {
|
|||||||
}
|
}
|
||||||
|
|
||||||
@patch.dict("sys.modules", swsscommon=swsscommon_module_mock)
|
@patch.dict("sys.modules", swsscommon=swsscommon_module_mock)
|
||||||
def set_del_test(op, args, currect_config, expected_config):
|
def set_del_test(op, args, currect_config, expected_config, update_global_default_action=None):
|
||||||
from bgpcfgd.managers_allow_list import BGPAllowListMgr
|
from bgpcfgd.managers_allow_list import BGPAllowListMgr
|
||||||
set_del_test.push_list_called = False
|
set_del_test.push_list_called = False
|
||||||
def push_list(args):
|
def push_list(args):
|
||||||
@ -43,10 +44,12 @@ def set_del_test(op, args, currect_config, expected_config):
|
|||||||
'directory': Directory(),
|
'directory': Directory(),
|
||||||
'cfg_mgr': cfg_mgr,
|
'cfg_mgr': cfg_mgr,
|
||||||
'tf': TemplateFabric(),
|
'tf': TemplateFabric(),
|
||||||
'constants': global_constants,
|
'constants': deepcopy(global_constants),
|
||||||
}
|
}
|
||||||
|
|
||||||
mgr = BGPAllowListMgr(common_objs, "CONFIG_DB", "BGP_ALLOWED_PREFIXES")
|
mgr = BGPAllowListMgr(common_objs, "CONFIG_DB", "BGP_ALLOWED_PREFIXES")
|
||||||
|
if update_global_default_action:
|
||||||
|
mgr.constants["bgp"]["allow_list"]["default_action"] = update_global_default_action
|
||||||
if op == "SET":
|
if op == "SET":
|
||||||
mgr.set_handler(*args)
|
mgr.set_handler(*args)
|
||||||
elif op == "DEL":
|
elif op == "DEL":
|
||||||
@ -88,6 +91,74 @@ def test_set_handler_with_community():
|
|||||||
' match community COMMUNITY_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020',
|
' match community COMMUNITY_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020',
|
||||||
]
|
]
|
||||||
)
|
)
|
||||||
|
def test_set_handler_with_community_and_permit_action():
|
||||||
|
set_del_test(
|
||||||
|
"SET",
|
||||||
|
("DEPLOYMENT_ID|5|1010:2020", {
|
||||||
|
"prefixes_v4": "10.20.30.0/24,30.50.0.0/16",
|
||||||
|
"prefixes_v6": "fc00:20::/64,fc00:30::/64",
|
||||||
|
"default_action":"permit"
|
||||||
|
}),
|
||||||
|
[
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 65535',
|
||||||
|
' set community 123:123 additive',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 65535',
|
||||||
|
' set community 123:123 additive'
|
||||||
|
],
|
||||||
|
[
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4 seq 10 deny 0.0.0.0/0 le 17',
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4 seq 20 permit 10.20.30.0/24 le 32',
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4 seq 30 permit 30.50.0.0/16 le 32',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6 seq 10 deny 0::/0 le 59',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6 seq 20 deny 0::/0 ge 65',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6 seq 30 permit fc00:20::/64 le 128',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6 seq 40 permit fc00:30::/64 le 128',
|
||||||
|
'bgp community-list standard COMMUNITY_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020 permit 1010:2020',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 10',
|
||||||
|
' match ip address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4',
|
||||||
|
' match community COMMUNITY_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 10',
|
||||||
|
' match ipv6 address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6',
|
||||||
|
' match community COMMUNITY_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020',
|
||||||
|
]
|
||||||
|
)
|
||||||
|
|
||||||
|
def test_set_handler_with_community_and_deny_action():
|
||||||
|
set_del_test(
|
||||||
|
"SET",
|
||||||
|
("DEPLOYMENT_ID|5|1010:2020", {
|
||||||
|
"prefixes_v4": "10.20.30.0/24,30.50.0.0/16",
|
||||||
|
"prefixes_v6": "fc00:20::/64,fc00:30::/64",
|
||||||
|
"default_action":"deny"
|
||||||
|
}),
|
||||||
|
[
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 65535',
|
||||||
|
' set community 123:123 additive',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 65535',
|
||||||
|
' set community 123:123 additive'
|
||||||
|
],
|
||||||
|
[
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4 seq 10 deny 0.0.0.0/0 le 17',
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4 seq 20 permit 10.20.30.0/24 le 32',
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4 seq 30 permit 30.50.0.0/16 le 32',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6 seq 10 deny 0::/0 le 59',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6 seq 20 deny 0::/0 ge 65',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6 seq 30 permit fc00:20::/64 le 128',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6 seq 40 permit fc00:30::/64 le 128',
|
||||||
|
'bgp community-list standard COMMUNITY_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020 permit 1010:2020',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 10',
|
||||||
|
' match ip address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4',
|
||||||
|
' match community COMMUNITY_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 10',
|
||||||
|
' match ipv6 address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6',
|
||||||
|
' match community COMMUNITY_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 65535',
|
||||||
|
' set community no-export additive',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 65535',
|
||||||
|
' set community no-export additive'
|
||||||
|
]
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
def test_set_handler_no_community():
|
def test_set_handler_no_community():
|
||||||
set_del_test(
|
set_del_test(
|
||||||
@ -116,6 +187,66 @@ def test_set_handler_no_community():
|
|||||||
' match ipv6 address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6',
|
' match ipv6 address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6',
|
||||||
]
|
]
|
||||||
)
|
)
|
||||||
|
def test_set_handler_no_community_with_permit_action():
|
||||||
|
set_del_test(
|
||||||
|
"SET",
|
||||||
|
("DEPLOYMENT_ID|5", {
|
||||||
|
"prefixes_v4": "20.20.30.0/24,40.50.0.0/16",
|
||||||
|
"prefixes_v6": "fc01:20::/64,fc01:30::/64",
|
||||||
|
"default_action":"permit"
|
||||||
|
}),
|
||||||
|
[
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 65535',
|
||||||
|
' set community 123:123 additive',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 65535',
|
||||||
|
' set community 123:123 additive',
|
||||||
|
],
|
||||||
|
[
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V4 seq 10 deny 0.0.0.0/0 le 17',
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V4 seq 20 permit 20.20.30.0/24 le 32',
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V4 seq 30 permit 40.50.0.0/16 le 32',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6 seq 10 deny 0::/0 le 59',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6 seq 20 deny 0::/0 ge 65',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6 seq 30 permit fc01:20::/64 le 128',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6 seq 40 permit fc01:30::/64 le 128',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 30000',
|
||||||
|
' match ip address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V4',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 30000',
|
||||||
|
' match ipv6 address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6',
|
||||||
|
]
|
||||||
|
)
|
||||||
|
def test_set_handler_no_community_with_deny_action():
|
||||||
|
set_del_test(
|
||||||
|
"SET",
|
||||||
|
("DEPLOYMENT_ID|5", {
|
||||||
|
"prefixes_v4": "20.20.30.0/24,40.50.0.0/16",
|
||||||
|
"prefixes_v6": "fc01:20::/64,fc01:30::/64",
|
||||||
|
"default_action":"deny"
|
||||||
|
}),
|
||||||
|
[
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 65535',
|
||||||
|
' set community 123:123 additive',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 65535',
|
||||||
|
' set community 123:123 additive',
|
||||||
|
],
|
||||||
|
[
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V4 seq 10 deny 0.0.0.0/0 le 17',
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V4 seq 20 permit 20.20.30.0/24 le 32',
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V4 seq 30 permit 40.50.0.0/16 le 32',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6 seq 10 deny 0::/0 le 59',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6 seq 20 deny 0::/0 ge 65',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6 seq 30 permit fc01:20::/64 le 128',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6 seq 40 permit fc01:30::/64 le 128',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 30000',
|
||||||
|
' match ip address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V4',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 30000',
|
||||||
|
' match ipv6 address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 65535',
|
||||||
|
' set community no-export additive',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 65535',
|
||||||
|
' set community no-export additive'
|
||||||
|
]
|
||||||
|
)
|
||||||
|
|
||||||
def test_del_handler_with_community():
|
def test_del_handler_with_community():
|
||||||
set_del_test(
|
set_del_test(
|
||||||
@ -136,6 +267,11 @@ def test_del_handler_with_community():
|
|||||||
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 10',
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 10',
|
||||||
' match ipv6 address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6',
|
' match ipv6 address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6',
|
||||||
' match community COMMUNITY_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020',
|
' match community COMMUNITY_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 65535',
|
||||||
|
' set community 123:123 additive',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 65535',
|
||||||
|
' set community 123:123 additive',
|
||||||
|
|
||||||
""
|
""
|
||||||
],
|
],
|
||||||
[
|
[
|
||||||
@ -147,6 +283,155 @@ def test_del_handler_with_community():
|
|||||||
]
|
]
|
||||||
)
|
)
|
||||||
|
|
||||||
|
def test_del_handler_with_exiting_community_deny_action():
|
||||||
|
set_del_test(
|
||||||
|
"DEL",
|
||||||
|
("DEPLOYMENT_ID|5|1010:2020",),
|
||||||
|
[
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4 seq 10 deny 0.0.0.0/0 le 17',
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4 seq 20 permit 10.20.30.0/24 ge 25',
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4 seq 30 permit 30.50.0.0/16 ge 17',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6 seq 10 deny 0::/0 le 59',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6 seq 20 deny 0::/0 ge 65',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6 seq 30 permit fc00:20::/64 ge 65',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6 seq 40 permit fc00:30::/64 ge 65',
|
||||||
|
'bgp community-list standard COMMUNITY_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020 permit 1010:2020',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 10',
|
||||||
|
' match ip address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4',
|
||||||
|
' match community COMMUNITY_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 10',
|
||||||
|
' match ipv6 address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6',
|
||||||
|
' match community COMMUNITY_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 65535',
|
||||||
|
' set community no-export additive',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 65535',
|
||||||
|
' set community no-export additive',
|
||||||
|
""
|
||||||
|
],
|
||||||
|
[
|
||||||
|
'no route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 10',
|
||||||
|
'no route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 10',
|
||||||
|
'no ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4',
|
||||||
|
'no ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6',
|
||||||
|
'no bgp community-list standard COMMUNITY_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 65535',
|
||||||
|
' set community 123:123 additive',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 65535',
|
||||||
|
' set community 123:123 additive',
|
||||||
|
]
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def test_del_handler_with_exiting_community_permit_action():
|
||||||
|
set_del_test(
|
||||||
|
"DEL",
|
||||||
|
("DEPLOYMENT_ID|5|1010:2020",),
|
||||||
|
[
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4 seq 10 deny 0.0.0.0/0 le 17',
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4 seq 20 permit 10.20.30.0/24 ge 25',
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4 seq 30 permit 30.50.0.0/16 ge 17',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6 seq 10 deny 0::/0 le 59',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6 seq 20 deny 0::/0 ge 65',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6 seq 30 permit fc00:20::/64 ge 65',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6 seq 40 permit fc00:30::/64 ge 65',
|
||||||
|
'bgp community-list standard COMMUNITY_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020 permit 1010:2020',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 10',
|
||||||
|
' match ip address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4',
|
||||||
|
' match community COMMUNITY_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 10',
|
||||||
|
' match ipv6 address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6',
|
||||||
|
' match community COMMUNITY_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 65535',
|
||||||
|
' set community 123:123 additive',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 65535',
|
||||||
|
' set community 123:123 additive',
|
||||||
|
""
|
||||||
|
],
|
||||||
|
[
|
||||||
|
'no route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 10',
|
||||||
|
'no route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 10',
|
||||||
|
'no ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4',
|
||||||
|
'no ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6',
|
||||||
|
'no bgp community-list standard COMMUNITY_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020',
|
||||||
|
]
|
||||||
|
)
|
||||||
|
|
||||||
|
def test_del_handler_with_exiting_community_deny_action_global_deny():
|
||||||
|
set_del_test(
|
||||||
|
"DEL",
|
||||||
|
("DEPLOYMENT_ID|5|1010:2020",),
|
||||||
|
[
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4 seq 10 deny 0.0.0.0/0 le 17',
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4 seq 20 permit 10.20.30.0/24 ge 25',
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4 seq 30 permit 30.50.0.0/16 ge 17',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6 seq 10 deny 0::/0 le 59',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6 seq 20 deny 0::/0 ge 65',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6 seq 30 permit fc00:20::/64 ge 65',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6 seq 40 permit fc00:30::/64 ge 65',
|
||||||
|
'bgp community-list standard COMMUNITY_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020 permit 1010:2020',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 10',
|
||||||
|
' match ip address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4',
|
||||||
|
' match community COMMUNITY_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 10',
|
||||||
|
' match ipv6 address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6',
|
||||||
|
' match community COMMUNITY_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 65535',
|
||||||
|
' set community no-export additive',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 65535',
|
||||||
|
' set community no-export additive',
|
||||||
|
""
|
||||||
|
],
|
||||||
|
[
|
||||||
|
'no route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 10',
|
||||||
|
'no route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 10',
|
||||||
|
'no ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4',
|
||||||
|
'no ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6',
|
||||||
|
'no bgp community-list standard COMMUNITY_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020',
|
||||||
|
],
|
||||||
|
"deny"
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def test_del_handler_with_exiting_community_permit_action_global_deny():
|
||||||
|
set_del_test(
|
||||||
|
"DEL",
|
||||||
|
("DEPLOYMENT_ID|5|1010:2020",),
|
||||||
|
[
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4 seq 10 deny 0.0.0.0/0 le 17',
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4 seq 20 permit 10.20.30.0/24 ge 25',
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4 seq 30 permit 30.50.0.0/16 ge 17',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6 seq 10 deny 0::/0 le 59',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6 seq 20 deny 0::/0 ge 65',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6 seq 30 permit fc00:20::/64 ge 65',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6 seq 40 permit fc00:30::/64 ge 65',
|
||||||
|
'bgp community-list standard COMMUNITY_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020 permit 1010:2020',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 10',
|
||||||
|
' match ip address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4',
|
||||||
|
' match community COMMUNITY_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 10',
|
||||||
|
' match ipv6 address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6',
|
||||||
|
' match community COMMUNITY_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 65535',
|
||||||
|
' set community 123:123 additive',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 65535',
|
||||||
|
' set community 123:123 additive',
|
||||||
|
""
|
||||||
|
],
|
||||||
|
[
|
||||||
|
'no route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 10',
|
||||||
|
'no route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 10',
|
||||||
|
'no ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V4',
|
||||||
|
'no ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020_V6',
|
||||||
|
'no bgp community-list standard COMMUNITY_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_1010:2020',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 65535',
|
||||||
|
' set community no-export additive',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 65535',
|
||||||
|
' set community no-export additive',
|
||||||
|
],
|
||||||
|
"deny"
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
def test_del_handler_no_community():
|
def test_del_handler_no_community():
|
||||||
set_del_test(
|
set_del_test(
|
||||||
"DEL",
|
"DEL",
|
||||||
@ -163,6 +448,10 @@ def test_del_handler_no_community():
|
|||||||
' match ip address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V4',
|
' match ip address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V4',
|
||||||
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 30000',
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 30000',
|
||||||
' match ipv6 address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6',
|
' match ipv6 address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 65535',
|
||||||
|
' set community 123:123 additive',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 65535',
|
||||||
|
' set community 123:123 additive',
|
||||||
" "
|
" "
|
||||||
],
|
],
|
||||||
[
|
[
|
||||||
@ -172,6 +461,75 @@ def test_del_handler_no_community():
|
|||||||
'no ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6',
|
'no ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6',
|
||||||
]
|
]
|
||||||
)
|
)
|
||||||
|
def test_del_handler_with_no_community_deny_action():
|
||||||
|
set_del_test(
|
||||||
|
"DEL",
|
||||||
|
("DEPLOYMENT_ID|5",),
|
||||||
|
[
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V4 seq 10 deny 0.0.0.0/0 le 17',
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V4 seq 20 permit 20.20.30.0/24 ge 25',
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V4 seq 30 permit 40.50.0.0/16 ge 17',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6 seq 10 deny 0::/0 le 59',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6 seq 20 deny 0::/0 ge 65',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6 seq 30 permit fc01:20::/64 ge 65',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6 seq 40 permit fc01:30::/64 ge 65',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 30000',
|
||||||
|
' match ip address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V4',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 30000',
|
||||||
|
' match ipv6 address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 65535',
|
||||||
|
' set community no-export additive',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 65535',
|
||||||
|
' set community no-export additive',
|
||||||
|
""
|
||||||
|
],
|
||||||
|
[
|
||||||
|
'no route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 30000',
|
||||||
|
'no route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 30000',
|
||||||
|
'no ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V4',
|
||||||
|
'no ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 65535',
|
||||||
|
' set community 123:123 additive',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 65535',
|
||||||
|
' set community 123:123 additive',
|
||||||
|
]
|
||||||
|
)
|
||||||
|
def test_del_handler_with_no_community_permit_action_global_deny():
|
||||||
|
set_del_test(
|
||||||
|
"DEL",
|
||||||
|
("DEPLOYMENT_ID|5",),
|
||||||
|
[
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V4 seq 10 deny 0.0.0.0/0 le 17',
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V4 seq 20 permit 20.20.30.0/24 ge 25',
|
||||||
|
'ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V4 seq 30 permit 40.50.0.0/16 ge 17',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6 seq 10 deny 0::/0 le 59',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6 seq 20 deny 0::/0 ge 65',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6 seq 30 permit fc01:20::/64 ge 65',
|
||||||
|
'ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6 seq 40 permit fc01:30::/64 ge 65',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 30000',
|
||||||
|
' match ip address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V4',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 30000',
|
||||||
|
' match ipv6 address prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 65535',
|
||||||
|
' set community 123:123 additive',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 65535',
|
||||||
|
' set community 123:123 additive',
|
||||||
|
""
|
||||||
|
],
|
||||||
|
[
|
||||||
|
'no route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 30000',
|
||||||
|
'no route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 30000',
|
||||||
|
'no ip prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V4',
|
||||||
|
'no ipv6 prefix-list PL_ALLOW_LIST_DEPLOYMENT_ID_5_COMMUNITY_empty_V6',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 65535',
|
||||||
|
' set community no-export additive',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 65535',
|
||||||
|
' set community no-export additive',
|
||||||
|
],
|
||||||
|
"deny"
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
def test_set_handler_with_community_data_is_already_presented():
|
def test_set_handler_with_community_data_is_already_presented():
|
||||||
set_del_test(
|
set_del_test(
|
||||||
@ -244,7 +602,12 @@ def test_del_handler_with_community_no_data():
|
|||||||
set_del_test(
|
set_del_test(
|
||||||
"DEL",
|
"DEL",
|
||||||
("DEPLOYMENT_ID|5|1010:2020",),
|
("DEPLOYMENT_ID|5|1010:2020",),
|
||||||
[""],
|
[
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 65535',
|
||||||
|
' set community 123:123 additive',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 65535',
|
||||||
|
' set community 123:123 additive'
|
||||||
|
],
|
||||||
[]
|
[]
|
||||||
)
|
)
|
||||||
|
|
||||||
@ -252,7 +615,12 @@ def test_del_handler_no_community_no_data():
|
|||||||
set_del_test(
|
set_del_test(
|
||||||
"DEL",
|
"DEL",
|
||||||
("DEPLOYMENT_ID|5",),
|
("DEPLOYMENT_ID|5",),
|
||||||
[""],
|
[
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V4 permit 65535',
|
||||||
|
' set community 123:123 additive',
|
||||||
|
'route-map ALLOW_LIST_DEPLOYMENT_ID_5_V6 permit 65535',
|
||||||
|
' set community 123:123 additive'
|
||||||
|
],
|
||||||
[]
|
[]
|
||||||
)
|
)
|
||||||
|
|
||||||
@ -587,4 +955,4 @@ def test___get_default_action_permit_3():
|
|||||||
mgr = construct_BGPAllowListMgr(constants)
|
mgr = construct_BGPAllowListMgr(constants)
|
||||||
assert mgr._BGPAllowListMgr__get_default_action_community(data) == "123:123"
|
assert mgr._BGPAllowListMgr__get_default_action_community(data) == "123:123"
|
||||||
|
|
||||||
# FIXME: more testcases for coverage
|
# FIXME: more testcases for coverage
|
||||||
|
|||||||
Reference in New Issue
Block a user