matthew/sonic-buildimage
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Mellanox] PSU led platform API fixes (#6213)

Browse Source 
Return 'False' when unsupported led color is requested, preventing an exception.

Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
This commit is contained in:
shlomibitton 2020-12-23 00:54:40 +02:00 committed by GitHub
parent 9d35fa19dc
commit feb4b04cdc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
platform/mellanox/mlnx-platform-api/sonic_platform/led.py
View File

@ -286,9 +286,11 @@ class SharedLed(object):
def update_status_led(self): def update_status_led(self):
target_color = Led.STATUS_LED_COLOR_GREEN target_color = Led.STATUS_LED_COLOR_GREEN
for virtual_led in self._virtual_leds: for virtual_led in self._virtual_leds:
if SharedLed.LED_PRIORITY[virtual_led.get_led_color()] < SharedLed.LED_PRIORITY[target_color]: try:
target_color = virtual_led.get_led_color() if SharedLed.LED_PRIORITY[virtual_led.get_led_color()] < SharedLed.LED_PRIORITY[target_color]:
target_color = virtual_led.get_led_color()
except KeyError:
return False
return self._led.set_status(target_color) return self._led.set_status(target_color)
def get_status(self): def get_status(self):
@ -302,8 +304,13 @@ class ComponentFaultyIndicator(object):
self._shared_led.add_virtual_leds(self) self._shared_led.add_virtual_leds(self)
def set_status(self, color): def set_status(self, color):
current_color = self._color
self._color = color self._color = color
return self._shared_led.update_status_led() if self._shared_led.update_status_led():
return True
else:
self._color = current_color
return False
def get_led_color(self): def get_led_color(self):
return self._color return self._color