From f9e93d2f31bacbebaededee9ba3d2fd5aaf9fe0c Mon Sep 17 00:00:00 2001 From: Lior Avramov <73036155+liorghub@users.noreply.github.com> Date: Thu, 23 Jun 2022 00:54:14 +0300 Subject: [PATCH] Change severity of log messages for cases where docker container was stopped during service checker operation (#11188) #### Why I did it There might be a case where service checker periodic operation determined that specific container is running but when it tries to perform an operation on it, it was already closed by the user. This is a valid flow and we should not log an error message, informative warning is enough. #### How I did it I reduce log severity. #### How to verify it I verified it manually. --- src/system-health/health_checker/service_checker.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/system-health/health_checker/service_checker.py b/src/system-health/health_checker/service_checker.py index 6918da0b9f..33eeb4dfb7 100644 --- a/src/system-health/health_checker/service_checker.py +++ b/src/system-health/health_checker/service_checker.py @@ -144,11 +144,11 @@ class ServiceChecker(HealthChecker): # Get container volumn folder container_folder = self._get_container_folder(container) if not container_folder: - logger.log_error('Failed to get container folder for {}'.format(container_folder)) + logger.log_warning('Could not find MergedDir of container {}, was container stopped?'.format(container)) return if not os.path.exists(container_folder): - logger.log_error('Container folder does not exist: {}'.format(container_folder)) + logger.log_warning('MergedDir {} of container {} not found in filesystem, was container stopped?'.format(container_folder, container)) return # Get critical_processes file path