matthew/sonic-buildimage
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[caclmgrd] Remove sleep which allowed threads to progress (#7475)

Browse Source 
Previously, a brief sleep was necessary in order to get Python threads to progress. The root cause of this has since been found and fixed in sonic-swss-common: Azure/sonic-swss-common#477. The submodule was updated here, so we can now safely remove this sleep.

This PR should also be cherry-picked to the 202012 branch once the submodule is updated there to also include the fix.
This commit is contained in:
Joe LeVeque 2021-04-29 11:07:04 -07:00 committed by Danny Allen
parent 61bb5c168c
commit e4a9e0c1b6
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/sonic-host-services/scripts/caclmgrd
View File

@ -602,11 +602,6 @@ class ControlPlaneAclManager(daemon_base.DaemonBase):
while True: while True:
ctrl_plane_acl_notification = set() ctrl_plane_acl_notification = set()
# A brief sleep appears necessary in this loop or any spawned
# update threads will get stuck. Appears to be due to the sel.select() call.
# TODO: Eliminate the need for this sleep.
time.sleep(0.1)
(state, selectableObj) = sel.select(SELECT_TIMEOUT_MS) (state, selectableObj) = sel.select(SELECT_TIMEOUT_MS)
# Continue if select is timeout or selectable object is not return # Continue if select is timeout or selectable object is not return
if state != swsscommon.Select.OBJECT: if state != swsscommon.Select.OBJECT: