From db6fa1d2938a1bdb1e66a9ba96b22b5111055424 Mon Sep 17 00:00:00 2001
From: Samuel Angebault <staphylo@arista.com>
Date: Fri, 2 Oct 2020 09:16:05 -0700
Subject: [PATCH] [led]: Skip ledinit if there is no led_proc_init.soc file for
 broadcom platform (#5483)

Some platforms don't leverage the brcm led coprocessor.
However ledinit will try to load a non existing file and exit with an
error code.
This change is a cosmetic fix mostly.

- How to verify it

Boot a platform without the configuration and verify in the syslog that the exit status of ledinit is 0
Boot a platform with the configuration and verify in the syslog that the exit status of ledinit is 0 and the leds are working.
Verified by adding a dumb led_proc_init.soc on an Arista platform which usually doesn't use it.
---
 platform/broadcom/docker-syncd-brcm/start_led.sh | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/platform/broadcom/docker-syncd-brcm/start_led.sh b/platform/broadcom/docker-syncd-brcm/start_led.sh
index 01d25cded8..964aa23eb0 100755
--- a/platform/broadcom/docker-syncd-brcm/start_led.sh
+++ b/platform/broadcom/docker-syncd-brcm/start_led.sh
@@ -2,6 +2,12 @@
 
 PLATFORM_DIR=/usr/share/sonic/platform
 SYNCD_SOCKET_FILE=/var/run/sswsyncd/sswsyncd.socket
+LED_PROC_INIT_SOC=${PLATFORM_DIR}/led_proc_init.soc
+
+if [ ! -f "$LED_PROC_INIT_SOC" ]; then
+   echo "No soc led configuration found under $LED_SOC_INIT_SOC"
+   exit 0
+fi
 
 # Function: wait until syncd has created the socket for bcmcmd to connect to
 wait_syncd() {
@@ -30,8 +36,8 @@ wait_syncd() {
 }
 
 # If this platform has an initialization file for the Broadcom LED microprocessor, load it
-if [[ -r ${PLATFORM_DIR}/led_proc_init.soc && ! -f /var/warmboot/warm-starting ]]; then
+if [[ -r "$LED_PROC_INIT_SOC" && ! -f /var/warmboot/warm-starting ]]; then
     wait_syncd
 fi
 
-/usr/bin/bcmcmd -t 60 "rcload /usr/share/sonic/platform/led_proc_init.soc"
+/usr/bin/bcmcmd -t 60 "rcload $LED_PROC_INIT_SOC"