[BGP] starting BGP service after swss (#12381)

Why I did it
BGP service has always been starting after interface-config. However, recently we discovered an issue where some BGP sessions are unable to establish due to BGP daemon not able to read the interface IP.

This issue was clearly observed after upgrading to FRR 8.2.2. See more details in #12380.

How I did it
Delaying starting BGP seems to be a workaround for this issue.

However, caution is that this delay might impact warm reboot timing and other timing sequences.

This workaround is reducing the probability of hitting the issue by close to 100X. However, this workaround is not bulletproof as test shows. It is still preferrable to have a proper FRR fix and revert this change in the future.

How to verify it
Continuously issuing config reload and check BGP session status afterwards.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
This commit is contained in:
Ying Xie 2022-10-13 09:24:06 -07:00 committed by GitHub
parent 50b77a5d44
commit bc684fef0b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -7,6 +7,7 @@ After=updategraph.service
BindsTo=sonic.target
After=sonic.target
Before=ntp-config.service
After=swss{% if multi_instance == 'true' %}@%i{% endif %}.service
After=interfaces-config.service
StartLimitIntervalSec=1200
StartLimitBurst=3