[Mellanox] add more log while doing sysfs reading (#11556)
- Why I did it Add more log while doing sysfs reading to increase the debug capability - How I did it Log the relevant file path and error number while sysfs reading return None - How to verify it Manual test
This commit is contained in:
parent
34a20c40ec
commit
bc300b4d79
@ -14,6 +14,7 @@
|
|||||||
# See the License for the specific language governing permissions and
|
# See the License for the specific language governing permissions and
|
||||||
# limitations under the License.
|
# limitations under the License.
|
||||||
#
|
#
|
||||||
|
import ctypes
|
||||||
import functools
|
import functools
|
||||||
import subprocess
|
import subprocess
|
||||||
import json
|
import json
|
||||||
@ -43,7 +44,14 @@ def read_from_file(file_path, target_type, default='', raise_exception=False, lo
|
|||||||
"""
|
"""
|
||||||
try:
|
try:
|
||||||
with open(file_path, 'r') as f:
|
with open(file_path, 'r') as f:
|
||||||
value = target_type(f.read().strip())
|
value = f.read()
|
||||||
|
if value is None:
|
||||||
|
# None return value is not allowed in any case, so we log error here for further debug.
|
||||||
|
logger.log_error('Failed to read from {}, value is None, errno is {}'.format(file_path, ctypes.get_errno()))
|
||||||
|
# Raise ValueError for the except statement to handle this as a normal exception
|
||||||
|
raise ValueError('File content of {} is None'.format(file_path))
|
||||||
|
else:
|
||||||
|
value = target_type(value.strip())
|
||||||
except (ValueError, IOError) as e:
|
except (ValueError, IOError) as e:
|
||||||
if log_func:
|
if log_func:
|
||||||
log_func('Failed to read from file {} - {}'.format(file_path, repr(e)))
|
log_func('Failed to read from file {} - {}'.format(file_path, repr(e)))
|
||||||
|
Reference in New Issue
Block a user