matthew/sonic-buildimage
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[Monit] Use the string "/usr/bin/syncd\s" to monitor the syncd process (#4706)

Browse Source 
**- Why I did it**
After discussed with Joe, we use the string "/usr/bin/syncd\s" in Monit configuration file to monitor 
syncd process on Broadcom and Mellanox. Due to my careless, I did not find this bug during the 
previous testing. If we use the string "/usr/bin/syncd" in Monit configuration file to monitor the 
syncd process, Monit will not detect whether syncd process is running or not. 

If we ran the command  `sudo monit procmactch “/usr/bin/syncd”` on Broadcom, there will be three 
processes in syncd container which matched this "/usr/bin/syncd": `/bin/bash /usr/bin/syncd.sh
wait`, `/usr/bin/dsserve /usr/bin/syncd –diag -u -p /etc/sai.d/sai.profile` and `/usr/bin/syncd –diag -
u -p /etc/sai.d/said.profile`. Monit will select the processes with the highest uptime (at there 
`/bin/bash /usr/bin/syncd.sh wait`) to match and did not select `/usr/bin/syncd –diag -u -p
/etc/sai.d/said.profile` to match. 

Similarly, On Mellanox Monit will also select the process with the highest uptime (at there 
`/bin/bash /usr/bin/syncd.sh wait`) to match and did not select `/usr/bin/syncd –diag -u -p
/etc/sai.d/said.profile` to match.

That is why Monit is unable to detect whether syncd process is running or not if we use the string “/usr/bin/syncd” in Monit configuration file. If we use the string "/usr/bin/syncd\s" in Monit configuration file, Monit can filter out the process `/bin/bash /usr/bin/syncd.sh wait` and thus can correctly monitor the syncd process.

**- How I did it**

**- How to verify it**

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
This commit is contained in:
yozhao101 2020-06-25 17:03:14 -07:00 committed by GitHub
parent ddf8c8bb3c
commit b8ad0ed4e4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
9 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
platform/barefoot/docker-syncd-bfn/base_image_files/monit_syncd
View File

@ -3,5 +3,5 @@
## process list:
## syncd
###############################################################################
check process syncd matching "/usr/bin/syncd"
check process syncd matching "/usr/bin/syncd\s"
if does not exist for 5 times within 5 cycles then alert

2
platform/broadcom/docker-syncd-brcm/base_image_files/monit_syncd
View File

@ -4,7 +4,7 @@
## syncd
## dsserve
###############################################################################
check process syncd matching "/usr/bin/syncd"
check process syncd matching "/usr/bin/syncd\s"
if does not exist for 5 times within 5 cycles then alert
check process dsserve matching "/usr/bin/dsserve /usr/bin/syncd"

2
platform/cavium/docker-syncd-cavm/base_image_files/monit_syncd
View File

@ -3,5 +3,5 @@
## process list:
## syncd
###############################################################################
check process syncd matching "/usr/bin/syncd"
check process syncd matching "/usr/bin/syncd\s"
if does not exist for 5 times within 5 cycles then alert

2
platform/centec/docker-syncd-centec/base_image_files/monit_syncd
View File

@ -3,5 +3,5 @@
## process list:
## syncd
###############################################################################
check process syncd matching "/usr/bin/syncd"
check process syncd matching "/usr/bin/syncd\s"
if does not exist for 5 times within 5 cycles then alert

2
platform/marvell-arm64/docker-syncd-mrvl/base_image_files/monit_syncd
View File

@ -3,5 +3,5 @@
## process list:
## syncd
###############################################################################
check process syncd matching "/usr/bin/syncd"
check process syncd matching "/usr/bin/syncd\s"
if does not exist for 5 times within 5 cycles then alert

2
platform/marvell-armhf/docker-syncd-mrvl/base_image_files/monit_syncd
View File

@ -3,5 +3,5 @@
## process list:
## syncd
###############################################################################
check process syncd matching "/usr/bin/syncd"
check process syncd matching "/usr/bin/syncd\s"
if does not exist for 5 times within 5 cycles then alert

2
platform/marvell/docker-syncd-mrvl/base_image_files/monit_syncd
View File

@ -3,5 +3,5 @@
## process list:
## syncd
###############################################################################
check process syncd matching "/usr/bin/syncd"
check process syncd matching "/usr/bin/syncd\s"
if does not exist for 5 times within 5 cycles then alert

2
platform/mellanox/docker-syncd-mlnx/base_image_files/monit_syncd
View File

@ -3,5 +3,5 @@
## process list:
## syncd
###############################################################################
check process syncd matching "/usr/bin/syncd"
check process syncd matching "/usr/bin/syncd\s"
if does not exist for 5 times within 5 cycles then alert

2
platform/nephos/docker-syncd-nephos/base_image_files/monit_syncd
View File

@ -4,7 +4,7 @@
## syncd
## dsserve
###############################################################################
check process syncd matching "/usr/bin/syncd"
check process syncd matching "/usr/bin/syncd\s"
if does not exist for 5 times within 5 cycles then alert
check process dsserve matching "/usr/bin/dsserve /usr/bin/syncd"