matthew/sonic-buildimage
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[sonic-cfggen]: Update unit test to remove asn 0 (#10454)

Browse Source 
Why I did it
ASN range is from 1 to 4294967295, need to remove invalid ASN.

How I did it
Update unit test and replace ASN 0.

How to verify it
Run unit test for sonic-config-engine.

Signed-off-by: Gang Lv ganglv@microsoft.com
This commit is contained in:
ganglv 2022-04-06 14:33:26 +08:00 committed by GitHub
parent ce26c04a09
commit b152f2a0fc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/sonic-config-engine/tests/radv-test-sample-graph.xml
View File

@ -90,7 +90,7 @@
</PeeringSessions> </PeeringSessions>
<Routers xmlns:a="http://schemas.datacontract.org/2004/07/Microsoft.Search.Autopilot.Evolution"> <Routers xmlns:a="http://schemas.datacontract.org/2004/07/Microsoft.Search.Autopilot.Evolution">
<a:BGPRouterDeclaration> <a:BGPRouterDeclaration>
<a:ASN>0</a:ASN> <a:ASN>1</a:ASN>
<a:BgpGroups/> <a:BgpGroups/>
<a:Hostname>BGPMonitor</a:Hostname> <a:Hostname>BGPMonitor</a:Hostname>
<a:Peers> <a:Peers>

2
src/sonic-config-engine/tests/sample-graph-resource-type.xml
View File

@ -72,7 +72,7 @@
</PeeringSessions> </PeeringSessions>
<Routers xmlns:a="http://schemas.datacontract.org/2004/07/Microsoft.Search.Autopilot.Evolution"> <Routers xmlns:a="http://schemas.datacontract.org/2004/07/Microsoft.Search.Autopilot.Evolution">
<a:BGPRouterDeclaration> <a:BGPRouterDeclaration>
<a:ASN>0</a:ASN> <a:ASN>1</a:ASN>
<a:BgpGroups/> <a:BgpGroups/>
<a:Hostname>BGPMonitor</a:Hostname> <a:Hostname>BGPMonitor</a:Hostname>
<a:Peers> <a:Peers>

2
src/sonic-config-engine/tests/sample-graph-subintf.xml
View File

@ -72,7 +72,7 @@
</PeeringSessions> </PeeringSessions>
<Routers xmlns:a="http://schemas.datacontract.org/2004/07/Microsoft.Search.Autopilot.Evolution"> <Routers xmlns:a="http://schemas.datacontract.org/2004/07/Microsoft.Search.Autopilot.Evolution">
<a:BGPRouterDeclaration> <a:BGPRouterDeclaration>
<a:ASN>0</a:ASN> <a:ASN>1</a:ASN>
<a:BgpGroups/> <a:BgpGroups/>
<a:Hostname>BGPMonitor</a:Hostname> <a:Hostname>BGPMonitor</a:Hostname>
<a:Peers> <a:Peers>

2
src/sonic-config-engine/tests/simple-sample-graph.xml
View File

@ -72,7 +72,7 @@
</PeeringSessions> </PeeringSessions>
<Routers xmlns:a="http://schemas.datacontract.org/2004/07/Microsoft.Search.Autopilot.Evolution"> <Routers xmlns:a="http://schemas.datacontract.org/2004/07/Microsoft.Search.Autopilot.Evolution">
<a:BGPRouterDeclaration> <a:BGPRouterDeclaration>
<a:ASN>0</a:ASN> <a:ASN>1</a:ASN>
<a:BgpGroups/> <a:BgpGroups/>
<a:Hostname>BGPMonitor</a:Hostname> <a:Hostname>BGPMonitor</a:Hostname>
<a:Peers> <a:Peers>

2
src/sonic-config-engine/tests/t0-sample-graph.xml
View File

@ -90,7 +90,7 @@
</PeeringSessions> </PeeringSessions>
<Routers xmlns:a="http://schemas.datacontract.org/2004/07/Microsoft.Search.Autopilot.Evolution"> <Routers xmlns:a="http://schemas.datacontract.org/2004/07/Microsoft.Search.Autopilot.Evolution">
<a:BGPRouterDeclaration> <a:BGPRouterDeclaration>
<a:ASN>0</a:ASN> <a:ASN>1</a:ASN>
<a:BgpGroups/> <a:BgpGroups/>
<a:Hostname>BGPMonitor</a:Hostname> <a:Hostname>BGPMonitor</a:Hostname>
<a:Peers> <a:Peers>

2
src/sonic-config-engine/tests/test_cfggen.py
View File

@ -685,7 +685,7 @@ class TestCfgGen(TestCase):
output = self.run_script(argument) output = self.run_script(argument)
self.assertEqual( self.assertEqual(
utils.to_dict(output.strip()), utils.to_dict(output.strip()),
utils.to_dict("{'10.20.30.40': {'rrclient': 0, 'name': 'BGPMonitor', 'local_addr': '10.1.0.32', 'nhopself': 0, 'holdtime': '10', 'asn': '0', 'keepalive': '3'}}") utils.to_dict("{'10.20.30.40': {'rrclient': 0, 'name': 'BGPMonitor', 'local_addr': '10.1.0.32', 'nhopself': 0, 'holdtime': '10', 'asn': '1', 'keepalive': '3'}}")
) )
def test_minigraph_bgp_voq_chassis_peer(self): def test_minigraph_bgp_voq_chassis_peer(self):