matthew/sonic-buildimage
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[multi-asic] optimize api that checks port/port-channel/bgp is internal (#7232)

Browse Source 
Optimize the API's is_port_internal() , is_portchannel_internal() and is_bgp_internal ()to call get_entry(Redis hget) instead of get_table (Redis keys *)
This commit is contained in:
abdosi 2021-04-05 18:55:10 -07:00 committed by GitHub
parent 6d83a424b5
commit 9f2deae8fb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 33 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
src/sonic-py-common/sonic_py_common/multi_asic.py
View File

@ -230,6 +230,23 @@ def get_namespace_list(namespace=None):
return ns_list
def get_port_entry(port, namespace):
"""
Retrieves the given port information
Returns:
a dict of given port entry
"""
all_ports = {}
ns_list = get_namespace_list(namespace)
for ns in ns_list:
ports = get_port_entry_for_asic(port, ns)
if ports:
return ports
return all_ports
def get_port_table(namespace=None):
"""
@ -247,6 +264,12 @@ def get_port_table(namespace=None):
return all_ports
def get_port_entry_for_asic(port, namespace):
config_db = connect_config_db_for_ns(namespace)
ports = config_db.get_entry(PORT_CFG_DB_TABLE, port)
return ports
def get_port_table_for_asic(namespace):
@ -274,14 +297,14 @@ def get_namespace_for_port(port_name):
def get_port_role(port_name, namespace=None):
ports_config = get_port_table(namespace)
if port_name not in ports_config:
ports_config = get_port_entry(port_name, namespace)
if not ports_config:
raise ValueError('Unknown port name {}'.format(port_name))
if PORT_ROLE not in ports_config[port_name]:
if PORT_ROLE not in ports_config:
return EXTERNAL_PORT
role = ports_config[port_name][PORT_ROLE]
role = ports_config[PORT_ROLE]
return role
@ -315,11 +338,11 @@ def is_port_channel_internal(port_channel, namespace=None):
for ns in ns_list:
config_db = connect_config_db_for_ns(ns)
port_channels = config_db.get_table(PORT_CHANNEL_CFG_DB_TABLE)
port_channels = config_db.get_entry(PORT_CHANNEL_CFG_DB_TABLE, port_channel)
if port_channel in port_channels:
if 'members' in port_channels[port_channel]:
members = port_channels[port_channel]['members']
if port_channels:
if 'members' in port_channels:
members = port_channels['members']
if is_port_internal(members[0], namespace):
return True
@ -363,8 +386,8 @@ def is_bgp_session_internal(bgp_neigh_ip, namespace=None):
for ns in ns_list:
config_db = connect_config_db_for_ns(ns)
bgp_sessions = config_db.get_table(BGP_INTERNAL_NEIGH_CFG_DB_TABLE)
if bgp_neigh_ip in bgp_sessions:
bgp_sessions = config_db.get_entry(BGP_INTERNAL_NEIGH_CFG_DB_TABLE, bgp_neigh_ip)
if bgp_sessions:
return True
return False