[Mellanox] Refactor SFP to use new APIs. (#10317)

- Why I did it
Refactor SFP code to remove code duplication and to be able to use the latest features available in new APIs.

- How I did it
Refactor SFP code to remove code duplication and to be able to use the latest features available in new APIs.

- How to verify it
Run sonic-mgmt/platform_tests/sfp tests

platform/mellanox/mlnx-platform-api/sonic_platform/chassis.py

@@ -74,7 +74,7 @@ class Chassis(ChassisBase):
 
         # Initialize DMI data
         self.dmi_data = None
-        
+
         # move the initialization of each components to their dedicated initializer
         # which will be called from platform
         #
@@ -115,7 +115,7 @@ class Chassis(ChassisBase):
 
         if SFP.shared_sdk_handle:
             deinitialize_sdk_handle(SFP.shared_sdk_handle)
-        
+
     ##############################################
     # PSU methods
     ##############################################
@@ -238,7 +238,7 @@ class Chassis(ChassisBase):
         if index < sfp_count:
             if not self._sfp_list:
                 self._sfp_list = [None] * sfp_count
-            
+
             if not self._sfp_list[index]:
                 from .sfp import SFP
                 self._sfp_list[index] = SFP(index)
@@ -295,7 +295,7 @@ class Chassis(ChassisBase):
         index = index - 1
         self.initialize_single_sfp(index)
         return super(Chassis, self).get_sfp(index)
-        
+
     def get_change_event(self, timeout=0):
         """
         Returns a nested dictionary containing all devices which have
@@ -310,7 +310,7 @@ class Chassis(ChassisBase):
                 - True if call successful, False if not;
                 - A nested dictionary where key is a device type,
                   value is a dictionary with key:value pairs in the format of
-                  {'device_id':'device_event'}, 
+                  {'device_id':'device_event'},
                   where device_id is the device ID for this device and
                         device_event,
                              status='1' represents device inserted,
@@ -596,7 +596,7 @@ class Chassis(ChassisBase):
         Note:
             We overload this method to ensure that watchdog is only initialized
             when it is referenced. Currently, only one daemon can open the watchdog.
-            To initialize watchdog in the constructor causes multiple daemon 
+            To initialize watchdog in the constructor causes multiple daemon
             try opening watchdog when loading and constructing a chassis object
             and fail. By doing so we can eliminate that risk.
         """
@@ -609,11 +609,11 @@ class Chassis(ChassisBase):
 
         return self._watchdog
 
-    
+
     def get_revision(self):
         """
         Retrieves the hardware revision of the device
-        
+
         Returns:
             string: Revision value of device
         """
@@ -647,7 +647,7 @@ class Chassis(ChassisBase):
 
     def _verify_reboot_cause(self, filename):
         '''
-        Open and read the reboot cause file in 
+        Open and read the reboot cause file in
         /var/run/hwmanagement/system (which is defined as REBOOT_CAUSE_ROOT)
         If a reboot cause file doesn't exists, returns '0'.
         '''
@@ -754,7 +754,7 @@ class ModularChassis(Chassis):
         if index < count:
             if not self._module_list:
                 self._module_list = [None] * count
-            
+
             if not self._module_list[index]:
                 from .module import Module
                 self._module_list[index] = Module(index + 1)

platform/mellanox/mlnx-platform-api/tests/test_chassis.py

@@ -38,7 +38,7 @@ class TestChassis:
         2. Fan drawer related API
         3. SFP related API (Except modular chassis SFP related API)
         4. Reboot cause related API
-    
+
     Thermal, Eeprom, Watchdog, Component, System LED related API will be tested in seperate class
     """
     @classmethod
@@ -166,7 +166,6 @@ class TestChassis:
     @mock.patch('sonic_platform.sfp_event.sfp_event.check_sfp_status', MagicMock())
     @mock.patch('sonic_platform.sfp_event.sfp_event.__init__', MagicMock(return_value=None))
     @mock.patch('sonic_platform.sfp_event.sfp_event.initialize', MagicMock())
-    @mock.patch('sonic_platform.sfp.SFP.reinit', MagicMock())
     @mock.patch('sonic_platform.device_data.DeviceDataManager.get_sfp_count', MagicMock(return_value=3))
     def test_change_event(self):
         from sonic_platform.sfp_event import sfp_event
@@ -185,7 +184,6 @@ class TestChassis:
         assert status is True
         assert 'sfp' in event_dict and event_dict['sfp'][1] == '1'
         assert len(chassis._sfp_list) == 3
-        assert SFP.reinit.call_count == 1
 
         # Call get_change_event with timeout=1.0
         return_port_dict = {}

platform/mellanox/mlnx-platform-api/tests/test_sfp.py

@@ -49,7 +49,7 @@ class TestSfp:
         assert sfp.sdk_index == 1
         assert sfp.index == 5
 
-    @mock.patch('sonic_platform.sfp.SFP._read_eeprom_specific_bytes', mock.MagicMock(return_value=None))
+    @mock.patch('sonic_platform.sfp.SFP.read_eeprom', mock.MagicMock(return_value=None))
     @mock.patch('sonic_platform.sfp.SFP._get_error_code')
     @mock.patch('sonic_platform.chassis.Chassis.get_num_sfps', mock.MagicMock(return_value=2))
     def test_sfp_get_error_status(self, mock_get_error_code):