matthew/sonic-buildimage
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[Mellanox] Add N/A as a valid fan direction for Nvidia platforms (#17930)

Browse Source 
- Why I did it
On some Nvidia platforms, fan direction could not be determined. Therefore 'N/A' becomes a valid value for those cases.

- How I did it
Add 'N/A' to the valid fan direction mapping, to avoid an error in the log.

- How to verify it
Check fan direction on Nvidia platforms, and make sure there aren't errors in the log.
This commit is contained in:
Lahav-Nvidia 2024-02-22 11:35:10 +02:00 committed by GitHub
parent 2244aa2d7b
commit 8a7e38b3a3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
platform/mellanox/mlnx-platform-api/sonic_platform/fan.py
View File

@ -46,9 +46,11 @@ CONFIG_PATH = "/var/run/hw-management/config"
FAN_DIR = "/var/run/hw-management/thermal/fan{}_dir" FAN_DIR = "/var/run/hw-management/thermal/fan{}_dir"
FAN_DIR_VALUE_EXHAUST = 0 FAN_DIR_VALUE_EXHAUST = 0
FAN_DIR_VALUE_INTAKE = 1 FAN_DIR_VALUE_INTAKE = 1
FAN_DIR_VALUE_NOT_APPLICABLE = 2
FAN_DIR_MAPPING = { FAN_DIR_MAPPING = {
FAN_DIR_VALUE_EXHAUST: FanBase.FAN_DIRECTION_EXHAUST, FAN_DIR_VALUE_EXHAUST: FanBase.FAN_DIRECTION_EXHAUST,
FAN_DIR_VALUE_INTAKE: FanBase.FAN_DIRECTION_INTAKE, FAN_DIR_VALUE_INTAKE: FanBase.FAN_DIRECTION_INTAKE,
FAN_DIR_VALUE_NOT_APPLICABLE: FanBase.FAN_DIRECTION_NOT_APPLICABLE,
} }
class MlnxFan(FanBase): class MlnxFan(FanBase):
@ -170,7 +172,7 @@ class PsuFan(MlnxFan):
Retrieves the fan's direction Retrieves the fan's direction
Returns: Returns:
A string, either FAN_DIRECTION_INTAKE or FAN_DIRECTION_EXHAUST A string, either FAN_DIRECTION_INTAKE or FAN_DIRECTION_EXHAUST or FAN_DIRECTION_NOT_APPLICABLE
depending on fan direction depending on fan direction
Notes: Notes:
@ -181,6 +183,7 @@ class PsuFan(MlnxFan):
Air flow from QSFP side to fans side, for example: MSN2700-CS2R Air flow from QSFP side to fans side, for example: MSN2700-CS2R
which means exhaust in community which means exhaust in community
According to hw-mgmt: According to hw-mgmt:
2 stands for N/A, in case fan direction could not be determined
1 stands for forward, in other words intake 1 stands for forward, in other words intake
0 stands for reverse, in other words exhaust 0 stands for reverse, in other words exhaust
""" """
@ -275,7 +278,7 @@ class Fan(MlnxFan):
Retrieves the fan's direction Retrieves the fan's direction
Returns: Returns:
A string, either FAN_DIRECTION_INTAKE or FAN_DIRECTION_EXHAUST A string, either FAN_DIRECTION_INTAKE or FAN_DIRECTION_EXHAUST or FAN_DIRECTION_NOT_APPLICABLE
depending on fan direction depending on fan direction
Notes: Notes:
@ -286,6 +289,7 @@ class Fan(MlnxFan):
Air flow from QSFP side to fans side, for example: MSN2700-CS2R Air flow from QSFP side to fans side, for example: MSN2700-CS2R
which means exhaust in community which means exhaust in community
According to hw-mgmt: According to hw-mgmt:
2 stands for N/A, in case fan direction could not be determined
1 stands for forward, in other words intake 1 stands for forward, in other words intake
0 stands for reverse, in other words exhaust 0 stands for reverse, in other words exhaust
""" """