From 790974eaa0b2270904f39fa1b30b3bac73f5a2ab Mon Sep 17 00:00:00 2001 From: Ying Xie Date: Fri, 7 Dec 2018 23:05:02 -0800 Subject: [PATCH] [knet driver] don't unload knet drivers during shutdown (#2361) knet driver unload takes about 30 seconds to remove netdevs. This cuts into our warm reboot time budget. Signed-off-by: Ying Xie --- .../systemd/opennsl-modules-4.9.0-7-amd64.service | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/platform/broadcom/saibcm-modules/systemd/opennsl-modules-4.9.0-7-amd64.service b/platform/broadcom/saibcm-modules/systemd/opennsl-modules-4.9.0-7-amd64.service index 12c5ae40db..521326f01b 100644 --- a/platform/broadcom/saibcm-modules/systemd/opennsl-modules-4.9.0-7-amd64.service +++ b/platform/broadcom/saibcm-modules/systemd/opennsl-modules-4.9.0-7-amd64.service @@ -6,7 +6,12 @@ Before=syncd.service [Service] Type=oneshot ExecStart=-/etc/init.d/opennsl-modules-4.9.0-7-amd64 start -ExecStop=-/etc/init.d/opennsl-modules-4.9.0-7-amd64 stop +# Don't remove opennsl driver when stopping service. Because +# removing knet drivers takes ~30 seconds to delete netdevs. +# This delay cuts too deep into warm reboot time budget. +# We could skip this step because we don't expect stopping +# opennsl service in any context other than rebooting. +# ExecStop=-/etc/init.d/opennsl-modules-4.9.0-7-amd64 stop RemainAfterExit=yes [Install]