[voq-chassis][bgpcfg] VOQ_BGP_CHASSIS_NEIGHBORS timers default (#8455)

The BGP_VOQ_CHASSIS_NEIGHBOR keepalive and holdtime timers are
configured similar to general neighbors. Changes are done to configure
BGP_VOQ_CHASSIS_NEIGHBOR timers similar to BGP_INTENAL_NEIGBOR since voq
chassis bgp neighbors are similar to bgp internal neighbors in
multi-asic. As it is done for bgp internal neighbors, the keepalive and
holdtime timers are set to 3 and 10 seconds respectively. Also similar
to bgp internal neighbors, connection retry timer is also configured for
voq chassis bgp neighbors.

Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>

dockers/docker-fpm-frr/frr/bgpd/templates/voq_chassis/instance.conf.j2

@@ -7,11 +7,8 @@
   neighbor {{ neighbor_addr }} peer-group VOQ_CHASSIS_PEER
   neighbor {{ neighbor_addr }} remote-as {{ bgp_session['asn'] }}
   neighbor {{ neighbor_addr }} description {{ bgp_session['name'] }}
-{# set the bgp neighbor timers if they have not default values #}
-{% if     (bgp_session['keepalive'] is defined and bgp_session['keepalive'] | int != 60)
-      or  (bgp_session['holdtime'] is defined  and bgp_session['holdtime']  | int != 180) %}
-  neighbor {{ neighbor_addr }} timers {{ bgp_session['keepalive'] | default("60") }} {{ bgp_session['holdtime'] | default("180") }}
-{% endif %}
+  neighbor {{ neighbor_addr }} timers 3 10
+  neighbor {{ neighbor_addr }} timers connect 10
 !
 {% if 'admin_status' in bgp_session and bgp_session['admin_status'] == 'down' or 'admin_status' not in bgp_session and 'default_bgp_status' in CONFIG_DB__DEVICE_METADATA['localhost'] and CONFIG_DB__DEVICE_METADATA['localhost']['default_bgp_status'] == 'down' %}
   neighbor {{ neighbor_addr }} shutdown

src/sonic-bgpcfgd/tests/data/voq_chassis/instance.conf/result_all.conf

@@ -7,7 +7,8 @@
   neighbor 10.10.10.10 peer-group VOQ_CHASSIS_PEER
   neighbor 10.10.10.10 remote-as 555
   neighbor 10.10.10.10 description internal1
-  neighbor 10.10.10.10 timers 5 30
+  neighbor 10.10.10.10 timers 3 10
+  neighbor 10.10.10.10 timers connect 10
   neighbor 10.10.10.10 shutdown
   address-family ipv4
     maximum-paths ibgp 32

src/sonic-bgpcfgd/tests/data/voq_chassis/instance.conf/result_base.conf

@@ -7,6 +7,8 @@
   neighbor 10.10.10.10 peer-group VOQ_CHASSIS_PEER
   neighbor 10.10.10.10 remote-as 555
   neighbor 10.10.10.10 description internal1
+  neighbor 10.10.10.10 timers 3 10
+  neighbor 10.10.10.10 timers connect 10
   address-family ipv4
     maximum-paths ibgp 64
 !

src/sonic-bgpcfgd/tests/data/voq_chassis/instance.conf/result_shutdown_1.conf

@@ -7,6 +7,8 @@
   neighbor 10.10.10.10 peer-group VOQ_CHASSIS_PEER
   neighbor 10.10.10.10 remote-as 555
   neighbor 10.10.10.10 description internal1
+  neighbor 10.10.10.10 timers 3 10
+  neighbor 10.10.10.10 timers connect 10
   neighbor 10.10.10.10 shutdown
   address-family ipv4
     maximum-paths ibgp 64

src/sonic-bgpcfgd/tests/data/voq_chassis/instance.conf/result_shutdown_2.conf

@@ -7,6 +7,8 @@
   neighbor 10.10.10.10 peer-group VOQ_CHASSIS_PEER
   neighbor 10.10.10.10 remote-as 555
   neighbor 10.10.10.10 description internal1
+  neighbor 10.10.10.10 timers 3 10
+  neighbor 10.10.10.10 timers connect 10
   address-family ipv4
     maximum-paths ibgp 64
 !

src/sonic-bgpcfgd/tests/data/voq_chassis/instance.conf/result_timers_1.conf

@@ -7,7 +7,8 @@
   neighbor 10.10.10.10 peer-group VOQ_CHASSIS_PEER
   neighbor 10.10.10.10 remote-as 555
   neighbor 10.10.10.10 description internal1
-  neighbor 10.10.10.10 timers 5 180
+  neighbor 10.10.10.10 timers 3 10
+  neighbor 10.10.10.10 timers connect 10
   address-family ipv4
     maximum-paths ibgp 64
 !

src/sonic-bgpcfgd/tests/data/voq_chassis/instance.conf/result_timers_2.conf

@@ -7,7 +7,8 @@
   neighbor 10.10.10.10 peer-group VOQ_CHASSIS_PEER
   neighbor 10.10.10.10 remote-as 555
   neighbor 10.10.10.10 description internal1
-  neighbor 10.10.10.10 timers 60 240
+  neighbor 10.10.10.10 timers 3 10
+  neighbor 10.10.10.10 timers connect 10
   address-family ipv4
     maximum-paths ibgp 64
 !