matthew/sonic-buildimage
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Update ECN settings for storage backend (#12855)

Browse Source 
Signed-off-by: Neetha John <nejo@microsoft.com>

Why I did it
ECN parameters need to be updated for storage backend

How I did it
Included the check for storage backend devices to update qos configs

How to verify it
Verified that the new ecn settings are applied on storage backend device.
Verified that the old ecn settings are applied for storage frontend, non storage frontend/backend devices
This commit is contained in:
Neetha John 2022-11-29 10:19:06 -08:00 committed by Ying Xie
parent 465cd9db8b
commit 69343494dd
4 changed files with 50 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
device/common/profiles/td2/gen/BALANCED/qos.json.j2
View File

@ -1 +1,23 @@
{% if ('type' in DEVICE_METADATA['localhost'] and 'BackEnd' in DEVICE_METADATA['localhost']['type'] and 'storage_device' in DEVICE_METADATA['localhost'] and DEVICE_METADATA['localhost']['storage_device'] == 'true') %}
{%- macro generate_wred_profiles() %}
"WRED_PROFILE": {
"AZURE_LOSSLESS" : {
"wred_green_enable" : "true",
"wred_yellow_enable" : "true",
"wred_red_enable" : "true",
"ecn" : "ecn_all",
"green_max_threshold" : "12000144",
"green_min_threshold" : "1048576",
"yellow_max_threshold" : "2097152",
"yellow_min_threshold" : "1048576",
"red_max_threshold" : "2097152",
"red_min_threshold" : "1048576",
"green_drop_probability" : "5",
"yellow_drop_probability": "5",
"red_drop_probability" : "5"
}
},
{%- endmacro %}
{% endif %}
{%- include 'qos_config.j2' %} {%- include 'qos_config.j2' %}

22
device/common/profiles/td2/gen/RDMA-CENTRIC/qos.json.j2
View File

@ -1 +1,23 @@
{% if ('type' in DEVICE_METADATA['localhost'] and 'BackEnd' in DEVICE_METADATA['localhost']['type'] and 'storage_device' in DEVICE_METADATA['localhost'] and DEVICE_METADATA['localhost']['storage_device'] == 'true') %}
{%- macro generate_wred_profiles() %}
"WRED_PROFILE": {
"AZURE_LOSSLESS" : {
"wred_green_enable" : "true",
"wred_yellow_enable" : "true",
"wred_red_enable" : "true",
"ecn" : "ecn_all",
"green_max_threshold" : "12000144",
"green_min_threshold" : "1048576",
"yellow_max_threshold" : "2097152",
"yellow_min_threshold" : "1048576",
"red_max_threshold" : "2097152",
"red_min_threshold" : "1048576",
"green_drop_probability" : "5",
"yellow_drop_probability": "5",
"red_drop_probability" : "5"
}
},
{%- endmacro %}
{% endif %}
{%- include 'qos_config.j2' %} {%- include 'qos_config.j2' %}

5
src/sonic-config-engine/tests/sample-arista-7050-t0-minigraph.xml
View File

@ -924,6 +924,11 @@
<a:Reference i:nil="true"/> <a:Reference i:nil="true"/>
<a:Value>10.0.0.16</a:Value> <a:Value>10.0.0.16</a:Value>
</a:DeviceProperty> </a:DeviceProperty>
<a:DeviceProperty>
<a:Name>ResourceType</a:Name>
<a:Reference i:nil="true"/>
<a:Value>Storage</a:Value>
</a:DeviceProperty>
</a:Properties> </a:Properties>
</a:DeviceMetadata> </a:DeviceMetadata>
</Devices> </Devices>

2
src/sonic-config-engine/tests/sample_output/py3/qos-arista7050-t0-storage-backend.json
View File

@ -65,7 +65,7 @@
"wred_yellow_enable" : "true", "wred_yellow_enable" : "true",
"wred_red_enable" : "true", "wred_red_enable" : "true",
"ecn" : "ecn_all", "ecn" : "ecn_all",
"green_max_threshold" : "2097152", "green_max_threshold" : "12000144",
"green_min_threshold" : "1048576", "green_min_threshold" : "1048576",
"yellow_max_threshold" : "2097152", "yellow_max_threshold" : "2097152",
"yellow_min_threshold" : "1048576", "yellow_min_threshold" : "1048576",