matthew/sonic-buildimage
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Dell] S6100 - Update EEPROM API serial_number_str to return service tag instead of serial number (#17440) (#17493)

Browse Source 
To modify EEPROM API serial_number_str to return service tag instead of serial number in Dell S6100.
Ref PR: #1239

How I did it
Update EEPROM API serial_number_str to return service tag instead of serial number.

How to verify it
Verify decode-syseeprom -s returns service tag in Dell S6100.

Co-authored-by: Arun Saravanan Balachandran <52521751+ArunSaravananBalachandran@users.noreply.github.com>
This commit is contained in:
mssonicbld 2023-12-19 06:36:16 +08:00 committed by GitHub
parent b278f161a9
commit 5a4c51aaae
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/chassis.py
View File

@ -217,7 +217,7 @@ class Chassis(ChassisBase):
Returns:
string: Serial number of chassis
"""
return self._eeprom.serial_str()
return self._eeprom.serial_number_str()
def get_status(self):
"""

14
platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/eeprom.py
View File

@ -83,8 +83,14 @@ class Eeprom(eeprom_tlvinfo.TlvInfoDecoder):
self.eeprom_tlv_dict[mac_code] = '00:00:00:00:00:00'
def serial_number_str(self):
# For Chassis, return service tag instead of serial number
if not self.is_module:
(is_valid, results) = self.get_tlv_field(
self.eeprom_data, self._TLV_CODE_SERVICE_TAG)
else:
(is_valid, results) = self.get_tlv_field(
self.eeprom_data, self._TLV_CODE_SERIAL_NUMBER)
if not is_valid:
return "N/A"
@ -118,14 +124,6 @@ class Eeprom(eeprom_tlvinfo.TlvInfoDecoder):
return results[2].decode('ascii')
def serial_str(self):
(is_valid, results) = self.get_tlv_field(
self.eeprom_data, self._TLV_CODE_SERVICE_TAG)
if not is_valid:
return "N/A"
return results[2].decode('ascii')
def revision_str(self):
(is_valid, results) = self.get_tlv_field(
self.eeprom_data, self._TLV_CODE_LABEL_REVISION)

2
platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/module.py
View File

@ -139,7 +139,7 @@ class Module(ModuleBase):
Returns:
string: Serial number of module
"""
return self._eeprom.serial_str()
return self._eeprom.serial_number_str()
def get_status(self):
"""