matthew/sonic-buildimage
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Check fan speed before check fan status (#6586)

Browse Source 
**- Why I did it**
In thermalctd, when speed of fan exceeds threshold, the fan status will be saved as "bad". So in system health, it is better to check fan speed before fan status. In this case, if fan speed exceeds threshold, we get more detailed information.

**- How I did it**
Move fan speed check logic before fan status check

**- How to verify it**
Manual test
This commit is contained in:
Junchao-Mellanox 2021-01-31 15:06:36 +08:00 committed by GitHub
parent c041d25f92
commit 2a0351c65c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/system-health/health_checker/hardware_checker.py
View File

@ -89,11 +89,6 @@ class HardwareChecker(HealthChecker):
self.set_object_not_ok('Fan', name, '{} is missing'.format(name))
continue
status = data_dict.get('status', 'false')
if status.lower() != 'true':
self.set_object_not_ok('Fan', name, '{} is broken'.format(name))
continue
if not self._ignore_check(config.ignore_devices, 'fan', name, 'speed'):
speed = data_dict.get('speed', None)
speed_target = data_dict.get('speed_target', None)
@ -130,6 +125,11 @@ class HardwareChecker(HealthChecker):
speed_tolerance))
continue
status = data_dict.get('status', 'false')
if status.lower() != 'true':
self.set_object_not_ok('Fan', name, '{} is broken'.format(name))
continue
self.set_object_ok('Fan', name)
def _check_psu_status(self, config):