2017-01-29 13:33:33 -06:00
|
|
|
[Unit]
|
|
|
|
|
Description=SNMP container
|
2018-06-22 21:53:51 -05:00
|
|
|
Requires=updategraph.service swss.service enable_counters.service
|
|
|
|
|
After=updategraph.service swss.service enable_counters.service
|
2017-01-29 13:33:33 -06:00
|
|
|
|
|
|
|
|
[Service]
|
[oneimage]: Fix race condition in systemd container services (#421)
When Type=simple, systemd will consider the service activated immediately
after specified in ExecStart process is started. If there is downstream
service depending on the state prepared in ExecStart, there will be race condition.
For example, issue #390. In this case, database.service calls database.sh, which
calls docker run or docker start -a to start database container. However, systemd
considers database.service successfully started at the time database.sh begins,
not after docker run finishes. As database.service is consider started, bgp.service
can be started. The redis database, which bgp service depends on, might or might not
have been started at this time point.
To fix this issue (and still keeping the functionality to monitor docker status with
systemd), we split the ExecStart process into an ExecStartPre part and an ExecStart
part. docker run is splitted into docker run -d then docker attach , while docker start
-a is splitted into docker start and then docker attach. In this way, we make sure
the downstream services are blocked until container is successfully started.
2017-03-22 15:04:48 -05:00
|
|
|
ExecStartPre=/usr/bin/{{docker_container_name}}.sh start
|
|
|
|
|
ExecStart=/usr/bin/{{docker_container_name}}.sh attach
|
2017-01-29 13:33:33 -06:00
|
|
|
ExecStop=/usr/bin/{{docker_container_name}}.sh stop
|
