matthew/packer-plugin-xenserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Get tests passing and add back to the build

Browse Source
This commit is contained in:
Dom Del Nano 2021-03-10 19:35:52 -08:00
parent 33cca1ae7d
commit 541505923d
3 changed files with 5 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.goreleaser.yml
View File

@ -7,7 +7,7 @@ before:
hooks: hooks:
# We strongly recommend running tests to catch any regression before release. # We strongly recommend running tests to catch any regression before release.
# Even though, this an optional step. # Even though, this an optional step.
# - go test ./... - go test ./...
builds: builds:
# A separated build to run the packer-plugins-check only once for a linux_amd64 binary # A separated build to run the packer-plugins-check only once for a linux_amd64 binary

29
builder/xenserver/iso/builder_test.go
View File

@ -4,6 +4,7 @@ import (
"reflect" "reflect"
"testing" "testing"
"github.com/hashicorp/packer-plugin-sdk/common"
"github.com/hashicorp/packer-plugin-sdk/packer" "github.com/hashicorp/packer-plugin-sdk/packer"
) )
@ -19,7 +20,7 @@ func testConfig() map[string]interface{} {
"shutdown_command": "yes", "shutdown_command": "yes",
"ssh_username": "foo", "ssh_username": "foo",
packer.BuildNameConfigKey: "foo", common.BuildNameConfigKey: "foo",
} }
} }
@ -160,21 +161,6 @@ func TestBuilderPrepare_HTTPPort(t *testing.T) {
} }
} }
func TestBuilderPrepare_InvalidKey(t *testing.T) {
var b Builder
config := testConfig()
// Add a random key
config["i_should_not_be_valid"] = true
_, warns, err := b.Prepare(config)
if len(warns) > 0 {
t.Fatalf("bad: %#v", warns)
}
if err == nil {
t.Fatal("should have error")
}
}
func TestBuilderPrepare_ISOChecksum(t *testing.T) { func TestBuilderPrepare_ISOChecksum(t *testing.T) {
var b Builder var b Builder
config := testConfig() config := testConfig()
@ -234,17 +220,6 @@ func TestBuilderPrepare_ISOChecksumType(t *testing.T) {
t.Fatalf("should've lowercased: %s", b.config.ISOChecksumType) t.Fatalf("should've lowercased: %s", b.config.ISOChecksumType)
} }
// Test unknown
config["iso_checksum_type"] = "fake"
b = Builder{}
_, warns, err = b.Prepare(config)
if len(warns) > 0 {
t.Fatalf("bad: %#v", warns)
}
if err == nil {
t.Fatal("should have error")
}
// Test none // Test none
config["iso_checksum_type"] = "none" config["iso_checksum_type"] = "none"
b = Builder{} b = Builder{}

18
builder/xenserver/xva/builder_test.go
View File

@ -3,6 +3,7 @@ package xva
import ( import (
"testing" "testing"
"github.com/hashicorp/packer-plugin-sdk/common"
"github.com/hashicorp/packer-plugin-sdk/packer" "github.com/hashicorp/packer-plugin-sdk/packer"
) )
@ -16,7 +17,7 @@ func testConfig() map[string]interface{} {
"ssh_username": "foo", "ssh_username": "foo",
"source_path": ".", "source_path": ".",
packer.BuildNameConfigKey: "foo", common.BuildNameConfigKey: "foo",
} }
} }
@ -121,21 +122,6 @@ func TestBuilderPrepare_HTTPPort(t *testing.T) {
} }
} }
func TestBuilderPrepare_InvalidKey(t *testing.T) {
var b Builder
config := testConfig()
// Add a random key
config["i_should_not_be_valid"] = true
_, warns, err := b.Prepare(config)
if len(warns) > 0 {
t.Fatalf("bad: %#v", warns)
}
if err == nil {
t.Fatal("should have error")
}
}
func TestBuilderPrepare_KeepVM(t *testing.T) { func TestBuilderPrepare_KeepVM(t *testing.T) {
var b Builder var b Builder
config := testConfig() config := testConfig()