Ensure required LockingMode parameter is set on VIF and fail the packer build if vif is failed to be created

builder/xenserver/common/client.go

@@ -609,22 +609,17 @@ func (self *VM) SetPlatform(params map[string]string) (err error) {
 }
 
 func ConnectNetwork(c *Connection, networkRef xenapi.NetworkRef, vmRef xenapi.VMRef, device string) (*xenapi.VIFRef, error) {
-	// Create the VIF
-	// vif_rec["other_config"] = make(xmlrpc.Struct)
-	// vif_rec["qos_algorithm_params"] = make(xmlrpc.Struct)
-
 	vif, err := c.client.VIF.Create(c.session, xenapi.VIFRecord{
-		Network:          networkRef,
-		VM:               vmRef,
-		MAC:              "",
-		Device:           device,
-		MTU:              1504,
-		QosAlgorithmType: "",
+		Network:     networkRef,
+		VM:          vmRef,
+		Device:      device,
+		LockingMode: xenapi.VifLockingModeNetworkDefault,
 	})
 
 	if err != nil {
 		return nil, err
 	}
+	log.Printf("Created the following VIF: %s", vif)
 
 	return &vif, nil
 }

builder/xenserver/iso/step_create_instance.go

@@ -170,7 +170,8 @@ func (self *stepCreateInstance) Run(state multistep.StateBag) multistep.StepActi
 		_, err = xscommon.ConnectNetwork(c, network, instance, "0")
 
 		if err != nil {
-			ui.Say(err.Error())
+			ui.Error(fmt.Sprintf("Failed to create VIF with error: %v", err))
+			return multistep.ActionHalt
 		}
 
 	} else {