c70811eaa4
The problem happens for bidirectional flows. The sequence of events is as follows when you start Tx on Ports p1, p2 with the current code - 1. Clear stream stats on p1 2. Start tx on p1 3. Clear stream stats on p2 4. Start tx on p2 By the time #3 is executed, it may have already rx packets from p1 which are being incorrectly cleared, this will cause these number of packets to show up as dropped instead - incorrectly. The fix is to change the order like this - 1. Clear stream stats on p1 2. Clear stream stats on p2 3. Start tx on p1 4. Start tx on p2 Unidirectional flows will not see this problem - as long as startTx is done only on the Tx port and not the Rx port. This bug is a regression caused due to the code changes introduced for the stream stats rates feature implemented in 1.2.0
59 lines
1.3 KiB
C++
59 lines
1.3 KiB
C++
/*
|
|
Copyright (C) 2016 Srivats P.
|
|
|
|
This file is part of "Ostinato"
|
|
|
|
This is free software: you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation, either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>
|
|
*/
|
|
|
|
#ifndef _PCAP_RX_STATS_H
|
|
#define _PCAP_RX_STATS_H
|
|
|
|
#include "streamstats.h"
|
|
|
|
#include "pcapsession.h"
|
|
|
|
class PcapRxStats: public PcapSession
|
|
{
|
|
public:
|
|
PcapRxStats(const char *device, StreamStats &portStreamStats, int id);
|
|
pcap_t* handle();
|
|
void run();
|
|
bool start();
|
|
bool stop();
|
|
bool isRunning();
|
|
bool isDirectional();
|
|
|
|
QString debugStats();
|
|
|
|
private:
|
|
enum State {
|
|
kNotStarted,
|
|
kRunning,
|
|
kFinished
|
|
};
|
|
|
|
QString device_;
|
|
StreamStats &streamStats_;
|
|
volatile bool stop_;
|
|
pcap_t *handle_;
|
|
volatile State state_;
|
|
bool isDirectional_;
|
|
|
|
int id_;
|
|
struct pcap_stat lastPcapStats_;
|
|
};
|
|
|
|
#endif
|