Srivats P
ebccc44cdf
Reformat TxThread/run {} to use less vertical space
2023-03-08 18:14:45 +05:30
Srivats P
f3a9b507b0
Update comments about implict packetset
2023-03-08 18:10:09 +05:30
Srivats P
c70811eaa4
Fix spurious stream stats drops
...
The problem happens for bidirectional flows. The sequence of events is
as follows when you start Tx on Ports p1, p2 with the current code -
1. Clear stream stats on p1
2. Start tx on p1
3. Clear stream stats on p2
4. Start tx on p2
By the time #3 is executed, it may have already rx packets from p1 which
are being incorrectly cleared, this will cause these number of packets
to show up as dropped instead - incorrectly.
The fix is to change the order like this -
1. Clear stream stats on p1
2. Clear stream stats on p2
3. Start tx on p1
4. Start tx on p2
Unidirectional flows will not see this problem - as long as startTx is
done only on the Tx port and not the Rx port.
This bug is a regression caused due to the code changes introduced for the
stream stats rates feature implemented in 1.2.0
2023-02-08 16:34:03 +05:30
Srivats P
701a058c7d
Merge commit 'refs/subrepo/ostinato/fetch' into subrepo/ostinato
...
Update from master repo into turbo
2022-06-27 14:35:22 +05:30
Srivats P
843733567a
Reoganize code using subrepo for Ostinato (part 2)
...
This commit includes all the new and modified files
2022-06-27 13:43:46 +05:30
Srivats P
fb879d2c72
Return txDuration as 0 for ports with no streams
2022-06-21 18:51:42 +05:30
Srivats P
329469dd6e
Calculate port tx duration and send to controller
...
This commit only includes server side changes plus the .proto changes.
Client side UI changes are still pending.
2022-02-21 22:20:59 +05:30
Srivats P
f7ace4c5c2
Name threads for easier debugging
2020-05-15 18:55:03 +05:30
Srivats P
016694f1fe
Use %ll instead of PRI since Windows dev env has been upgraded
2018-05-20 13:33:38 +05:30
Srivats P
35c56b9181
sign: Calculate stream stats only if configured
...
Stream Stats Rx and Tx both are calculated only if 'Track Stream Stats'
is configured on the port
2016-12-06 21:41:47 +05:30
Srivats P
de503d8d96
sign: Fix crash when doing TX on a streamless port
...
Ensure packetListSize_ is non zero to avoid division by zero. Also reset
packetListSize_ to 0 in the constructor - call clearPacketList() to do
this
2016-11-29 18:20:00 +05:30
Srivats P
b622cc8e72
sign: add #define and #include for PRIu64
2016-11-27 13:35:59 +05:30
Srivats P
4f8ee757b3
sign: print Tx stream stats related vars for debug
2016-11-27 12:35:33 +05:30
Srivats P
defdc218bd
sign: fix the tx stream stats calculation and update associated test case
2016-11-15 22:23:55 +05:30
Srivats P
f8575ef101
sign: post tx stream stats collection; testing pending
2016-11-13 19:11:24 +05:30
Srivats P
afcb4126b5
sign: port stream tx stats are updated when TxThread finishes; actual Tx stream stats collection by TxThread is still pending
2016-11-11 21:22:07 +05:30
Srivats P
31c2cd2dcb
sign: refactored tx stats into a new PcapTxStats class
2016-10-19 18:52:35 +05:30
Srivats P
12351d6304
sign: Refactored PortTransmitter into PcapTransmitter and PcapTxThread classes. Also broke out PacketSequence and Timestamp stuff into their own files. No change in functionality.
2016-09-13 19:05:24 +05:30
