- Queued RPC calls would cause crashes due to invalid pointers to request/response and/or controller; this has been fixed
- PbRpcController now takes ownership of request and response messages and
will delete them when it itself is being deleted
- This design mandates that request and response messages for each RPC call
have to be allocated on the heap.
- The convention for the Closure 'done' call now is to allocate and pass a
pointer to the controller object to it which will delete it after use;
this requires that controller itself be also allocated on the heap
(NOTE: this is just a convention - not mandatory)
- All existing RPC calls (in portgroup.cpp) have been changed to follow the
above convention
- Reordering of queued RPC calls has been fixed
- PortManager is now destroyed at exit; because of this fix the per port temporary capture files are auto-removed at exit
- WinPcapPort destructor no longer deletes the monitor threads because the parent class PcapPort already does it
- Capture does not automatically (and incorrectly) stop after one packet if started immediately after a View Capture operation
- User is prompted to stop transmit on a port first if he tries to apply configuration changes on a port in 'transmit' state
- Ostinato Client
- will start the server as a child process at startup and terminate it at exit
- Ostinato Server (Drone)
- is now a system tray application
- if not able to bind to a IP/Port successfully, informs the user and exits
- the GUI is now nothing more than a TextLabel
Others
- If a getStats() request is pending, the client will not queue up any more requests till a reply is received for the pending one
- Nitpicks in the Payload protocol Widget, PortsWindow Widget
- Added support for retrieving the packet capture buffer from server to client (does not work consistently however - needs investigation)
- getCaptureBuffer() Rpc signature changed
- RPC: Added support in Rpc Channel (client) to queue calls
- RPC: Added support for transferring arbitrary binary data from server to client (used to get packet capture files)
- Rpc header changed - length is now 4 bytes instead of 2; there is no rsvd field any longer
Fixes
- RPC: Fix for the case when a msg is not received all at once over the socket
- StreamConfigDialog: fixed display issue in packet view for combo protocols containing meta fields
- Fixed issue with Stacked Vlan not retaining data for both CVlan and SVlan
- Fixed incorrect payload size issue with increment/decrement frame length modes
Refactoring, Cleanup etc.
- RPC: Minor code and TODOs cleanup
- Server: Minor code and TODOs cleanup
- Server: Removed unused file(s): rxtx.cpp, rxtx.h
- Server: Replaced direct use of ProtocolList with the ProtocolListIterator
- Common: Minor code and TODOs cleanup
- StreamBase::frameLen() now returns the length based on the mode/min/max and the passed in streamIndex
- AbstractProtocol interface changed for methods - protocolFrameSize(), protocolFrameOffset(), protocolFramePayloadSize() : all of them now take streamIndex as an optional param with 0 as the default value
- Protocols implementing the above methods changed accordingly
