Commit Graph

7 Commits

Author SHA1 Message Date
Srivats P
ad38a60171 Fix valid count range for variable fields
To allow full range of a field, the "count" of a variable field,
 * Minimum should be 1, not 0
 * Maximum should be max value of field + 1

Fixes #301
2020-05-04 19:15:49 +05:30
Srivats P
52a5cb0d30 Improve UX for variable fields configuration
* Redesign the toolbar buttons to be similar to port stats
* Show protocols with variable fields in bold
* Variable field list will always have a 'current', if not empty
* Adding a new variable field makes it 'current' for immediate edit
* Each protocol remembers its 'current' variable field

Also renamed UserRole to a more widget specific enum
2018-02-10 12:40:10 +05:30
Srivats P
d370907597 Fix max value of step/count for counter32 var fields 2018-02-07 20:45:43 +05:30
Srivats P.
384fd6e172 Feature (contd.): Variable Fields - fixed errors and warnings reported by gcc4 in the code added for this feature 2015-06-01 19:05:43 +05:30
Srivats P.
22d35f8a41 Feature (contd.): Variable Fields - fixed bug where the correct validation/masks were not setup when adding a new VF or switching between protocols 2015-05-31 21:21:46 +05:30
Srivats P.
022fac534c Feature (contd.): Variable Fields - fixed 2nd protocol of combo protocols not being listed and offset/mask not being calculated correctly for them via the GUI 2015-05-31 20:47:25 +05:30
Srivats P.
df24cf8b15 Feature: Variable Fields - any field of any protocol can now be varied by specifying it as a generic 8/16/32 bit field at a specified offset (relative to the protocol frame value) with a certain mask and a (initial) value alongwith count and step; this is working code - but incomplete. Bunch of FIXME/TODOs and testing pending 2015-05-26 21:43:37 +05:30