Commit Graph

853 Commits

Author SHA1 Message Date
Srivats P
5f82912f91 sign: Rename Aggr to Total in Stream Stats Window 2017-01-23 18:26:35 +05:30
Srivats P
287316b473 sign: Show streamStats byte stats only if user wants
By default stream stats window only shows packet counters, user can
toggle display of byte counters using context menu
2017-01-13 19:02:25 +05:30
Srivats P
5e30d8672f sign: Change colors of Stream Stats Window 2017-01-11 20:36:38 +05:30
Srivats P
2bad2f3384 sign: Add AggrGUID row in Stream Stats Window 2017-01-10 21:43:58 +05:30
Srivats P
c702d7692b sign: Rename aggrStreamStats as aggrGuidStats
New name reflects actual usage; aggrPortStats can be added later.
2017-01-10 18:50:22 +05:30
Srivats P
5120f6c525 sign: Highlight non-zero aggr pkt loss in red 2017-01-10 18:13:14 +05:30
Srivats P
0bf2e99931 Fix travis for OSX builds 2017-01-09 20:02:03 +05:30
Srivats P
13e28cff68 sign: Fix Tx stream stats counted as Rx on some platforms
On platforms that don't support filtering IN/OUT using
pcap_setdirection() - e.g. Windows, adjust Rx stats appropriately
2017-01-09 18:57:38 +05:30
Srivats P
063c607847 sign: Expand getStreamStatsDict() documentation 2017-01-05 20:26:21 +05:30
Srivats P
33ad1abb1e Make osx_image global 2017-01-04 18:21:07 +05:30
Srivats P
d90a99f052 include not exclude the osx image 2017-01-03 22:21:02 +05:30
Srivats P
4038ca84bd Fix osx_image location again 2017-01-03 21:36:46 +05:30
Srivats P
232dfdb0bc Fix incorrect location of overriding osx_image 2017-01-03 21:16:15 +05:30
Srivats P
00a487cb6f Force sierra instead of el-capitan
See https://github.com/cartr/homebrew-qt4/issues/7
2017-01-03 20:58:09 +05:30
Srivats P
33c39b8e24 Troubleshoot osx build break changeset #4 2017-01-03 20:37:26 +05:30
Srivats P
8d168099fb Troubleshoot Travis OSX build break changeset #3 2017-01-03 19:03:56 +05:30
Srivats P
ae149d0263 troubleshoot osx build break - changeset #2 2017-01-03 18:24:51 +05:30
Srivats P
2626339679 debug changes to troubleshoot osx build break 2017-01-03 18:11:46 +05:30
Srivats P
f3423b7d84 Use latest protobuf version in HomeBrew
We had reverted to using protobuf 2.6 when protobuf 3.0 had a regression
issue with respect to RPCs - this has been fixed in v3.1.0
2017-01-01 12:49:57 +05:30
Srivats P
416292e42b sign: Improve StreamStatsWindow UX with colors 2017-01-01 12:12:10 +05:30
Srivats P
ff01ef9682 sign: Add Aggregate Stats to Stream Stats Model 2016-12-27 20:20:36 +05:30
Srivats P
cfa7d80f7b Convert stream preflight checks to bullet points 2016-12-10 13:50:52 +05:30
Srivats P
a838d09fbd sign: Inform user when stream stats is not enabled
If Sign protocol is configured without enabling stream statistics on
port, inform user that stream statistics will not be available till
it is enabled on port
2016-12-10 13:40:28 +05:30
Srivats P
ac1356ed53 Optimize stream preflight check for performance
Loop only once for all packets of the stream
2016-12-09 18:48:08 +05:30
Srivats P
ba06b88329 sign: Reorder Tx/Rx columns in StreamStats Window 2016-12-09 18:12:06 +05:30
Srivats P
9cd26567cd sign: Fix filter in test script for GUID > 255 2016-12-08 21:26:09 +05:30
Srivats P
72521f782e sign: Clear ARP/NDP cache & ping before tx in test script
This helps setting ARP/NDP such that they do not expire during tx for
unidirectional flows
2016-12-08 20:59:51 +05:30
Srivats P
58a16a253e sign: Filter out ICMP packets with sign in test script
A limitation of the current design where the sign protocol appears at
the end of frame is that such a data packet could potentially trigger a
ICMP error containing this packet as payload and for small size packets
this ICMP packet itself will appear as a 'sign' packet - so filter out
ICMP from the captured packets when verifying against stream stats
2016-12-08 20:54:38 +05:30
Srivats P
8f97a69220 sign: Refactor StreamStatsTracking methods
Start/StopStreamStatsTracking() methods made private helper functions
specific to PcapPort. AbstractPort::setStreamStatsTracking() virtual
function should be implemented by subclasses as required
2016-12-07 18:19:09 +05:30
Srivats P
35c56b9181 sign: Calculate stream stats only if configured
Stream Stats Rx and Tx both are calculated only if 'Track Stream Stats'
is configured on the port
2016-12-06 21:41:47 +05:30
Srivats P
028843c55a sign: Refactor AbstractPort::setStreamSatsTracking
Move start/stop stream stats tracking inside setStreamStatsTracking. In
future, maybe convert setStreamStatsTracking to virtual function?
2016-12-06 18:30:26 +05:30
Srivats P
387e6700cd sign: Add Sign to Stream Protocol Selection Widget
Added a Special Group (for sign), a Trailer Group and reorganized the
layout of the widget to fit these new groups. Added supporting code for
the Sign Protocol and the Trailer group
2016-12-03 14:00:47 +05:30
Srivats P
de6a139cd7 Set L5 Proto as Other, if L4 Proto is Other
This should have been done when L5 was introduced but got missed out I
guess.
2016-12-02 18:49:25 +05:30
Srivats P
de503d8d96 sign: Fix crash when doing TX on a streamless port
Ensure packetListSize_ is non zero to avoid division by zero. Also reset
packetListSize_ to 0 in the constructor - call clearPacketList() to do
this
2016-11-29 18:20:00 +05:30
Srivats P
eed4f8eb1d sign: Clear Port+Stream Stats on Clear(All) click
Although the RPC API provides separate APIs for clearing Port and Stream
Stats, typical use case would be to clear both together
2016-11-28 20:19:17 +05:30
Srivats P
b622cc8e72 sign: add #define and #include for PRIu64 2016-11-27 13:35:59 +05:30
Srivats P
65f0a7168c sign: Replace Stream Stats icon with a better one 2016-11-27 13:16:10 +05:30
Srivats P
8fa9ac2295 sign: Restore Defaults - Stream Stats docks as tabs 2016-11-27 13:07:06 +05:30
Srivats P
3d7a459b5f sign: Open StreamStats as a Tabbed widget
PortStats and StreamStats Windows are presented as a tabbed widget.
Multiple StreamStats windows are titled to include an id to hint at the
sequence in which they were opened
2016-11-27 12:39:37 +05:30
Srivats P
4f8ee757b3 sign: print Tx stream stats related vars for debug 2016-11-27 12:35:33 +05:30
Srivats P
70cc101b64 sign: Stream Stats Window display enhancements
Use right align and thousands' separator for numbers; reduce table row
height to match port stats window
2016-11-27 11:56:18 +05:30
Srivats P
a6274e559e sign: Delete streamStats docks before saving state
Although streamStats docks are set to delete on close, this doesn't
happen immediately, so save layout state still sees them which leads
to a crash next time when application is started, state is restored and
docks are moved - so instead of close, delete them directly
2016-11-27 11:45:15 +05:30
Srivats P
60be43006f sign: StreamStatsModel is now a nice table 2016-11-26 13:37:36 +05:30
Srivats P
fda7807797 sign: GUI code for fetch/display of stream stats 2016-11-24 21:44:38 +05:30
Srivats P
bf161811b4 sign: Add Stream Stats button to GUI port config 2016-11-21 18:39:55 +05:30
Srivats P
b1e960b858 sign: refactored the stream stats test; new problem discovered if the data stream is appended to an ICMP error packet sent by the DUT we will count the ICMP packet as a signed packet as well 2016-11-20 22:03:30 +05:30
Srivats P
7366e5d2e6 sign: fix yet another build break 2016-11-18 21:29:45 +05:30
Srivats P
b4beda7c30 sign: NOCAPTURE_LOCAL is not reqd since we don't tx on this handle 2016-11-18 21:12:56 +05:30
Srivats P
e7ed15fc89 sign: fix loopback problem (tx pkts rcvd by rxstats thread) on non-Windows platforms 2016-11-18 20:57:50 +05:30
Srivats P
c45bbdaa10 sign: fix non-Windows build break 2016-11-18 20:51:30 +05:30