- Server now updates the "packet list" after every "apply" rather than before a "start transmit" (if dirty) - this better reflects user's expectation from these operations
- Client disables the entire application and changes to a "Busy" cursor when "applying" stream configuration
Fixes
- UDP checksum no longer is zero but a valid value
- Order of streams no longer gets messed up across a "apply"
---------------------------------
- StreamConfigDialog: Valid subsequent protocol choices for a particular protocol in the simple protocol selection widget is no longer hardcoded - ProtocolManager is queried for validitity of each pair of possible protocols; signal-slot connections are made accordingly. This refactoring makes it easier to add a protocol to the simple protocol selection widget
- ProtocolManager: populates and maintains a database of valid 'neighbour protocols' and implements a method - isValidNeighbour() to query the same for a pair of protocols
- AbstractProtocol: new method protocolIdType() introduced to build the above database (in conjunction with the existing method protocolId(ProtocolIdType)); default implementation returns ProtocolIdNone
- Protocols which include a valid/supported ProtocolIdType (eth/llc/ip) reimplement protocolIdType() to return the apporpirate ProtocolIdType. These are viz.
- combo
- eth
- llc
- snap
- ip
- Speed optimization while populating streamqueues if the protocolFrameValue/Size() does not vary across packets
- AbstractProtocol: new methods to support the above optimization
- isProtocolFrameValueVariable()
- isProtocolFrameSizeVariable()
- isProtocolFramePayloadValueVariable()
- isProtocolFramePayloadSizeVariable()
(each of the default implementations returns false indicating that the protocol frame value or frame size is fixed and not variable)
- Protocols which support variable values/size (list follows) reimplement the above methods appropriately
- combo
- mac
- dot3
- ip4
- tcp
- udp
- payload
- StreamInfo::makePacket() moved to base class as StreamBase::frameValue()
- StreamBase: all 'get' accessor functions made 'const'
- class ProtocolManager: while registering a protocol, no need to pass the protocol name; ProtocolManager finds it out internally by using the protocol's shortName() method
Fixes
-----
- Fixed issue with port capture not starting the first time 'start capture' was clicked
- Added support for retrieving the packet capture buffer from server to client (does not work consistently however - needs investigation)
- getCaptureBuffer() Rpc signature changed
- RPC: Added support in Rpc Channel (client) to queue calls
- RPC: Added support for transferring arbitrary binary data from server to client (used to get packet capture files)
- Rpc header changed - length is now 4 bytes instead of 2; there is no rsvd field any longer
Fixes
- RPC: Fix for the case when a msg is not received all at once over the socket
- StreamConfigDialog: fixed display issue in packet view for combo protocols containing meta fields
- Fixed issue with Stacked Vlan not retaining data for both CVlan and SVlan
- Fixed incorrect payload size issue with increment/decrement frame length modes
Refactoring, Cleanup etc.
- RPC: Minor code and TODOs cleanup
- Server: Minor code and TODOs cleanup
- Server: Removed unused file(s): rxtx.cpp, rxtx.h
- Server: Replaced direct use of ProtocolList with the ProtocolListIterator
- Common: Minor code and TODOs cleanup
- StreamBase::frameLen() now returns the length based on the mode/min/max and the passed in streamIndex
- AbstractProtocol interface changed for methods - protocolFrameSize(), protocolFrameOffset(), protocolFramePayloadSize() : all of them now take streamIndex as an optional param with 0 as the default value
- Protocols implementing the above methods changed accordingly
Common
------
- Change in OstProto
- Individual protocols are now extensions of (new) message 'Protocol' instead of 'Stream'
- Stream now contains a repeated Protocol which also determines the ordered set of currently selected protocols; StreamCore.frame_proto which was doing this earlier has been removed
- Change in AbstractProtocol Interface
- Parent changed to StreamBase
- Corresponding change in constructor and factory func - createInstance()
- new method protocolNumber() - returns unique id for each protocol
- protoDataCopyInto/From() now copies into OstProto::Protocol instead of OstProto::Stream
- Change in all subclasses of AbstractProtocol to match new interface
- For all protocols, configFrom is no longer static, but each protocol has its own configForm
- configForm creation is lazy
- configForm is still a child of the protocol i.e. it will be destroyed alongwith the protocol
- TODO: convert configWidget() to a pure factory function i.e. the protocol does not own the configForm - this requires us to pass the widget into load/storeConfigWidget() methods
- ProtocolCollection class removed alongwith its .h and .cpp
- ProtocolList class redefined to serve the purpose of ProtocolCollection
- New class ProtocolListIterator defined to iterate ProtocolList
- AbstractProtocol methods now use the ProtocolListIterator
- Factory function createProtocol() added to ProtocolManager
- OstProto::StreamCore accessor functions moved from Stream to StreamBase
Server
------
- MyService uses the newly moved accessors to StreamBase for OstProto::StreamCore members
- StreamInfo now uses the protocols to create the packet
Client
------
- StreamConfigDialog now uses ProtocolListIterator
- So does PacketModel
- New Classes:
o ProtocolManager - singleton with which all protocols register
o ProtocolCollection - Aggregates all registered protocols; exports methods to work on all protocols
o StreamBase - aggregates ProtocolCollection with Stream Core and Control; the client/server side stream classes now derive from StreamBase leading to major reduction in their code (more cleanup pending)
- AbstractProtocol now supports the additional methods
o createInstance()
o protocolFrameSize()
o protocolFrameOffset(), protocolFramePayloadSize()
o protocolId(), payloadProtocolId()
o protocolFrameCksum(), protocolFramePayloadCksum()
0 constructor takes an extra param - frameProtoList
- Specific protocols - eth2, llc, snap, ip4, udp, tcp now return length, protocol id and cksums correctly (tcp/udp cksum pending)
- StreamConfigDialog - protocol controls for length, cksum and protocolid are automatically updated (not fully working yet)
