- Queued RPC calls would cause crashes due to invalid pointers to request/response and/or controller; this has been fixed
- PbRpcController now takes ownership of request and response messages and
will delete them when it itself is being deleted
- This design mandates that request and response messages for each RPC call
have to be allocated on the heap.
- The convention for the Closure 'done' call now is to allocate and pass a
pointer to the controller object to it which will delete it after use;
this requires that controller itself be also allocated on the heap
(NOTE: this is just a convention - not mandatory)
- All existing RPC calls (in portgroup.cpp) have been changed to follow the
above convention
- Reordering of queued RPC calls has been fixed
- PortManager is now destroyed at exit; because of this fix the per port temporary capture files are auto-removed at exit
- WinPcapPort destructor no longer deletes the monitor threads because the parent class PcapPort already does it
- Capture does not automatically (and incorrectly) stop after one packet if started immediately after a View Capture operation
- User is prompted to stop transmit on a port first if he tries to apply configuration changes on a port in 'transmit' state
- OstProto service has a new method "modifyPort()"
- At port init port.isExclusive is now set using a bindconfig query (Win32 only)
- AbstractPort interface has 2 new pure virtual methods - hasExclusiveControl() and setExclusiveControl()
- PcapPort does not support this functionality (yet) so these methods return false
- WinPcapPort suppots this new functionality using bindconfig
- Port's notes (specifying Rx/Tx limitations) are now set and updated based on hasExclusiveControl()
- Presence of 'notes' on a port is indicated using a '*' after the port name in the port stats window
- The tabwidget has been removed from Port Window | Stream View Pane
- Ostinato Client has a new action in the port window's context menu for the same
- Port Icon in the Port Window is decorated based on exclusive control
- Server now updates the "packet list" after every "apply" rather than before a "start transmit" (if dirty) - this better reflects user's expectation from these operations
- Client disables the entire application and changes to a "Busy" cursor when "applying" stream configuration
Fixes
- UDP checksum no longer is zero but a valid value
- Order of streams no longer gets messed up across a "apply"
- Major code reorganization of the server code across several classes with fewer 'friends'
- New server classes - AbstractPort, PcapPort, WinPcapPort, PortManager
- With this reorg classes have more focus than earlier and will be hopefully easy to extend
Fixes
- Ostinato client is now able to successfully reconnect and talk to the Ostinato server after a disconnect - earlier, if a method had been pending during the disconnect, the communication was not up after a reconnect; pending methods are cleaned up at disconnect now
- Ostinato Client
- will start the server as a child process at startup and terminate it at exit
- Ostinato Server (Drone)
- is now a system tray application
- if not able to bind to a IP/Port successfully, informs the user and exits
- the GUI is now nothing more than a TextLabel
Others
- If a getStats() request is pending, the client will not queue up any more requests till a reply is received for the pending one
- Nitpicks in the Payload protocol Widget, PortsWindow Widget
---------------------------------
- StreamConfigDialog: Valid subsequent protocol choices for a particular protocol in the simple protocol selection widget is no longer hardcoded - ProtocolManager is queried for validitity of each pair of possible protocols; signal-slot connections are made accordingly. This refactoring makes it easier to add a protocol to the simple protocol selection widget
- ProtocolManager: populates and maintains a database of valid 'neighbour protocols' and implements a method - isValidNeighbour() to query the same for a pair of protocols
- AbstractProtocol: new method protocolIdType() introduced to build the above database (in conjunction with the existing method protocolId(ProtocolIdType)); default implementation returns ProtocolIdNone
- Protocols which include a valid/supported ProtocolIdType (eth/llc/ip) reimplement protocolIdType() to return the apporpirate ProtocolIdType. These are viz.
- combo
- eth
- llc
- snap
- ip
- Speed optimization while populating streamqueues if the protocolFrameValue/Size() does not vary across packets
- AbstractProtocol: new methods to support the above optimization
- isProtocolFrameValueVariable()
- isProtocolFrameSizeVariable()
- isProtocolFramePayloadValueVariable()
- isProtocolFramePayloadSizeVariable()
(each of the default implementations returns false indicating that the protocol frame value or frame size is fixed and not variable)
- Protocols which support variable values/size (list follows) reimplement the above methods appropriately
- combo
- mac
- dot3
- ip4
- tcp
- udp
- payload
- StreamInfo::makePacket() moved to base class as StreamBase::frameValue()
- StreamBase: all 'get' accessor functions made 'const'
- class ProtocolManager: while registering a protocol, no need to pass the protocol name; ProtocolManager finds it out internally by using the protocol's shortName() method
Fixes
-----
- Fixed issue with port capture not starting the first time 'start capture' was clicked
- Port State (Link/Transmit/Capture) now updated alongwith port stats
- On link state change, the port window is not updated - partial changes have been done under #if 0; needs refactoring of Port Class implementation/usage before a signal/slot for the same can be implemented
Fixes
- Fixed crash in client when connection to server is broken
- Packet Capture and Capture Buffer Retrieval now works correctly and consistently (I think!)
Others
- Minor visual changes in Ports Window
- Port Stats Window now has 'right' alignment for stats data and 'center' for state data
- Added support for retrieving the packet capture buffer from server to client (does not work consistently however - needs investigation)
- getCaptureBuffer() Rpc signature changed
- RPC: Added support in Rpc Channel (client) to queue calls
- RPC: Added support for transferring arbitrary binary data from server to client (used to get packet capture files)
- Rpc header changed - length is now 4 bytes instead of 2; there is no rsvd field any longer
Fixes
- RPC: Fix for the case when a msg is not received all at once over the socket
- StreamConfigDialog: fixed display issue in packet view for combo protocols containing meta fields
- Fixed issue with Stacked Vlan not retaining data for both CVlan and SVlan
- Fixed incorrect payload size issue with increment/decrement frame length modes
Refactoring, Cleanup etc.
- RPC: Minor code and TODOs cleanup
- Server: Minor code and TODOs cleanup
- Server: Removed unused file(s): rxtx.cpp, rxtx.h
- Server: Replaced direct use of ProtocolList with the ProtocolListIterator
- Common: Minor code and TODOs cleanup
- StreamBase::frameLen() now returns the length based on the mode/min/max and the passed in streamIndex
- AbstractProtocol interface changed for methods - protocolFrameSize(), protocolFrameOffset(), protocolFramePayloadSize() : all of them now take streamIndex as an optional param with 0 as the default value
- Protocols implementing the above methods changed accordingly
--------------------------
- AbstractProtocol Constructor and Factory function now take an optional (default NULL) "parent" abstract protocol in addition to the stream; this "parent" protocol is non-NULL for protocols which are aggregated in a ComboProtocol
- All subclasses of AbstractProtocol modified as per the above interface change
- ProtocolManager also modifed as per the above interface change
- new data members in AbstractProtocol - prev, next; the AbstractProtocol implementation now uses these members to traverse protocols on the list instead of ProtocolListIterator; this change required for ComboProtocol
- ProtocolListIterator updates these new members - prev/next on insert/remove/replace
- ComboProtocol and ProtocolListIterator classes made friends of AbstractProtocol
- ComboProtocol implemented as a template class (completed)
- Dot2LLc implemented as a combo of Dot3Raw and LLC
- Dot2Snap implemented as a combo of Dot2Llc and SNAP
- VlanStack implemented as a combo of VLAN + VLAN
- ProtocolManager now uses the ProtocolId enums rather than hardcoded values
Stream Config Dialog
--------------------
- "None" radio button added to all protocol levels
- Protocol Level 1 added with 'mac' as the only valid protocol in the "simple" mode widget
- With Dot2Llc, Dot2Snap and VlanStack implemented as "combo" protocols, the protocol choice radiobuttons in the "simple" mode are now 1:1 with a protocol; this has the following implications/advantages:
- Updates of the "simple" mode widget from/to stream's protocolList is simpler; this code has now been rewritten to take advantage of 1:1
- This paves the way for exporting tunneled protocols 4over4, 4over6, 6over4 etc. in the "simple" mode
- This should also (hopefully) require less changes when adding a new protocol; more work needs to be done to reach this goal
Fixes
-----
- Dot3Protocol now derives "length" correctly for VLAN tagged packets
- StreamBase now uses the ProtocolListIterator to append the default protocols in a stream instead of directly manipulating ProtocolList; also in protoDataCopyFrom()
Others (Client/Server)
----------------------
- Port Packet Capture implemented; "view capture" is pending (hack put in place now for testing)
Common
------
- Change in OstProto
- Individual protocols are now extensions of (new) message 'Protocol' instead of 'Stream'
- Stream now contains a repeated Protocol which also determines the ordered set of currently selected protocols; StreamCore.frame_proto which was doing this earlier has been removed
- Change in AbstractProtocol Interface
- Parent changed to StreamBase
- Corresponding change in constructor and factory func - createInstance()
- new method protocolNumber() - returns unique id for each protocol
- protoDataCopyInto/From() now copies into OstProto::Protocol instead of OstProto::Stream
- Change in all subclasses of AbstractProtocol to match new interface
- For all protocols, configFrom is no longer static, but each protocol has its own configForm
- configForm creation is lazy
- configForm is still a child of the protocol i.e. it will be destroyed alongwith the protocol
- TODO: convert configWidget() to a pure factory function i.e. the protocol does not own the configForm - this requires us to pass the widget into load/storeConfigWidget() methods
- ProtocolCollection class removed alongwith its .h and .cpp
- ProtocolList class redefined to serve the purpose of ProtocolCollection
- New class ProtocolListIterator defined to iterate ProtocolList
- AbstractProtocol methods now use the ProtocolListIterator
- Factory function createProtocol() added to ProtocolManager
- OstProto::StreamCore accessor functions moved from Stream to StreamBase
Server
------
- MyService uses the newly moved accessors to StreamBase for OstProto::StreamCore members
- StreamInfo now uses the protocols to create the packet
Client
------
- StreamConfigDialog now uses ProtocolListIterator
- So does PacketModel
- New Classes:
o ProtocolManager - singleton with which all protocols register
o ProtocolCollection - Aggregates all registered protocols; exports methods to work on all protocols
o StreamBase - aggregates ProtocolCollection with Stream Core and Control; the client/server side stream classes now derive from StreamBase leading to major reduction in their code (more cleanup pending)
- AbstractProtocol now supports the additional methods
o createInstance()
o protocolFrameSize()
o protocolFrameOffset(), protocolFramePayloadSize()
o protocolId(), payloadProtocolId()
o protocolFrameCksum(), protocolFramePayloadCksum()
0 constructor takes an extra param - frameProtoList
- Specific protocols - eth2, llc, snap, ip4, udp, tcp now return length, protocol id and cksums correctly (tcp/udp cksum pending)
- StreamConfigDialog - protocol controls for length, cksum and protocolid are automatically updated (not fully working yet)
- StreamListView now has a delegate to display a combobox for "nextWhat" and a checkbox for "status"
- StreamListView now has reasonable default widths for its columns
- Packet Transmission rate (IPG) is done - need to test. IBG is still pending
- Per port there are two pcap_t handles - one for Rx and one for Tx: since PCAP does not capture loopback packets, transmission by OST happens on Rx Hdl so that they are recieved on the Tx Hdl
- pcap_loop() changed to pcap_dispatch() to be able to work in PCAP/Linux - forgot exactly why :-)
- Removed NIC stats
- Implemented PortStatsFilterDialog ordering of ports
- PortStatsWindow - Tooltip on Port column dispays stats limitations
Frame Length Modes done.
Data Pattern Modes done.
Some minor fixes/enhancements in streamconfigdialog.
Added a "Edit Stream" action in StreamList context menu
