Commit Graph

177 Commits

Author SHA1 Message Date
Srivats P
9a4e7e7550 Silence warnings 2018-05-22 21:48:21 +05:30
Bernhard Ehlers
1d8bb9f4df Fix warnings about DumpView::dataChanged and struct StatsTuple 2018-05-21 21:31:44 +02:00
Andreas Sturmlechner
53308971e6
Fix build with Qt 5.11 (missing QButtonGroup) 2018-05-12 01:16:10 +02:00
Srivats P
a16eefbff4 Treat warnings as errors and fix existing warnings 2018-04-20 20:50:51 +05:30
Srivats P
227b8bdae4 Use modeltest only for debug and if Qt >= 5.7
The modeltest code is not compatible with Qt 5.6 LTS
2018-04-02 20:39:44 +05:30
Srivats P
db231054da Fix Qt4 to Qt5 porting issues with debug build
Also update modeltest to Qt5
2018-03-27 20:02:36 +05:30
Srivats P
f801982830 Port common, rpc and client code to Qt5
Still pending
* server port to Qt5
* verify/test the port
2018-03-14 21:58:56 +05:30
Srivats P
1347165ef0 Add helpful hint text to variable fields widget 2018-02-21 21:57:46 +05:30
Srivats P
52a5cb0d30 Improve UX for variable fields configuration
* Redesign the toolbar buttons to be similar to port stats
* Show protocols with variable fields in bold
* Variable field list will always have a 'current', if not empty
* Adding a new variable field makes it 'current' for immediate edit
* Each protocol remembers its 'current' variable field

Also renamed UserRole to a more widget specific enum
2018-02-10 12:40:10 +05:30
Srivats P
57597fe794 Merge branch 'master' of D:/srivatsp/projects/ostinato/master 2018-02-08 22:39:52 +05:30
Srivats P
0b407af04c Use alternate row colors for port stats window
This makes it more readable. Unfortunately, the alternate row colors
don't apply to the row headers. QHeaderView is supposed to support
QBackgroundRole but there's a long pending bug on the Qt side for the
same - https://bugreports.qt.io/browse/QTBUG-31804
2018-02-08 22:39:22 +05:30
Srivats P
d370907597 Fix max value of step/count for counter32 var fields 2018-02-07 20:45:43 +05:30
Srivats P
f756ead433 Add Tx/Rx bps to GUI stats window
bps stats are derived from the Bps stats and represent line rate taking
into account the per packet overhead on the line with the following
assumptions -
* Link type is Ethernet
* Bps (and total Bytes) stats don't include the 4-byte FCS

Fixes #241
2018-01-31 16:03:34 +05:30
Srivats P
3f780fe564 Fix error message to specify -c instead of -s 2018-01-01 09:43:27 +05:30
Srivats P
ddafdc0073 Update copyright years in about dialog 2018-01-01 09:39:54 +05:30
Srivats P
c0f94ec58c Use static linking on win32 2017-12-07 19:04:18 +05:30
Srivats P
847af21c43 Rename ostinato option -s to -c (controller only) 2017-12-07 19:03:28 +05:30
Srivats P
92d4c260a0 Stream stats UX improvements
* Enable button only when one or more port is selected
* Reorder the button to make it first in the stats group
* Show some helpful text instead of a blank window when no stream stats
are available
2017-12-06 20:47:26 +05:30
Srivats P
bfd31179dc Add thousands separator to port stats
Fixes #201
2017-12-06 18:43:00 +05:30
Srivats P
c3adc74351 Merge branch 'master' of D:/srivatsp/projects/ostinato/master 2017-12-06 18:21:25 +05:30
Srivats P
6dd6511269 Merge branch 'master' into sign 2017-12-03 12:59:26 +05:30
Srivats P
81e7e735bc sign: Resolve a few FIXMEs
* Rename track_stream_stats to is_tracking_stream_stats for consistency
with other bool params
* Change signature magic value to CODA
* Resolve notify memory leak
2017-12-03 11:26:09 +05:30
Srivats P
b60faa727c UX: Include FAQ url in portgroup hint page 2017-10-24 18:37:30 +05:30
Srivats P
b3fb053cca Change all URLs to jump URLs 2017-10-10 21:36:06 +05:30
Srivats P
f9b83763bd UX: Change apply hint color to red
Changing the color to be same as the port name color shows that these
are related
2017-10-05 20:04:23 +05:30
Srivats P
c53a1866b8 UX: Show stream check results as a bulleted list 2017-09-30 22:17:06 +05:30
Srivats P
57e8fe7236 UX: Report more drone startup errors
* Changed drone exit code from -1 to 1 'coz typically exit codes are
between 0 and 255
* Detect and report drone TCP port bind failure
* In all the following drone errors are reported (including previous
  commits) -
  * Drone already running (TCP port bind failure)
  * Drone executable not found
  * Packet.dll not found (Win32 only)
* The following conditions should NOT be reported
  * Start/Stop Ostinato
    * Stop before 5sec
    * Stop after 5sec
2017-09-26 19:59:49 +05:30
Srivats P
a2b349e5b7 Inform user about Drone version incompatibility 2017-09-25 21:26:57 +05:30
Srivats P
de04acec98 Tweak error message when local drone start fails 2017-09-23 18:54:42 +05:30
Srivats P
ce7f9d808f Fix missing MsgBox on packet.dll missing
started is emitted before the missing dll is detected, so user a timer
to disconnect the signal-slot connection
2017-09-23 18:53:12 +05:30
Srivats P
d32253b699 Make URL in new Version status message clickable
Additionally this message is now permanently visible won't be replaced
or obscured by other (temporary) messages
2017-09-23 17:28:35 +05:30
Srivats P
b2291eb1c0 Tweak text for Port Group has no ports 2017-09-23 16:47:02 +05:30
Srivats P
6bd687e2bc UX: Enhance StreamConfigDialog
* Add stream name/enabled fields to dialog
* Change Dialog title to include current stream name
2017-09-22 20:45:42 +05:30
Srivats P
7d4f285d8d UX: Tweak welcome message 2017-09-21 21:11:34 +05:30
Srivats P
1047f0b1d8 Fix warning 2017-09-21 20:50:24 +05:30
Srivats P
fd8db1cf15 UX: Add text hints to Devices Widget 2017-09-21 20:43:54 +05:30
Srivats P
f62a3be54a UX: Don't allow edit of non-contiguous streams
Allowing this has potential of confusion for user when using Prev/Next
2017-09-20 22:05:13 +05:30
Srivats P
fd243f6847 UX: Open StreamConfigDialog on add stream
Add+Edit is now reduced to single step. For new users, it is easier to
comprehend this single step and no text hint is needed for edit
2017-09-20 22:00:47 +05:30
Srivats P
360fa13c97 UX: Edit multiple streams in the StreamConfigDialog
The dialog now accepts a list of streams as input and has prev/next
buttons to tranverse through the list making changes in one or more of
the streams
2017-09-17 13:18:44 +05:30
Srivats P
509e9d5398 Change Stream Config Dialog inputs
This is the first of many commits that lays the foundation for -
  * Editing multiple streams without exiting the dialog
  * Triggering the dialog when a new stream is added instead of add+edit
2017-09-16 12:30:00 +05:30
Srivats P
db77563466 UX: Change port name color if local config is changed
Although the applyHint is also changed in this case, the applyHint is
visible only when the port is selected. Having the port name in a
different color is a visual hint to the user that Apply is pending
2017-09-16 12:12:43 +05:30
Srivats P
3aa44343f0 Add new entry at end if nothing selected in stream/devGrp list 2017-09-14 21:01:56 +05:30
Srivats P
cca2e94bb3 Detect when port config has changed and needs to APPLY'd
For now we prompt user to click Apply, in future we can use this to do a
"Auto Apply"
2017-09-14 20:38:13 +05:30
Srivats P
4d13ecf15d UX: Add text hint about stream list
Remove text about how to create streams from Apply text hint. Make
hint text copy consistent across all hints
2017-09-09 18:57:55 +05:30
Srivats P
abb48a1c12 UX: Auto expand port group and allow deselect in PortsWindow 2017-09-09 13:13:52 +05:30
Srivats P
d348229028 UX: Improve PortStatsWindow select, toolbar buttons
- Automatic full column selection
- Enable/Disable toolbar buttons based on selection
- Code refactoring to avoid unncessary selectedColumns computation
2017-09-08 21:13:53 +05:30
Srivats P
88cea753b6 UX: Add category labels to Port Stats Window toolbar 2017-09-07 20:48:46 +05:30
Srivats P
40c5e00ec2 (UX) Add textual hints for to the ports window
Improves first run experience
2017-09-07 20:45:43 +05:30
Srivats P
cb52f9ade1 Inform user if local drone doesn't start 2017-09-04 22:57:45 +05:30
Srivats P
d39fbc2ed4 Add UTM params to docs url 2017-09-04 18:57:13 +05:30